Sign upLogin

atk4/data

View on GitHub
Star

Showing 246 of 247 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function _renderConditionBinaryReuseBool(string $sqlLeft, string $sqlRight, \Closure $makeSqlFx, bool $nullFromArgsOnly = false): string
    {
        $reuse = $this->_renderConditionBinaryReuse($sqlLeft, $sqlRight, static fn () => '') !== '';

        return $this->_renderConditionBinaryReuse(
Severity: Major
Found in src/Persistence/Sql/Mssql/Query.php and 1 other location - About 4 hrs to fix
src/Persistence/Sql/Oracle/Query.php on lines 23..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function _renderConditionBinaryReuseBool(string $sqlLeft, string $sqlRight, \Closure $makeSqlFx, bool $nullFromArgsOnly = false): string
    {
        $reuse = $this->_renderConditionBinaryReuse($sqlLeft, $sqlRight, static fn () => '') !== '';

        return $this->_renderConditionBinaryReuse(
Severity: Major
Found in src/Persistence/Sql/Oracle/Query.php and 1 other location - About 4 hrs to fix
src/Persistence/Sql/Mssql/Query.php on lines 43..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Expression has 32 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Expression implements Expressionable, \ArrayAccess
{
    use DiContainerTrait;

    private static ?SqlFormatter $debugFormatter = null;
Severity: Minor
Found in src/Persistence/Sql/Expression.php - About 4 hrs to fix

Join has 32 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Join
{
    use DiContainerTrait;
    use InitializerTrait {
        init as private _init;
Severity: Minor
Found in src/Model/Join.php - About 4 hrs to fix

File Condition.php has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data\Model\Scope;
Severity: Minor
Found in src/Model/Scope/Condition.php - About 4 hrs to fix

File TestCase.php has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data\Schema;
Severity: Minor
Found in src/Schema/TestCase.php - About 4 hrs to fix

Function initQueryFields has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function initQueryFields(Model $model, Query $query, ?array $fields = null): void
    {
        // init fields
        if ($fields !== null) {
            // set of fields is strictly defined, so we will ignore even system fields
Severity: Minor
Found in src/Persistence/Sql.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Array_.php has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data\Persistence;
Severity: Minor
Found in src/Persistence/Array_.php - About 3 hrs to fix

Sql has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

class Sql extends Persistence
{
    use Sql\BinaryStringCompatibilityTypecastTrait;
    use Sql\ExplicitCastCompatibilityTypecastTrait;
Severity: Minor
Found in src/Persistence/Sql.php - About 3 hrs to fix

Method normalize has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function normalize($value)
    {
        try {
            if ($this->issetOwner() && $this->getOwner()->hook(Model::HOOK_NORMALIZE, [$this, $value]) === false) {
                return $value;
Severity: Major
Found in src/Field.php - About 3 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    #[\Override]
    protected function updateRenderBeforeExecute(array $render): array
    {
        [$sql, $params] = $render;
Severity: Major
Found in src/Persistence/Sql/Mssql/ExpressionTrait.php and 1 other location - About 3 hrs to fix
src/Persistence/Sql/Mysql/ExpressionTrait.php on lines 42..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    #[\Override]
    protected function updateRenderBeforeExecute(array $render): array
    {
        [$sql, $params] = $render;
Severity: Major
Found in src/Persistence/Sql/Mysql/ExpressionTrait.php and 1 other location - About 3 hrs to fix
src/Persistence/Sql/Mssql/ExpressionTrait.php on lines 90..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function valueToWords has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    protected function valueToWords(Model $model, $value): string
    {
        if ($value === null) {
            return $this->operator
                ? 'empty'
Severity: Minor
Found in src/Model/Scope/Condition.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Field.php has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data;
Severity: Minor
Found in src/Field.php - About 3 hrs to fix

Method _copy has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _copy(Model $source, Model $destination, array $references, array $exclusions, array $transforms): Model
    {
        try {
            $sourceTable = $source->getModel()->table;
Severity: Major
Found in src/Util/DeepCopy.php - About 3 hrs to fix

Function listSequences has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function listSequences(): array
    {
        if (version_compare(Connection::getDriverVersion(), '3.37') < 0) {
            $listAllSchemasSql = (new Query())
                ->table('pragma_database_list')
Severity: Minor
Found in src/Persistence/Sql/Sqlite/PreserveAutoincrementOnRollbackConnectionMiddleware.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(array $data = [])
    {
        if (count($data) > 0 && !is_array(reset($data))) {
            $dataOrig = $data;
            $data = [];
Severity: Major
Found in src/Persistence/Static_.php - About 3 hrs to fix

Method action has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function action(Model $model, string $type, array $args = [])
    {
        switch ($type) {
            case 'select':
                $query = $this->initQuery($model);
Severity: Major
Found in src/Persistence/Sql.php - About 3 hrs to fix

Method _typecastPreField has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _typecastPreField(Field $field, $value, bool $fromLoad)
    {
        if (is_string($value)) {
            switch ($field->type) {
                case 'boolean':
Severity: Major
Found in src/Persistence.php - About 3 hrs to fix

Migrator has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Migrator
{
    public const REF_TYPE_NONE = 0;
    public const REF_TYPE_LINK = 1;
    public const REF_TYPE_PRIMARY = 2;
Severity: Minor
Found in src/Schema/Migrator.php - About 3 hrs to fix
Severity
Category
Status
Source
Language