atk4/data

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    #[\Override]
    protected function getCreateColumnCommentSQL($tableName, $columnName, $comment)
    {
        if (str_contains($tableName, '.')) {
            [$schemaName, $tableName] = explode('.', $tableName);

Found in src/Persistence/Sql/Mssql/PlatformTrait.php and 1 other location - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

src/Persistence/Sql/Mssql/PlatformTrait.php on lines 91..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    #[\Override]
    protected function getAlterColumnCommentSQL($tableName, $columnName, $comment)
    {
        if (str_contains($tableName, '.')) {
            [$schemaName, $tableName] = explode('.', $tableName);

Found in src/Persistence/Sql/Mssql/PlatformTrait.php and 1 other location - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

src/Persistence/Sql/Mssql/PlatformTrait.php on lines 70..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `save` has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save(array $data = [])
    {
        $this->getModel()->assertIsWritable();
        $this->getModel()->assertHasPersistence();

Found in src/Model.php - About 2 hrs to fix

Create a ticket
Create a ticket

Function `__construct` has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($field, $operator = null, $value = null)
    {
        if ($field instanceof AbstractScope) {
            throw new Exception('Only Scope can contain another conditions');
        } elseif ($field instanceof Field) { // for BC

Found in src/Model/Scope/Condition.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

File `Reference.php` has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data;

Found in src/Reference.php - About 2 hrs to fix

Create a ticket
Create a ticket

Method `_subrenderCondition` has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _subrenderCondition(array $row): string
    {
        if (count($row) === 1) {
            [$field] = $row;
        } elseif (count($row) === 3) {

Found in src/Persistence/Sql/Query.php - About 2 hrs to fix

Create a ticket
Create a ticket

`Field` has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class Field implements Expressionable
{
    use DiContainerTrait {
        setDefaults as private _setDefaults;
    }

Found in src/Field.php - About 2 hrs to fix

Create a ticket
Create a ticket

Function `_subrenderCondition` has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    #[\Override]
    protected function _subrenderCondition(array $row): string
    {
        if (count($row) !== 1) {
            [$field, $operator, $value] = $row;

Found in src/Persistence/Sql/Oracle/Query.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `evaluateIf` has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function evaluateIf($v1, string $operator, $v2): bool
    {
        if ($v2 instanceof self) {
            $v2 = $v2->getRows();
        }

Found in src/Persistence/Array_/Action.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `_execute` has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _execute(?object $connection, bool $fromExecuteStatement)
    {
        if ($connection === null) {
            $connection = $this->connection;
        }

Found in src/Persistence/Sql/Expression.php - About 2 hrs to fix

Create a ticket
Create a ticket

`Connection` has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Connection
{
    use DiContainerTrait;

    /** @var class-string<Expression> */

Found in src/Persistence/Sql/Connection.php - About 2 hrs to fix

Create a ticket
Create a ticket

`Reference` has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Reference
{
    use DiContainerTrait;
    use InitializerTrait {
        init as private _init;

Found in src/Reference.php - About 2 hrs to fix

Create a ticket
Create a ticket

Method `normalizeDsn` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function normalizeDsn($dsn, $user = null, $password = null)
    {
        // BC for 2.4 - 3.0 accepted DSN input
        if (is_string($dsn)) {
            $dsn = ['dsn' => $dsn];

Found in src/Persistence/Sql/Connection.php - About 2 hrs to fix

Create a ticket
Create a ticket

Function `createIteratorBy` has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function createIteratorBy($field, $operator = null, $value = null): \Traversable
    {
        $this->assertIsModel();

        $scopeOrig = null;

Found in src/Model.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `match` has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    protected function match(array $row, Model\Scope\AbstractScope $condition): bool
    {
        if ($condition instanceof Model\Scope\Condition) { // simple condition
            $args = $condition->toQueryArguments();

Found in src/Persistence/Array_/Action.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `fixMssqlOracleMissingFieldsInGroup` has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private function fixMssqlOracleMissingFieldsInGroup(Model $model, Query $query): void
    {
        if ($this->getDatabasePlatform() instanceof SQLServerPlatform
                || $this->getDatabasePlatform() instanceof OraclePlatform) {
            $isIdFieldInGroup = false;

Found in src/Persistence/Sql.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `escapeStringLiteral` has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    #[\Override]
    protected function escapeStringLiteral(string $value): string
    {
        $dummyPersistence = (new \ReflectionClass(Persistence\Sql::class))->newInstanceWithoutConstructor();
        if (\Closure::bind(static fn () => $dummyPersistence->explicitCastIsEncodedBinary($value), null, Persistence\Sql::class)()) {

Found in src/Persistence/Sql/Mssql/ExpressionTrait.php - About 2 hrs to fix

Read up
Read up
Create a ticket
Create a ticket

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

File `Connection.php` has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data\Persistence\Sql;

Found in src/Persistence/Sql/Connection.php - About 2 hrs to fix

Create a ticket
Create a ticket

`Array_` has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Array_ extends Persistence
{
    /** @var array<string, array<int|string, mixed>> */
    private array $seedData;

Found in src/Persistence/Array_.php - About 2 hrs to fix

Create a ticket
Create a ticket

Method `evaluateIf` has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function evaluateIf($v1, string $operator, $v2): bool
    {
        if ($v2 instanceof self) {
            $v2 = $v2->getRows();
        }

Found in src/Persistence/Array_/Action.php - About 2 hrs to fix

Create a ticket
Create a ticket