Showing 250 of 251 total issues
Migrator
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
class Migrator
{
public const REF_TYPE_NONE = 0;
public const REF_TYPE_LINK = 1;
public const REF_TYPE_PRIMARY = 2;
- Create a ticketCreate a ticket
Method logQuery
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function logQuery(string $sql, array $params, array $types): void
{
if (!$this->debug) {
return;
}
- Create a ticketCreate a ticket
Method evaluateIf
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function evaluateIf($v1, string $operator, $v2): bool
{
if ($v2 instanceof self) {
$v2 = $v2->getRows();
}
- Create a ticketCreate a ticket
Function escapeStringLiteral
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
#[\Override]
protected function escapeStringLiteral(string $value): string
{
// Oracle (multibyte) string literal is limited to 1332 bytes
$parts = $this->splitLongString($value, 1000);
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method setDb
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function setDb(array $dbData, bool $importData = true): void
{
foreach ($dbData as $tableName => $data) {
$migrator = $this->createMigrator()->table($tableName);
- Create a ticketCreate a ticket
Method listSequences
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function listSequences(): array
{
if (version_compare(Connection::getDriverVersion(), '3.37') < 0) {
$listAllSchemasSql = (new Query())
->table('pragma_database_list')
- Create a ticketCreate a ticket
Persistence
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
abstract class Persistence
{
use ContainerTrait {
add as private _add;
}
- Create a ticketCreate a ticket
Similar blocks of code found in 2 locations. Consider refactoring. Open
protected function onHookToOwnerModel(string $spot, \Closure $fx, array $args = [], int $priority = 5): int
{
$name = $this->shortName; // use static function to allow this object to be GCed
return $this->getOwner()->onHookDynamic(
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 124.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
protected function onHookToOurModel(string $spot, \Closure $fx, array $args = [], int $priority = 5): int
{
$name = $this->shortName; // use static function to allow this object to be GCed
return $this->getOurModel()->onHookDynamic(
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 124.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method _renderConditionLikeOperator
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
#[\Override]
protected function _renderConditionLikeOperator(bool $negated, string $sqlLeft, string $sqlRight): string
{
return $this->_renderConditionBinaryReuseBool(
$sqlLeft,
- Create a ticketCreate a ticket
Method compareExportUnorderedValue
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static function compareExportUnorderedValue($a, $b): int
{
if ($a === $b) {
return 0;
}
- Create a ticketCreate a ticket
Method toQueryArguments
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function toQueryArguments(): array
{
$field = $this->field;
$operator = $this->operator;
$value = $this->value;
- Create a ticketCreate a ticket
Method valueToWords
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function valueToWords(Model $model, $value): string
{
if ($value === null) {
return $this->operator
? 'empty'
- Create a ticketCreate a ticket
Function action
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function action(Model $model, string $type, array $args = [])
{
switch ($type) {
case 'select':
$query = $this->initQuery($model);
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function join
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function join(
$foreignTable,
$masterField = null,
$joinKind = null,
$foreignAlias = null
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addKeyOwner
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function addKeyOwner(object $owner, int $hash, int $index): void
{
if (!$this->ownerDestructorHandlers->offsetExists($owner)) {
$this->ownerDestructorHandlers->offsetSet($owner, new class($this, $this->destructedEarly) {
/** @var \WeakReference<WeakAnalysingMap<TKey, TValue, TOwner>> */
- Create a ticketCreate a ticket
Method getDebugQuery
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getDebugQuery(): string
{
[$sql, $params] = $this->render();
$i = 0;
- Create a ticketCreate a ticket
Method _typecastPreField
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function _typecastPreField(Field $field, $value, bool $fromLoad)
{
if (is_string($value)) {
switch ($field->type) {
case 'boolean':
- Create a ticketCreate a ticket
Method updateRenderBeforeExecute
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
#[\Override]
protected function updateRenderBeforeExecute(array $render): array
{
[$sql, $params] = parent::updateRenderBeforeExecute($render);
- Create a ticketCreate a ticket
Function escapeStringLiteral
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
#[\Override]
protected function escapeStringLiteral(string $value): string
{
$dummyPersistence = (new \ReflectionClass(Persistence\Sql::class))->newInstanceWithoutConstructor();
if (\Closure::bind(static fn () => $dummyPersistence->binaryTypeValueIsEncoded($value), null, Persistence\Sql::class)()) {
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"