Sign upLogin

avo-hq/avo

View on GitHub
Star

Showing 86 of 92 total issues

File resource_component.rb has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Avo::ResourceComponent < Avo::BaseComponent
  include Avo::Concerns::ChecksAssocAuthorization
  include Avo::Concerns::RequestMethods

  attr_reader :fields_by_panel
Severity: Minor
Found in app/components/avo/resource_component.rb - About 2 hrs to fix

    Function item has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            item({ item, createElement }) {
          const children = []

          if (item._avatar) {
            let classes
    Severity: Major
    Found in app/javascript/js/controllers/search_controller.js - About 2 hrs to fix

      File search_controller.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* eslint-disable no-underscore-dangle */
import * as Mousetrap from 'mousetrap'
import { Controller } from '@hotwired/stimulus'
import { Turbo } from '@hotwired/turbo-rails'
import { autocomplete } from '@algolia/autocomplete-js'
      Severity: Minor
      Found in app/javascript/js/controllers/search_controller.js - About 2 hrs to fix

        Function initEdit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          initEdit() {
    const options = {
      enableTime: false,
      enableSeconds: false,
      // eslint-disable-next-line camelcase
        Severity: Major
        Found in app/javascript/js/controllers/fields/date_field_controller.js - About 2 hrs to fix

          Method create_files has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

                  def create_files
          unless tailwindcss_installed?
            say "Installing Tailwindcss"
            system "./bin/bundle add tailwindcss-rails"
            system "./bin/rails tailwindcss:install"
          Severity: Minor
          Found in lib/generators/avo/tailwindcss/install_generator.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method eject_component has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def eject_component(component_to_eject = options[:component], confirmation: true)
          # Underscore the component name
          # Example: Avo::Views::ResourceIndexComponent => avo/views/resource_index_component
          component = component_to_eject.underscore
          Severity: Minor
          Found in lib/generators/avo/eject_generator.rb - About 1 hr to fix

            Method get_fields has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                  def get_fields(panel: nil, reflection: nil, only_root: false)
        fields = get_field_definitions(only_root: only_root)
          .select do |field|
            # Get the fields for this view
            field.visible_in_view?(view: view)
            Severity: Minor
            Found in lib/avo/concerns/has_items.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method wait_for_body_class_missing has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                def wait_for_body_class_missing(klass = "turbo-loading", time = Capybara.default_max_wait_time)
      Timeout.timeout(time) do
        body = page.find(:xpath, "//body")
        break if !body[:class].to_s.include?(klass)
            Severity: Minor
            Found in lib/avo/wait_for_loaded.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set_index_params has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def set_index_params
      @index_params = {}

      # projects.has_many.users
      if @related_resource.present?
            Severity: Minor
            Found in app/controllers/avo/base_controller.rb - About 1 hr to fix

              Method fields_mapping has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def fields_mapping
          {
            primary_key: {
              field: "id"
            },
              Severity: Minor
              Found in lib/generators/avo/resource_generator.rb - About 1 hr to fix

                Method visible_items has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def visible_items
        items
          .map do |item|
            hydrate_item item
                Severity: Minor
                Found in lib/avo/concerns/has_items.rb - About 1 hr to fix

                  Method set_index_params has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def set_index_params
      @index_params = {}

      # projects.has_many.users
      if @related_resource.present?
                  Severity: Minor
                  Found in app/controllers/avo/base_controller.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def initialize(id, **args, &block)
        super(id, **args, &block)

        @link_to_record = args[:link_to_record].present? ? args[:link_to_record] : false
        @is_avatar = args[:is_avatar].present? ? args[:is_avatar] : false
                  Severity: Minor
                  Found in lib/avo/fields/file_field.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function connect has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    connect() {
    const that = this

    this.buttonTarget.onclick = () => this.showSearchPanel()
                  Severity: Minor
                  Found in app/javascript/js/controllers/search_controller.js - About 1 hr to fix

                    Method create has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def create
      # This means that the record has been created through another parent record and we need to attach it somehow.
      if params[:via_record_id].present? && params[:via_belongs_to_resource_class].nil?
        @reflection = @record.class.reflect_on_association(params[:via_relation])
        # Figure out what kind of association does the record have with the parent record
                    Severity: Minor
                    Found in app/controllers/avo/base_controller.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method respond has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        def respond
      # Flash the messages collected from the action
      flash_messages

      respond_to do |format|
                    Severity: Minor
                    Found in app/controllers/avo/actions_controller.rb - About 1 hr to fix

                      Method unwrap has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def unwrap(i, level = 0, view: :show)
    result = []

    i.items.each do |item|
      label = ""
                      Severity: Minor
                      Found in lib/avo/item_grapher.rb - About 1 hr to fix

                        Method get_fields has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              def get_fields(panel: nil, reflection: nil, only_root: false)
        fields = get_field_definitions(only_root: only_root)
          .select do |field|
            # Get the fields for this view
            field.visible_in_view?(view: view)
                        Severity: Minor
                        Found in lib/avo/concerns/has_items.rb - About 1 hr to fix

                          Method initialize has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def initialize(id, **args, &block)
        hide_on :index

        super(id, **args, &block)
                          Severity: Minor
                          Found in lib/avo/fields/code_field.rb - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            disable({ params }) {
    const { disableTarget, disableTargets } = params

    if (disableTarget) {
      this.disableAvoTarget(disableTarget)
                          Severity: Major
                          Found in app/javascript/js/controllers/resource_edit_controller.js and 1 other location - About 1 hr to fix
                          app/javascript/js/controllers/resource_edit_controller.js on lines 16..26

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 82.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language