bcit-ci/CodeIgniter

View on GitHub

Showing 865 of 865 total issues

Method __construct has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(array $params = array())
    {
        // No sessions under CLI
        if (is_cli())
        {
Severity: Major
Found in system/libraries/Session/Session.php - About 4 hrs to fix

    File Xmlrpcs.php has 335 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * CodeIgniter
     *
     * An open source application development framework for PHP
    Severity: Minor
    Found in system/libraries/Xmlrpcs.php - About 4 hrs to fix

      Method parseResponse has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function parseResponse($fp)
          {
              $data = '';
      
              while ($datum = fread($fp, 4096))
      Severity: Major
      Found in system/libraries/Xmlrpc.php - About 3 hrs to fix

        Method DB has 99 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function &DB($params = '')
        {
            // Load the DB config file if a DSN string wasn't passed
            if (is_string($params) && strpos($params, '://') === FALSE)
            {
        Severity: Major
        Found in system/database/DB.php - About 3 hrs to fix

          Function _process_fields has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _process_fields($create_table = FALSE)
              {
                  $fields = array();
          
                  foreach ($this->fields as $key => $attributes)
          Severity: Minor
          Found in system/database/DB_forge.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method closing_tag has 97 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function closing_tag($the_parser, $name)
              {
                  $the_parser = (string) $the_parser;
          
                  if ($this->xh[$the_parser]['isf'] > 1) return;
          Severity: Major
          Found in system/libraries/Xmlrpc.php - About 3 hrs to fix

            Method db_connect has 96 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function db_connect($persistent = FALSE)
                {
                    // PHP 8.1 changes default error handling mode from silent to exceptions - reverse that
                    if (is_php('8.1'))
                    {
            Severity: Major
            Found in system/database/drivers/mysqli/mysqli_driver.php - About 3 hrs to fix

              Method model has 96 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function model($model, $name = '', $db_conn = FALSE)
                  {
                      if (empty($model))
                      {
                          return $this;
              Severity: Major
              Found in system/core/Loader.php - About 3 hrs to fix

                File Profiler.php has 325 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /**
                 * CodeIgniter
                 *
                 * An open source application development framework for PHP
                Severity: Minor
                Found in system/libraries/Profiler.php - About 3 hrs to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              foreach ($query->result_array() as $row)
                              {
                                  $val_str = '';
                  
                                  $i = 0;
                  Severity: Major
                  Found in system/database/drivers/mysqli/mysqli_utility.php and 1 other location - About 3 hrs to fix
                  system/database/drivers/mysql/mysql_utility.php on lines 170..198

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 158.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              foreach ($query->result_array() as $row)
                              {
                                  $val_str = '';
                  
                                  $i = 0;
                  Severity: Major
                  Found in system/database/drivers/mysql/mysql_utility.php and 1 other location - About 3 hrs to fix
                  system/database/drivers/mysqli/mysqli_utility.php on lines 170..198

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 158.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method xss_clean has 94 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function xss_clean($str, $is_image = FALSE)
                      {
                          // Is the string an array?
                          if (is_array($str))
                          {
                  Severity: Major
                  Found in system/core/Security.php - About 3 hrs to fix

                    Method ip_address has 94 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function ip_address()
                        {
                            if ($this->ip_address !== FALSE)
                            {
                                return $this->ip_address;
                    Severity: Major
                    Found in system/core/Input.php - About 3 hrs to fix

                      Function text_watermark has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function text_watermark()
                          {
                              if ( ! ($src_img = $this->image_create_gd()))
                              {
                                  return FALSE;
                      Severity: Minor
                      Found in system/libraries/Image_lib.php - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function _execute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function _execute($m)
                          {
                              $methName = $m->method_name;
                      
                              // Check to see if it is a system call
                      Severity: Minor
                      Found in system/libraries/Xmlrpcs.php - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function backup has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function backup($params = array())
                          {
                              // If the parameters have not been submitted as an
                              // array then we know that it is simply the table
                              // name, which is a valid short cut.
                      Severity: Minor
                      Found in system/database/DB_utility.php - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          protected function _list_tables($prefix_limit = FALSE)
                          {
                              $sql = 'SELECT '.$this->escape_identifiers('name')
                                  .' FROM '.$this->escape_identifiers('sysobjects')
                                  .' WHERE '.$this->escape_identifiers('type')." = 'U'";
                      Severity: Major
                      Found in system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php and 2 other locations - About 3 hrs to fix
                      system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php on lines 185..198
                      system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 291..304

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 156.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          protected function _list_tables($prefix_limit = FALSE)
                          {
                              $sql = 'SELECT '.$this->escape_identifiers('name')
                                  .' FROM '.$this->escape_identifiers('sysobjects')
                                  .' WHERE '.$this->escape_identifiers('type')." = 'U'";
                      system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php on lines 161..174
                      system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 291..304

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 156.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          protected function _list_tables($prefix_limit = FALSE)
                          {
                              $sql = 'SELECT '.$this->escape_identifiers('name')
                                  .' FROM '.$this->escape_identifiers('sysobjects')
                                  .' WHERE '.$this->escape_identifiers('type')." = 'U'";
                      Severity: Major
                      Found in system/database/drivers/sqlsrv/sqlsrv_driver.php and 2 other locations - About 3 hrs to fix
                      system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php on lines 161..174
                      system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php on lines 185..198

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 156.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method auto_typography has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function auto_typography($str, $reduce_linebreaks = FALSE)
                          {
                              if ($str === '')
                              {
                                  return '';
                      Severity: Major
                      Found in system/libraries/Typography.php - About 3 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language