Sign upLogin

bollu/symengine.hs

View on GitHub
Star

Showing 159 of 159 total issues

Use camelCase
Open

mod_f = lift_basicsym_binaryop ntheory_mod_f_ffi
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

mod_f = ...

Perhaps

modF = ...

Use camelCase
Open

vecbasic_size :: VecBasic -> Int
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

vecbasic_size :: VecBasic -> Int

Perhaps

vecbasicSize :: VecBasic -> Int

Use camelCase
Open

densematrix_mul_matrix :: forall r k c. (KnownNat r, KnownNat k, KnownNat c) => 
  DenseMatrix r k -> DenseMatrix k c -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_matrix ::
  forall r k c.
  (KnownNat r, KnownNat k, KnownNat c) =>
  DenseMatrix r k -> DenseMatrix k c -> DenseMatrix r c

Perhaps

densematrixMulMatrix ::
  forall r k c.
  (KnownNat r, KnownNat k, KnownNat c) =>
  DenseMatrix r k -> DenseMatrix k c -> DenseMatrix r c

Avoid lambda
Open

                    with b (\b ->
                              ntheory_gcd_ext_ffi g s t a b))
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

\ b -> ntheory_gcd_ext_ffi g s t a b

Perhaps

ntheory_gcd_ext_ffi g s t a

Use camelCase
Open

next_prime :: BasicSym -> BasicSym
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

next_prime :: BasicSym -> BasicSym

Perhaps

nextPrime :: BasicSym -> BasicSym

Use camelCase
Open

vecbasic_new = do
    ptr <- vecbasic_new_ffi
    finalized <- newForeignPtr vecbasic_free_ffi ptr
    return $ VecBasic (finalized)
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

vecbasic_new = ...

Perhaps

vecbasicNew = ...

Avoid lambda
Open

  forM_ syms (\sym -> with sym (\s -> vecbasic_push_back_ffi ptr s))
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

\ s -> vecbasic_push_back_ffi ptr s

Perhaps

vecbasic_push_back_ffi ptr

Use camelCase
Open

basic_str :: BasicSym -> String
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_str :: BasicSym -> String

Perhaps

basicStr :: BasicSym -> String

Use camelCase
Open

densematrix_new_rows_cols ::  forall r c . (KnownNat r, KnownNat c) => DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_rows_cols ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Perhaps

densematrixNewRowsCols ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Use camelCase
Open

densematrix_new_rows_cols = 
    unsafePerformIO $ DenseMatrix <$>
      (mkForeignPtr (cdensematrix_new_rows_cols_ffi 
                      (fromIntegral . natVal $ (Proxy @ r))
                      (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_rows_cols = ...

Perhaps

densematrixNewRowsCols = ...

Use camelCase
Open

densematrix_new_zeros :: forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_zeros ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Perhaps

densematrixNewZeros ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Redundant $
Open

      let indexc = fromIntegral $ (getFinite getc)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral $ (getFinite getc)

Perhaps

fromIntegral (getFinite getc)

Use camelCase
Open

densematrix_mul_matrix mata matb = unsafePerformIO $ do
   res <- densematrix_new
   throwOnSymIntException =<< with3 res mata matb cdensematrix_mul_matrix_ffi
   return res
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_matrix mata matb = ...

Perhaps

densematrixMulMatrix mata matb = ...

Avoid lambda
Open

with2 o1 o2 f = with o1 (\p1 -> with o2 (\p2 -> f p1 p2))
Severity: Minor
Found in src/Symengine/Internal.hs by hlint

Found

\ p2 -> f p1 p2

Perhaps

f p1

Use camelCase
Open

vecbasic_get :: VecBasic -> Int -> Either SymengineException BasicSym
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

vecbasic_get ::
  VecBasic -> Int -> Either SymengineException BasicSym

Perhaps

vecbasicGet ::
  VecBasic -> Int -> Either SymengineException BasicSym

Use camelCase
Open

vecbasic_size vec = unsafePerformIO $
  fromIntegral <$> with vec vecbasic_size_ffi
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

vecbasic_size vec = ...

Perhaps

vecbasicSize vec = ...

Use camelCase
Open

basic_int_signed i = unsafePerformIO $ do
    iptr <- basicsym_new
    with iptr (\iptr -> integer_set_si_ffi iptr (intToCLong i) )
    return iptr
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_int_signed i = ...

Perhaps

basicIntSigned i = ...

Use camelCase
Open

symbol_new name = unsafePerformIO $ do
    s <- basicsym_new
    cname <- newCString name
    with s (\s -> symbol_set_ffi s cname)
    free cname
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

symbol_new name = ...

Perhaps

symbolNew name = ...

Use camelCase
Open

_densematrix_copy mat = do
   newmat <- densematrix_new
   throwOnSymIntException =<< with2 newmat mat cdensematrix_set_ffi
   return newmat
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

_densematrix_copy mat = ...

Perhaps

_densematrixCopy mat = ...

Redundant bracket
Open

                                     (fromIntegral . natVal $ (Proxy @ r))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r
Severity
Category
Status
Source
Language