Sign upLogin

bollu/symengine.hs

View on GitHub
Star

Showing 159 of 159 total issues

Use camelCase
Open

densematrix_size :: forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_size ::
  forall r c.
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)

Perhaps

densematrixSize ::
  forall r c.
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)

Use camelCase
Open

densematrix_mul_scalar mata sym = unsafePerformIO $ do
   res <- densematrix_new
   throwOnSymIntException =<< with3 res mata sym cdensematrix_mul_scalar_ffi
   return res
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_scalar mata sym = ...

Perhaps

densematrixMulScalar mata sym = ...

Use camelCase
Open

densematrix_lu :: (KnownNat r, KnownNat c) => DenseMatrix r c-> (L r c, U r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (L r c, U r c)

Perhaps

densematrixLu ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (L r c, U r c)

Use camelCase
Open

lift_basicsym_unaryop f a = unsafePerformIO $ do
    s <- basicsym_new 
    with2 s a f >>= throwOnSymIntException
    return $ s
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_unaryop f a = ...

Perhaps

liftBasicsymUnaryop f a = ...

Use camelCase
Open

densematrix_set :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_set ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c
  -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c

Perhaps

densematrixSet ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c
  -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c

Use camelCase
Open

densematrix_fflu mat = unsafePerformIO $ do
  fflu <- densematrix_new
  throwOnSymIntException =<< with2 fflu mat cdensematrix_fflu
  return (FFLU fflu)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_fflu mat = ...

Perhaps

densematrixFflu mat = ...

Use camelCase
Open

densematrix_ffldu ::  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> (L r c, D r c, U r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_ffldu ::
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> (L r c, D r c, U r c)

Perhaps

densematrixFfldu ::
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> (L r c, D r c, U r c)

Use camelCase
Open

densematrix_lu_solve a b = unsafePerformIO $ do
  x <- densematrix_new
  throwOnSymIntException =<< with3 x a b cdensematrix_lu_solve
  return x
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu_solve a b = ...

Perhaps

densematrixLuSolve a b = ...

Use camelCase
Open

vecbasic_push_back :: VecBasic -> BasicSym -> IO ()
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

vecbasic_push_back :: VecBasic -> BasicSym -> IO ()

Perhaps

vecbasicPushBack :: VecBasic -> BasicSym -> IO ()

Use camelCase
Open

minus_one = basicsym_construct basic_const_minus_one_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

minus_one = ...

Perhaps

minusOne = ...

Use camelCase
Open

basicsym_construct init_fn = unsafePerformIO $ do
    basic_ptr <- basicsym_new
    with basic_ptr init_fn
    return basic_ptr
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basicsym_construct init_fn = ...

Perhaps

basicsymConstruct init_fn = ...

Use camelCase
Open

ascii_art_str :: IO String
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

ascii_art_str :: IO String

Perhaps

asciiArtStr :: IO String

Use camelCase
Open

ascii_art_str = ascii_art_str_ffi >>= peekCString
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

ascii_art_str = ...

Perhaps

asciiArtStr = ...

Use camelCase
Open

basic_rational_from_integer :: Integer -> Integer -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_rational_from_integer :: Integer -> Integer -> BasicSym

Perhaps

basicRationalFromInteger :: Integer -> Integer -> BasicSym

Avoid lambda using infix
Open

    with s (\s -> symbol_set_ffi s cname)
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

\ s -> symbol_set_ffi s cname

Perhaps

(`symbol_set_ffi` cname)

Avoid lambda
Open

  let cdensemat =  with vec (\v -> cdensematrix_new_vec_ffi
                                     (fromIntegral . natVal $ (Proxy @ r))
                                     (fromIntegral . natVal $ (Proxy @ c)) v)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

\ v ->
  cdensematrix_new_vec_ffi (fromIntegral . natVal $ (Proxy @r))
    (fromIntegral . natVal $ (Proxy @c))
    v

Perhaps

cdensematrix_new_vec_ffi (fromIntegral . natVal $ (Proxy @r))
  (fromIntegral . natVal $ (Proxy @c))

Use camelCase
Open

densematrix_new_zeros = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_zeros_ffi m
                  (fromIntegral . natVal $ (Proxy @ r))
                  (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_zeros = ...

Perhaps

densematrixNewZeros = ...

Use camelCase
Open

gcd_extended :: BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

gcd_extended ::
  BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)

Perhaps

gcdExtended ::
  BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)

Redundant $
Open

  return $  (quotient, modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

return $ (quotient, modulo)

Perhaps

return (quotient, modulo)

Use newtype instead of data
Open

data BasicSym = BasicSym !(ForeignPtr CBasicSym)
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

data BasicSym = BasicSym !(ForeignPtr CBasicSym)

Perhaps

newtype BasicSym = BasicSym (ForeignPtr CBasicSym)
Severity
Category
Status
Source
Language