Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Missing top-level module documentation comment.
Open

  module Zeitwerk
Severity: Minor
Found in card/config/initializers/02_patches/zeitwerk.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

module ScopeHelpers
Severity: Minor
Found in decko/features/support/scopes.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/interaction_steps.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

    context "js" do
Severity: Minor
Found in decko/spec/controllers/files_spec.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

  context "html format" do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

Redundant curly braces around a hash parameter.
Open

        expect({ d: :e }.bury(:a, :b, 4)).to eq({ a: { b: 4 }, d: :e })
Severity: Minor
Found in card/spec/config/initializers/core_extensions_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Line is too long. [181/90]
Open

  #  watch(%r{^app/controllers/(.+)_(controller)\.rb$})  { |m| ["spec/routing/#{m[1]}_routing_spec.rb", "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb", "spec/acceptance/#{m[1]}_spec.rb"] }
Severity: Minor
Found in decko/Guardfile by rubocop

Line is too long. [96/90]
Open

  #  watch(%r{^app/views/(.+)/.*\.(erb|haml|slim)$})     { |m| "spec/features/#{m[1]}_spec.rb" }
Severity: Minor
Found in decko/Guardfile by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/history_steps.rb by rubocop

Missing top-level class documentation comment.
Open

    class TestCase
Severity: Minor
Found in decko/test/test_helper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

  module Kernel
Severity: Minor
Found in card/config/initializers/01_core_extensions/kernel.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

      module Tag
Severity: Minor
Found in card/config/initializers/02_patches/kaminari.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Remove debugger entry point save_and_open_page.
Open

  save_and_open_page
Severity: Minor
Found in decko/features/step_definitions/web_steps.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/decko_steps.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/attachment_steps.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral, Metrics/
Severity: Minor
Found in decko/features/step_definitions/edit_steps.rb by rubocop

Missing top-level class documentation comment.
Open

class CardCreateTest < ActionDispatch::PerformanceTest
Severity: Minor
Found in decko/test/performance/card_create_test.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class HomepageTest < ActionDispatch::PerformanceTest
Severity: Minor
Found in decko/test/performance/homepage_test.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

      module Nesting
Severity: Minor
Found in card/config/initializers/01_core_extensions/hash.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

  module MatchData
Severity: Minor
Found in card/config/initializers/01_core_extensions/match_data.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end
Severity
Category
Status
Source
Language