Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Missing top-level module documentation comment.
Open

      module Mysql2Adapter
Severity: Minor
Found in card/config/initializers/02_patches/active_record.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Remove debugger entry point debugger.
Open

    debugger
Severity: Minor
Found in decko/features/support/debugger.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Missing top-level module documentation comment.
Open

module EmailHelpers
Severity: Minor
Found in decko/features/step_definitions/email_steps.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

    module Merging
Severity: Minor
Found in card/config/initializers/01_core_extensions/hash.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [94/90]
Open

  #  watch(%r{^app/(.*)(\.erb|\.haml|\.slim)$})          { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
Severity: Minor
Found in decko/Guardfile by rubocop

Space inside } missing.
Open

        cucumber: { desc: "run cucumber tests", group: :monkey, alias: :cc, via: :call}
Severity: Minor
Found in decko/lib/decko/commands.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Do not suppress exceptions.
Open

    rescue StandardError
Severity: Minor
Found in decko/spec/cypress/app_commands/log_fail.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

Start context description with 'when', 'with', or 'without'.
Open

    context "success specified in request" do
Severity: Minor
Found in decko/spec/controllers/html_request_spec.rb by rubocop

Spec path should end with active_job/arguments*serializepatch*_spec.rb.
Open

RSpec.describe ActiveJob::Arguments, "serialize patch" do
Severity: Minor
Found in card/spec/config/initializers/patches/active_job_spec.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/email_steps.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

      context "called on Integer" do
Severity: Minor
Found in card/spec/config/initializers/core_extensions_spec.rb by rubocop

Line is too long. [138/90]
Open

  # callback(:run_on_modifications_begin) { puts "<script>document.body.innerHTML = '';</script>" } # use js to clear textmate's html view
Severity: Minor
Found in decko/Guardfile by rubocop

Remove debugger entry point save_and_open_page.
Open

  save_and_open_page if scenario.failed? && ENV["LAUNCHY"]
Severity: Minor
Found in decko/features/support/debugger.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Use meaningful heredoc delimiters.
Open

END_TAG
Severity: Minor
Found in decko/features/step_definitions/window_steps.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<<-SQL
  SELECT * FROM foo
SQL

# bad
<<-END
  SELECT * FROM foo
END

# bad
<<-EOS
  SELECT * FROM foo
EOS

Missing top-level class documentation comment.
Open

  class Engine < ::Rails::Engine
Severity: Minor
Found in decko/lib/decko/engine.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Spec path should end with card_controller*locationtestfromoldintegration*_spec.rb.
Open

RSpec.describe CardController, "location test from old integration" do
Severity: Minor
Found in decko/spec/controllers/location_spec.rb by rubocop

Spec path should end with /content/diff*_spec.rb.
Open

RSpec.describe Card::Content::Diff do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

Missing top-level module documentation comment.
Open

  module Module
Severity: Minor
Found in card/config/initializers/01_core_extensions/module.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Replace class var @@demark_enable with a class instance var.
Open

      @@demark_enable = true
Severity: Minor
Found in card/config/initializers/internationalization.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Missing top-level module documentation comment.
Open

module NavigationHelpers
Severity: Minor
Found in decko/features/support/paths.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end
Severity
Category
Status
Source
Language