docker/swarmkit

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (*Object) XXX_OneofWrappers() []interface{} {
    return []interface{}{
        (*Object_Node)(nil),
        (*Object_Service)(nil),
        (*Object_Network)(nil),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func FindNodes(tx ReadTx, by By) ([]*api.Node, error) {
    checkType := func(by By) error {
        switch by.(type) {
        case byName, byNamePrefix, byIDPrefix, byRole, byMembership, byCustom, byCustomPrefix:
            return nil

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func FindVolumes(tx ReadTx, by By) ([]*api.Volume, error) {
    checkType := func(by By) error {
        switch by.(type) {
        case byName, byNamePrefix, byIDPrefix, byVolumeGroup, byCustom, byCustomPrefix, byDriver:
            return nil

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (*StoreAction) XXX_OneofWrappers() []interface{} {
    return []interface{}{
        (*StoreAction_Node)(nil),
        (*StoreAction_Service)(nil),
        (*StoreAction_Task)(nil),

• Read up
  Read up

Function renewCerts has 10 return statements (exceeds 4 allowed).

Open

func renewCerts(swarmdir, unlockKey string) error {
    // First, load the existing cert.  We don't actually bother to check if
    // it's expired - this will just obtain a new cert anyway.
    krw, err := getKRW(swarmdir, unlockKey)
    if err != nil {

Function parseContainer has 10 return statements (exceeds 4 allowed).

Open

func parseContainer(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if flags.Changed("image") {
        image, err := flags.GetString("image")
        if err != nil {
            return err

Method controller.Wait has 10 return statements (exceeds 4 allowed).

Open

func (r *controller) Wait(ctx context.Context) error {
    if err := r.checkClosed(); err != nil {
        return err
    }

Function ConvertNodeWatch has 10 return statements (exceeds 4 allowed).

Open

func ConvertNodeWatch(action WatchActionKind, filters []*SelectBy) ([]Event, error) {
    var (
        m             Node
        checkFuncs    []NodeCheckFunc
        hasRole       bool

Method Server.IssueNodeCertificate has 10 return statements (exceeds 4 allowed).

Open

func (s *Server) IssueNodeCertificate(ctx context.Context, request *api.IssueNodeCertificateRequest) (*api.IssueNodeCertificateResponse, error) {
    // First, let's see if the remote node is presenting a non-empty CSR
    if len(request.CSR) == 0 {
        return nil, status.Errorf(codes.InvalidArgument, codes.InvalidArgument.String())
    }

Method Supervisor.shouldRestart has 10 return statements (exceeds 4 allowed).

Open

func (r *Supervisor) shouldRestart(ctx context.Context, t *api.Task, service *api.Service) bool {
    // TODO(aluzzardi): This function should not depend on `service`.
    // There are 3 possible restart policies.
    switch orchestrator.RestartCondition(t) {
    case api.RestartOnAny:

Method Server.UpdateNode has 10 return statements (exceeds 4 allowed).

Open

func (s *Server) UpdateNode(ctx context.Context, request *api.UpdateNodeRequest) (*api.UpdateNodeResponse, error) {
    if request.NodeID == "" || request.NodeVersion == nil {
        return nil, status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
    }
    if err := validateNodeSpec(request.Spec); err != nil {

Method Dispatcher.Tasks has 10 return statements (exceeds 4 allowed).

Open

func (d *Dispatcher) Tasks(r *api.TasksRequest, stream api.Dispatcher_TasksServer) error {
    d.rpcRW.RLock()
    defer d.rpcRW.RUnlock()

    dctx, err := d.isRunningLocked()

Method testSuite.TestNodeAllocator has 10 return statements (exceeds 4 allowed).

Open

func (suite *testSuite) TestNodeAllocator() {
    s := store.NewMemoryStore(nil)
    suite.NotNil(s)
    defer s.Close()

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (sa *StubAPIClient) called() {
    pc, _, _, ok := runtime.Caller(1)
    if !ok {
        panic("failed to update counts")
    }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (m *InternalRaftRequest) CopyFrom(src interface{}) {

    o := src.(*InternalRaftRequest)
    *m = *o
    if o.Action != nil {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (m *PublishLogsMessage) CopyFrom(src interface{}) {

    o := src.(*PublishLogsMessage)
    *m = *o
    if o.Messages != nil {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    err := a.store.Batch(func(batch *store.Batch) error {
        for _, s := range allocatedServices {
            if err := a.commitAllocatedService(ctx, batch, s); err != nil {
                log.G(ctx).WithError(err).Debugf("Failed to commit allocation of unallocated service %s", s.ID)
                continue

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    err := a.store.Batch(func(batch *store.Batch) error {
        for _, n := range allocatedNetworks {
            if err := a.commitAllocatedNetwork(ctx, batch, n); err != nil {
                log.G(ctx).WithError(err).Debugf("Failed to commit allocation of unallocated network %s", n.ID)
                continue

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (m *SubscribeLogsMessage) CopyFrom(src interface{}) {

    o := src.(*SubscribeLogsMessage)
    *m = *o
    if o.Messages != nil {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (sc *StubController) called() {
    pc, _, _, ok := runtime.Caller(1)
    if !ok {
        panic("Failed to find caller of function")
    }

• Read up
  Read up