Sign upLogin

docker/swarmkit

View on GitHub
Star

Showing 1,820 of 1,820 total issues

Avoid deeply nested control flow statements.
Open

                for shift := uint(0); ; shift += 7 {
                    if shift >= 64 {
                        return ErrIntOverflowRaft
                    }
                    if iNdEx >= l {
Severity: Major
Found in api/raft.pb.go - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    for iNdEx < postIndex {
                    var v uint64
                    for shift := uint(0); ; shift += 7 {
                        if shift >= 64 {
                            return ErrIntOverflowRaft
    Severity: Major
    Found in api/raft.pb.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if iNdEx >= l {
                        return io.ErrUnexpectedEOF
                    }
      Severity: Major
      Found in api/raft.pb.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if postIndex > l {
                    return io.ErrUnexpectedEOF
                }
        Severity: Major
        Found in api/raft.pb.go - About 45 mins to fix

          Method Orchestrator.addTasks has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (r *Orchestrator) addTasks(ctx context.Context, batch *store.Batch, service *api.Service, runningSlots map[uint64]orchestrator.Slot, deadSlots map[uint64]orchestrator.Slot, count uint64) {
          Severity: Minor
          Found in manager/orchestrator/replicated/services.go - About 45 mins to fix

            Method Orchestrator.tickTasks has 7 return statements (exceeds 4 allowed).
            Open

            func (g *Orchestrator) tickTasks(ctx context.Context) {
    if len(g.restartTasks) == 0 {
        return
    }
    err := g.store.Batch(func(batch *store.Batch) error {
            Severity: Major
            Found in manager/orchestrator/global/global.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if err != nil {
                            log.G(ctx).WithError(err).WithField("task.id", updated.ID).Warning("failed to remove old task after starting replacement")
                        }
              Severity: Major
              Found in manager/orchestrator/update/updater.go - About 45 mins to fix

                Method Updater.Run has 7 return statements (exceeds 4 allowed).
                Open

                func (u *Updater) Run(ctx context.Context, slots []orchestrator.Slot) {
    defer close(u.doneChan)

    service := u.newService
                Severity: Major
                Found in manager/orchestrator/update/updater.go - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if integer < 128 {
                        count++
                    }
                  Severity: Major
                  Found in api/raft.pb.go - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                    if postIndex < 0 {
                    return ErrInvalidLengthRaft
                }
                    Severity: Major
                    Found in api/raft.pb.go - About 45 mins to fix

                      Function DecryptPEMBlock has 7 return statements (exceeds 4 allowed).
                      Open

                      func DecryptPEMBlock(block *pem.Block, password []byte) ([]byte, error) {
    der := block.Bytes

    var privKey encryptedPrivateKeyInfo
    if _, err := asn1.Unmarshal(der, &privKey); err != nil {
                      Severity: Major
                      Found in ca/pkcs8/pkcs8.go - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if shift >= 64 {
                        return ErrIntOverflowRaft
                    }
                        Severity: Major
                        Found in api/raft.pb.go - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if b < 0x80 {
                        break
                    }
                          Severity: Major
                          Found in api/raft.pb.go - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                            if packedLen < 0 {
                    return ErrInvalidLengthRaft
                }
                            Severity: Major
                            Found in api/raft.pb.go - About 45 mins to fix

                              Method Supervisor.Restart has 7 return statements (exceeds 4 allowed).
                              Open

                              func (r *Supervisor) Restart(ctx context.Context, tx store.Tx, cluster *api.Cluster, service *api.Service, t api.Task) error {
    // TODO(aluzzardi): This function should not depend on `service`.

    // Is the old task still in the process of restarting? If so, wait for
    // its restart delay to elapse, to avoid tight restart loops (for
                              Severity: Major
                              Found in manager/orchestrator/restart/restart.go - About 45 mins to fix

                                Function AuthorizeForwardedRoleAndOrg has 7 return statements (exceeds 4 allowed).
                                Open

                                func AuthorizeForwardedRoleAndOrg(ctx context.Context, authorizedRoles, forwarderRoles []string, org string, blacklistedCerts map[string]*api.BlacklistedCertificate) (string, error) {
    if isForwardedRequest(ctx) {
        _, err := AuthorizeOrgAndRole(ctx, org, blacklistedCerts, forwarderRoles...)
        if err != nil {
            return "", status.Errorf(codes.PermissionDenied, "Permission denied: unauthorized forwarder role: %v", err)
                                Severity: Major
                                Found in ca/auth.go - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if assignments.addOrUpdateTask(readTx, v.Task) {
                            oneModification()
                        }
                                  Severity: Major
                                  Found in manager/dispatcher/dispatcher.go - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            if assignments.removeTask(readTx, v.Task) {
                            oneModification()
                        }
                                    Severity: Major
                                    Found in manager/dispatcher/dispatcher.go - About 45 mins to fix

                                      Method Scheduler.scheduleNTasksOnSubtree has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                      func (s *Scheduler) scheduleNTasksOnSubtree(ctx context.Context, n int, taskGroup map[string]*api.Task, tree *decisionTree, schedulingDecisions map[string]schedulingDecision, nodeLess func(a *NodeInfo, b *NodeInfo) bool) int {
                                      Severity: Minor
                                      Found in manager/scheduler/scheduler.go - About 45 mins to fix

                                        Function newRootRotationObject has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                        func newRootRotationObject(ctx context.Context, securityConfig *ca.SecurityConfig, apiRootCA *api.RootCA, newCARootCA ca.RootCA, extCAs []*api.ExternalCA, version uint64) (*api.RootCA, error) {
                                        Severity: Minor
                                        Found in manager/controlapi/ca_rotation.go - About 45 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language