Sign upLogin

egordorichev/LastTry

View on GitHub
Star

Showing 205 of 205 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            } else if (!this.isStepping) {
                // Prevent wall clipping with high speeds
                float distToCollision = Globals.getWorld().distToHorizontalCollision(originalHitbox, this.velocity.x);
                if (Math.abs(distToCollision) < Math.abs(this.velocity.x)) {
                    this.velocity.x = distToCollision;
Severity: Minor
Found in core/src/org/egordorichev/lasttry/entity/components/PhysicsComponent.java and 1 other location - About 45 mins to fix
core/src/org/egordorichev/lasttry/entity/components/PhysicsComponent.java on lines 248..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method runCommand has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean runCommand(String handle, String[] args) {
        if (!hasCommand(handle)) {
            Globals.chat.print("Unknown command");
            return false;
        }
Severity: Minor
Found in core/src/org/egordorichev/lasttry/ui/chat/command/CommandHandler.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void run(WorldGenerator generator) {
        logger.info("Generating heightmap");
        int width = generator.getWorldWidth();
        int height = generator.getWorldHeight();
Severity: Minor
Found in core/src/org/egordorichev/lasttry/world/generator/SurfaceGenerationSimplexTask.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public void render(float x, float y, float width, float height, boolean horizontalFlip,
                       boolean verticalFlip) {
Severity: Minor
Found in core/src/org/egordorichev/lasttry/graphics/Animation.java - About 45 mins to fix

    Method delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static void delete(File file) {
        if (file.exists()) {
            if (file.isDirectory()) {
                for (File child : file.listFiles()) {
                    delete(child);
    Severity: Minor
    Found in core/src/org/egordorichev/lasttry/util/Util.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if (wall != null) {
                            wall.renderWall(x, y);
                        }
    Severity: Major
    Found in core/src/org/egordorichev/lasttry/world/components/WorldChunksComponent.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (count == 1) {
                            slots[activeSlot].setItemHolder(new ItemHolder(null, 0));
                        } else {
                            holder.setCount(count - 1);
                        }
      Severity: Major
      Found in core/src/org/egordorichev/lasttry/ui/UiInventory.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (dist <= sampleRadius - 0.125f) {
                            strength = (float) Math.pow(10000, 1.75f / dist);
                        }
        Severity: Major
        Found in core/src/org/egordorichev/lasttry/world/components/WorldLightingComponent.java - About 45 mins to fix

          Method loadMod has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private void loadMod(File file) {
        try (JarFile jarFile = new JarFile(file)) {
            URL[] urls = new URL[] { new URL("jar:file:" + file.getAbsolutePath() + "!/") };

            URLClassLoader urlClassLoader = URLClassLoader.newInstance(urls);
          Severity: Minor
          Found in core/src/org/egordorichev/lasttry/mod/ModLoader.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public void update(CreatureWithAI creature, int dt, int currentAi) {
        if (currentAi == 0) {
            if (creature.physics.getVelocity().y == 0) {
                creature.physics.jump();
          Severity: Minor
          Found in core/src/org/egordorichev/lasttry/entity/ai/ais/SlimeAI.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getFirstFreeSlot has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public UiItemSlot getFirstFreeSlot(UiItemSlot.Type type) {
        switch (type) {
        case ACCESSORY:
            return this.getFirstFreeSlot(68, 73);
          Severity: Minor
          Found in core/src/org/egordorichev/lasttry/ui/UiInventory.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method canBeUsed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public boolean canBeUsed(short x, short y) {
        if (!super.canBeUsed(x, y)) {
            return false;
        }
          Severity: Minor
          Found in core/src/org/egordorichev/lasttry/item/block/MultiTileBlock.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method noise has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public static double noise(double xin, double yin) {
        double n0, n1, n2; // Noise contributions from the three corners
        // Skew the input space to determine which simplex cell we're in
        final double F2 = 0.5 * (Math.sqrt(3.0) - 1.0);
        double s = (xin + yin) * F2; // Hairy factor for 2D
          Severity: Minor
          Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if (this.velocity.y != -0.4f) {
                            this.onGroundHit.call();
                        }
          Severity: Major
          Found in core/src/org/egordorichev/lasttry/entity/components/PhysicsComponent.java - About 45 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (t2 < 0) n2 = 0.0;
        else {
            t2 *= t2;
            n2 = t2 * t2 * dot(grad3[gi2], x2, y2);
        }
            Severity: Major
            Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java and 2 other locations - About 40 mins to fix
            core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 122..127
            core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 129..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (t1 < 0) n1 = 0.0;
        else {
            t1 *= t1;
            n1 = t1 * t1 * dot(grad3[gi1], x1, y1);
        }
            Severity: Major
            Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java and 2 other locations - About 40 mins to fix
            core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 122..127
            core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 135..139

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (t0 < 0) n0 = 0.0;
        else {
            t0 *= t0;
            n0 = t0 * t0 * dot(grad3[gi0], x0, y0); // (x,y) of grad3 used for
                                                    // 2D gradient
            Severity: Major
            Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java and 2 other locations - About 40 mins to fix
            core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 129..133
            core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 135..139

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @Override
    protected void loadFields(JsonValue root) {
        super.loadFields(root);

        this.slot = Slot.valueOf(root.getString("slot", "body").toUpperCase());
            Severity: Minor
            Found in core/src/org/egordorichev/lasttry/item/items/Armor.java and 1 other location - About 40 mins to fix
            core/src/org/egordorichev/lasttry/item/items/Ammo.java on lines 20..26

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @Override
    protected void loadFields(JsonValue root) {
        super.loadFields(root);

        this.type = Type.valueOf(root.getString("type", "bullet").toUpperCase());
            Severity: Minor
            Found in core/src/org/egordorichev/lasttry/item/items/Ammo.java and 1 other location - About 40 mins to fix
            core/src/org/egordorichev/lasttry/item/items/Armor.java on lines 20..26

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    this.commands.register(new Command("day", "Sets the time to day", CMDCategory.ADMININSTRATION) {
            @Override
            public void onRun(String[] args) {
                Globals.environment.time.setHour((byte) 4);
                Globals.environment.time.setMinute((byte) 30);
            Severity: Minor
            Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java and 1 other location - About 40 mins to fix
            core/src/org/egordorichev/lasttry/ui/chat/UiChat.java on lines 159..165

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language