Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 440 of 440 total issues

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractDetail' in method 'handle'.
Open

        $contract = ContractDetail::find($this->contract_id);
Severity: Minor
Found in src/Jobs/Contracts/Character/Items.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractItem' in method 'handle'.
Open

                    ContractItem::updateOrCreate([
                        'record_id' => $item->record_id,
                    ], [
                        'contract_id' => $this->contract_id,
                        'type_id' => $item->type_id,
Severity: Minor
Found in src/Jobs/Contracts/Character/Items.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method handle() has an NPath complexity of 320. The configured NPath complexity threshold is 200.
Open

    public function handle()
    {
        $response = $this->retrieve([
            'killmail_id' => $this->killmail_id,
            'killmail_hash' => $this->killmail_hash,
Severity: Minor
Found in src/Jobs/Killmails/Detail.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using static access to class '\Seat\Eveapi\Jobs\Contracts\Character\Bids' in method 'enqueueDetailedCharacterContractsJobs'.
Open

                        CharacterBids::dispatch($token, $contract->contract_id);
Severity: Minor
Found in src/Commands/Esi/Update/Contracts.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Mail\MailMailingList' in method 'handle'.
Open

            MailMailingList::firstOrCreate([
                'character_id' => $this->getCharacterId(),
                'mailing_list_id' => $list->mailing_list_id,
            ], [
                'name' => $list->name,
Severity: Minor
Found in src/Jobs/Mail/MailingLists.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Sovereignty\Structures' in method 'handle'.
Open

        Structures::dispatch();
Severity: Minor
Found in src/Commands/Esi/Update/Sovereignty.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Tests\Eveapi\Database\Factories\CharacterInfoFactory' in method 'newFactory'.
Open

        return CharacterInfoFactory::new();
Severity: Minor
Found in src/Models/Character/CharacterInfo.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
Open

                File::makeDirectory($storage, 0755, true);
Severity: Minor
Found in src/Commands/Eve/Update/Sde.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Contracts\Character\Items' in method 'enqueueDetailedCharacterContractsJobs'.
Open

                        CharacterItems::dispatch($token, $contract->contract_id);
Severity: Minor
Found in src/Commands/Esi/Update/Contracts.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Redis' in method 'check_redis'.
Open

            Redis::set($test_key, $test_value);
Severity: Minor
Found in src/Commands/Seat/Admin/Diagnose.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Fittings\Insurances' in method 'handle'.
Open

        InsurancesJob::dispatch();
Severity: Minor
Found in src/Commands/Esi/Update/Insurances.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'importPgSqlSde'.
Open

        DB::statement('GRANT yaml TO seat');
Severity: Minor
Found in src/Commands/Eve/Update/Sde.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'createTable'.
Open

        Schema::dropIfExists($this->getSdeName());
Severity: Minor
Found in src/database/seeders/Sde/AbstractSdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Str' in method 'getSdeName'.
Open

        return Str::camel($filename);
Severity: Minor
Found in src/database/seeders/Sde/AbstractSdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
Open

            if (! File::exists($storage))
Severity: Minor
Found in src/database/seeders/Sde/SdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\File' in method 'isStorageOk'.
Open

                File::makeDirectory($storage, 0755, true);
Severity: Minor
Found in src/database/seeders/Sde/SdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'getBucketThreshold'.
Open

        $tokens = RefreshToken::count();
Severity: Minor
Found in src/Traits/BucketManager.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method handle() has 162 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function handle()
    {
        $response = $this->retrieve([
            'character_id' => $this->getCharacterId(),
            'planet_id' => $this->planet_id,
Severity: Minor
Found in src/Jobs/PlanetaryInteraction/Character/PlanetDetail.php by phpmd

The method handlePublicCharacterJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $job::dispatch($this->option('character_id'));
        }
Severity: Minor
Found in src/Commands/Esi/Job/Dispatch.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method handlePrivateCorporationJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $job::dispatch($this->option('corporation_id'), $refresh_token);
        }
Severity: Minor
Found in src/Commands/Esi/Job/Dispatch.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language