Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 440 of 440 total issues

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationTitleRole' in method 'handle'.
Open

                    CorporationTitleRole::firstOrCreate([
                        'title_id' => $title_model->id,
                        'type' => $type,
                        'role' => $name,
                    ]);
Severity: Minor
Found in src/Jobs/Corporation/Titles.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Log' in method '__construct'.
Open

        $config->logger = Log::channel('eseye');
Severity: Minor
Found in src/Services/EseyeClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Cache' in method 'handle'.
Open

        Cache::forever('buckets:processed', $bucket->id);
Severity: Minor
Found in src/Commands/Seat/Buckets/Update.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'handle'.
Open

                Price::upsert($types->toArray(),
                    [
                        'type_id',
                        'sell_price',
                    ]
Severity: Minor
Found in src/Jobs/Market/OrderAggregates.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\MarketOrder' in method 'handle'.
Open

                MarketOrder::upsert($records->toArray(), [
                    'order_id',
                ], [
                    'duration',
                    'is_buy_order',
Severity: Minor
Found in src/Jobs/Market/Orders.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Assets\CharacterAsset' in method 'handle'.
Open

                $model = CharacterAsset::firstOrNew([
                    'item_id' => $asset->item_id,
                ]);
Severity: Minor
Found in src/Jobs/Assets/Character/Assets.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Wallet\CorporationWalletTransaction' in method 'handle'.
Open

                        $transaction_entry = CorporationWalletTransaction::firstOrNew([
                            'corporation_id' => $this->getCorporationId(),
                            'division' => $balance->division,
                            'transaction_id' => $transaction->transaction_id,
                        ]);
Severity: Minor
Found in src/Jobs/Wallet/Corporation/Transactions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Alliances\Alliances' in method 'handle'.
Open

        AlliancesJob::dispatch();
Severity: Minor
Found in src/Commands/Esi/Update/Alliances.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Cache' in method 'handle'.
Open

        $active = Cache::get('buckets:processed', 0);
Severity: Minor
Found in src/Commands/Seat/Buckets/ListCommand.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Industry\CharacterIndustryJob' in method 'handle'.
Open

            $model = CharacterIndustryJob::firstOrNew([
                'character_id' => $this->getCharacterId(),
                'job_id' => $job->job_id,
            ]);
Severity: Minor
Found in src/Jobs/Industry/Character/Jobs.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Mail\MailLabel' in method 'handle'.
Open

            MailLabel::firstOrCreate([
                'character_id' => $this->getCharacterId(),
                'label_id' => $label->label_id,
            ]);
Severity: Minor
Found in src/Jobs/Mail/Labels.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Alliances\Alliance' in method 'created'.
Open

        if (! empty($affiliation->alliance_id) && ! Alliance::find($affiliation->alliance_id))
Severity: Minor
Found in src/Observers/CharacterAffiliationObserver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Mail\MailRecipient' in method 'handle'.
Open

                MailRecipient::firstOrCreate([
                    'mail_id' => $header->mail_id,
                    'recipient_id' => $recipient->recipient_id,
                    'recipient_type' => $recipient->recipient_type,
                ]);
Severity: Minor
Found in src/Jobs/Mail/Mails.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'addObservers'.
Open

        RefreshToken::observe(\Seat\Eveapi\Observers\RefreshTokenObserver::class);
Severity: Minor
Found in src/EveapiServiceProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'seedBuckets'.
Open

        $required_buckets = ceil(RefreshToken::count() / $threshold);
Severity: Minor
Found in src/Traits/BucketManager.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Character\Affiliation' in method 'handle'.
Open

                Affiliation::dispatch($character_ids);
Severity: Minor
Found in src/Commands/Esi/Update/Affiliations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getIncrementing()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getIncrementing()
    {

        return false;
    }
Severity: Minor
Found in src/Traits/HasCompositePrimaryKey.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'cleanup_tables'.
Open

        DB::statement('OPTIMIZE TABLE failed_jobs, server_status, esi_status');
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterRole' in method 'handle'.
Open

                CharacterRole::firstOrCreate([
                    'character_id' => $this->getCharacterId(),
                    'role' => $role,
                    'scope' => $scope,
                ]);
Severity: Minor
Found in src/Jobs/Character/Roles.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\CorporationOrder' in method 'handle'.
Open

                $model = CorporationOrder::firstOrNew([
                    'corporation_id' => $this->getCorporationId(),
                    'order_id' => $order->order_id,
                ]);
Severity: Minor
Found in src/Jobs/Market/Corporation/Orders.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language