Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 440 of 440 total issues

Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailVictim' in method 'handle'.
Open

        $victim = KillmailVictim::firstOrNew([
            'killmail_id' => $this->killmail_id,
        ]);
Severity: Minor
Found in src/Jobs/Killmails/Detail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'handle'.
Open

                    Price::updateOrCreate([
                        'type_id' => $type_id,
                    ], [
                        'average' => $price->average,
                        'highest' => $price->highest,
Severity: Minor
Found in src/Jobs/Market/History.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Tests\Eveapi\Database\Factories\CharacterRoleFactory' in method 'newFactory'.
Open

        return CharacterRoleFactory::new();
Severity: Minor
Found in src/Models/Character/CharacterRole.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Contracts\Character\Contracts' in method 'enqueueContractsListJobs'.
Open

                CharacterContracts::dispatch($token);
Severity: Minor
Found in src/Commands/Esi/Update/Contracts.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'createTable'.
Open

        Schema::create($this->getSdeName(), function (Blueprint $table) {
            $this->getSdeTableDefinition($table);
        });
Severity: Minor
Found in src/database/seeders/Sde/AbstractSdeSeeder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseStructure' in method 'handle'.
Open

            $model = UniverseStructure::firstOrNew([
                'structure_id' => $this->structure_id,
            ]);
Severity: Minor
Found in src/Jobs/Universe/Structures/Citadel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseStation' in method 'submitJobs'.
Open

            return UniverseStation::find($station_id) === null && ! $this->isCurrentlyProcessing($station_id); // stations don't need a character
Severity: Minor
Found in src/Jobs/Universe/Structures/StructureBatch.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Cache' in method '__construct'.
Open

        $config->cache = Cache::store('eseye');
Severity: Minor
Found in src/Services/EseyeClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Universe\UniverseStructure' in method 'submitJobs'.
Open

                    UniverseStructure::find($citadel_id) === null                               // we don't already know it
Severity: Minor
Found in src/Jobs/Universe/Structures/StructureBatch.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterInfo' in method 'fire'.
Open

        $character = CharacterInfo::firstOrNew(
            ['character_id' => $this->character_id],
            ['name' => "Unknown Character : {$this->character_id}"]
        );
Severity: Minor
Found in src/Bus/Character.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Composer\InstalledVersions' in method '__construct'.
Open

            $version = sprintf('v%s', InstalledVersions::getPrettyVersion('eveseat/eveapi'));
Severity: Minor
Found in src/Services/EseyeClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\FailedJob' in method 'cleanup_tables'.
Open

        FailedJob::where('id', '<', FailedJob::max('id') - 100)->delete();
Severity: Minor
Found in src/Jobs/Maintenance.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'handlePrivateCorporationJobs'.
Open

        $refresh_token = RefreshToken::findOrFail($this->option('character_id'));
Severity: Minor
Found in src/Commands/Esi/Job/Dispatch.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Services\Settings\Seat' in method 'handle'.
Open

        Seat::set('installed_sde', $this->json->version);
Severity: Minor
Found in src/Commands/Eve/Update/Sde.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Jobs\Character\Affiliation' in method 'handle'.
Open

                Affiliation::dispatch($character_ids);
Severity: Minor
Found in src/Commands/Esi/Update/Affiliations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterCorporationHistory' in method 'handle'.
Open

            CharacterCorporationHistory::firstOrCreate([
                'character_id' => $this->getCharacterId(),
                'record_id' => $corporation->record_id,
            ], [
                'start_date' => carbon($corporation->start_date),
Severity: Minor
Found in src/Jobs/Character/CorporationHistory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractDetail' in method 'handle'.
Open

        $contract = ContractDetail::find($this->contract_id);
Severity: Minor
Found in src/Jobs/Contracts/Corporation/Bids.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\DB' in method 'importPgSqlSde'.
Open

        DB::statement('CREATE ROLE yaml WITH NOLOGIN NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT NOREPLICATION CONNECTION LIMIT -1');
Severity: Minor
Found in src/Commands/Eve/Update/Sde.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationMemberTitle' in method 'handle'.
Open

                CorporationMemberTitle::firstOrCreate([
                    'corporation_id' => $this->getCorporationId(),
                    'character_id' => $member->character_id,
                    'title_id' => $title,
                ]);
Severity: Minor
Found in src/Jobs/Corporation/MembersTitles.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Redis' in method 'check_redis'.
Open

            Redis::expire($test_key, 10);
Severity: Minor
Found in src/Commands/Seat/Admin/Diagnose.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language