iterative/dvc

View on GitHub

Showing 104 of 225 total issues

Function show has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def show(
Severity: Major
Found in dvc/repo/metrics/show.py - About 50 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    class DependencyDoesNotExistError(DvcException):
        def __init__(self, path):
            msg = "dependency '{}' does not exist".format(path)
            super(DependencyDoesNotExistError, self).__init__(msg)
    Severity: Major
    Found in dvc/dependency/base.py and 5 other locations - About 50 mins to fix
    dvc/dependency/base.py on lines 12..15
    dvc/output/base.py on lines 11..14
    dvc/output/base.py on lines 17..20
    dvc/output/base.py on lines 23..26
    dvc/stage.py on lines 43..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    class OutputDoesNotExistError(DvcException):
        def __init__(self, path):
            msg = "output '{}' does not exist".format(path)
            super(OutputDoesNotExistError, self).__init__(msg)
    Severity: Major
    Found in dvc/output/base.py and 5 other locations - About 50 mins to fix
    dvc/dependency/base.py on lines 6..9
    dvc/dependency/base.py on lines 12..15
    dvc/output/base.py on lines 17..20
    dvc/output/base.py on lines 23..26
    dvc/stage.py on lines 43..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    class OutputAlreadyTrackedError(DvcException):
        def __init__(self, path):
            msg = "output '{}' is already tracked by scm (e.g. git)".format(path)
            super(OutputAlreadyTrackedError, self).__init__(msg)
    Severity: Major
    Found in dvc/output/base.py and 5 other locations - About 50 mins to fix
    dvc/dependency/base.py on lines 6..9
    dvc/dependency/base.py on lines 12..15
    dvc/output/base.py on lines 11..14
    dvc/output/base.py on lines 17..20
    dvc/stage.py on lines 43..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    class DependencyIsNotFileOrDirError(DvcException):
        def __init__(self, path):
            msg = "dependency '{}' is not a file or directory".format(path)
            super(DependencyIsNotFileOrDirError, self).__init__(msg)
    Severity: Major
    Found in dvc/dependency/base.py and 5 other locations - About 50 mins to fix
    dvc/dependency/base.py on lines 6..9
    dvc/output/base.py on lines 11..14
    dvc/output/base.py on lines 17..20
    dvc/output/base.py on lines 23..26
    dvc/stage.py on lines 43..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    class OutputIsNotFileOrDirError(DvcException):
        def __init__(self, path):
            msg = "output '{}' is not a file or directory".format(path)
            super(OutputIsNotFileOrDirError, self).__init__(msg)
    Severity: Major
    Found in dvc/output/base.py and 5 other locations - About 50 mins to fix
    dvc/dependency/base.py on lines 6..9
    dvc/dependency/base.py on lines 12..15
    dvc/output/base.py on lines 11..14
    dvc/output/base.py on lines 23..26
    dvc/stage.py on lines 43..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                logger.debug(
                    "Uploading '{}' to '{}/{}'".format(
                        from_info["path"], to_info["bucket"], to_info["path"]
    Severity: Minor
    Found in dvc/remote/gs.py and 1 other location - About 45 mins to fix
    dvc/remote/s3.py on lines 167..169

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function __init__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def __init__(self, repo, config):
            super(RemoteLOCAL, self).__init__(repo, config)
            self.state = self.repo.state if self.repo else None
            self.protected = config.get(Config.SECTION_CACHE_PROTECTED, False)
            storagepath = config.get(Config.SECTION_AWS_STORAGEPATH, None)
    Severity: Minor
    Found in dvc/remote/local.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function brancher has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def brancher(  # noqa: E302
    Severity: Minor
    Found in dvc/repo/brancher.py - About 45 mins to fix

      Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def run(self, unlock=False):
              if not self.args.targets:
                  self.args.targets = self.default_targets
      
              for target in self.args.targets:
      Severity: Minor
      Found in dvc/command/pipeline.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Minor
      Found in dvc/output/local.py - About 45 mins to fix

        Function _reproduce_stage has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _reproduce_stage(stages, node, force, dry, interactive, no_commit):
        Severity: Minor
        Found in dvc/repo/reproduce.py - About 45 mins to fix

          Function _group has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def _group(self, checksum_infos, show_checksums=False):
                  by_md5 = {}
          
                  for info in checksum_infos:
                      md5 = info[self.PARAM_CHECKSUM]
          Severity: Minor
          Found in dvc/remote/local.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function draw has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def draw(vertexes, edges):
              """Build a DAG and draw it in ASCII.
          
              Args:
                  vertexes (list): list of graph vertexes.
          Severity: Minor
          Found in dvc/dagascii.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _collect_metrics has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _collect_metrics(self, path, recursive, typ, xpath, branch):
          Severity: Minor
          Found in dvc/repo/metrics/show.py - About 45 mins to fix

            Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(
            Severity: Minor
            Found in dvc/output/ssh.py - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          logger.debug(
                              "Uploading '{}' to '{}/{}'".format(
                                  from_info["path"], to_info["bucket"], to_info["path"]
              Severity: Minor
              Found in dvc/remote/s3.py and 1 other location - About 45 mins to fix
              dvc/remote/gs.py on lines 132..134

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function _show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _show(self, target, commands, outs):
                      import networkx
                      from dvc.stage import Stage
              
                      stage = Stage.load(self.repo, target)
              Severity: Minor
              Found in dvc/command/pipeline.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function brancher has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def brancher(  # noqa: E302
                  self, branches=None, all_branches=False, tags=None, all_tags=False
              ):
                  """Generator that iterates over specified revisions.
              
              
              Severity: Minor
              Found in dvc/repo/brancher.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(
              Severity: Minor
              Found in dvc/output/s3.py - About 45 mins to fix
                Severity
                Category
                Status
                Source
                Language