Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

The method I_can_find_out_if_is_dart is not named in camelCase.
Open

    abstract public function I_can_find_out_if_is_dart();
Severity: Minor
Found in tests/Codes/Armaments/ProjectileCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_all_codes_at_once_or_by_same_named_constant is not named in camelCase.
Open

    public function I_can_get_all_codes_at_once_or_by_same_named_constant()
    {
        self::assertSame(
            $expectedValues = [
                // unarmed
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_derived_property_codes is not named in camelCase.
Open

    public function I_can_get_derived_property_codes()
    {
        self::assertEquals(
            [
                'beauty',
Severity: Minor
Found in tests/Codes/Properties/PropertyCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Every_theurgist_code_comes_from_abstract_theurgist_code is not named in camelCase.
Open

    public function Every_theurgist_code_comes_from_abstract_theurgist_code()
    {
        foreach ($this->getCodeClasses(DemonCode::class) as $theurgistCodeClass) {
            self::assertTrue(
                is_a($theurgistCodeClass, AbstractTheurgistCode::class, true),
Severity: Minor
Found in tests/Codes/Theurgist/AllTheurgistCodesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_is_helm_or_body_armor is not named in camelCase.
Open

    abstract public function I_can_ask_it_if_is_helm_or_body_armor();
Severity: Minor
Found in tests/Codes/Armaments/ArmorCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_melee is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_melee()
    {
        /** @var MeleeWeaponCode $sut */
        $sut = $this->getSut();
        self::assertTrue($sut->isMelee());
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_axe_codes is not named in camelCase.
Open

    public function I_can_get_axe_codes()
    {
        self::assertSame(
            [
                'light_axe',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_voulges_and_trident_codes is not named in camelCase.
Open

    public function I_can_get_voulges_and_trident_codes()
    {
        self::assertSame(
            [
                'pitchfork',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_code_if_is_specific_weapon_type is not named in camelCase.
Open

    public function I_can_ask_code_if_is_specific_weapon_type()
    {
        $questions = [
            'isAxe', 'isKnifeOrDagger', 'isMaceOrClub', 'isMorningstarOrMorgenstern', 'isSaberOrBowieKnife',
            'isStaffOrSpear', 'isSword', 'isVoulgeOrTrident', 'isUnarmed',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_from_melee_code_negative_answer_to_most_range_question is not named in camelCase.
Open

    public function I_get_from_melee_code_negative_answer_to_most_range_question()
    {
        foreach (MeleeWeaponCode::getPossibleValues() as $meleeWeaponCode) {
            $meleeWeaponCode = MeleeWeaponCode::getIt($meleeWeaponCode);
            self::assertTrue($meleeWeaponCode->isMelee());
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_dart is not named in camelCase.
Open

    public function I_can_find_out_if_is_dart()
    {
        self::assertTrue(DartCode::getIt(DartCode::SILVER_DART)->isDart());
    }
Severity: Minor
Found in tests/Codes/Armaments/DartCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_sling_stone is not named in camelCase.
Open

    public function I_can_find_out_if_is_sling_stone()
    {
        self::assertFalse(DartCode::getIt(DartCode::WAR_DART)->isSlingStone());
    }
Severity: Minor
Found in tests/Codes/Armaments/DartCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_protective_armament is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_protective_armament();
Severity: Minor
Found in tests/Codes/Armaments/ProtectiveArmamentCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_arrow is not named in camelCase.
Open

    public function I_can_find_out_if_is_arrow()
    {
        self::assertFalse(DartCode::getIt(DartCode::HOLLOW_DART)->isArrow());
    }
Severity: Minor
Found in tests/Codes/Armaments/DartCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_convert_spear_to_melee_weapon_code is not named in camelCase.
Open

    public function I_can_convert_spear_to_melee_weapon_code()
    {
        $rangeSpear = RangedWeaponCode::getIt(RangedWeaponCode::SPEAR);
        self::assertInstanceOf(RangedWeaponCode::class, $rangeSpear);
        self::assertSame($rangeSpear, $rangeSpear->convertToRangedWeaponCodeEquivalent());
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_its_czech_translation is not named in camelCase.
Open

    public function I_can_get_its_czech_translation()
    {
        foreach ($this->getTranslatableCodeClasses() as $codeClass) {
            $hasSinglesOnly = $this->hasSinglesOnly($codeClass);
            $hasMultiplesOnly = $this->hasMultiplesOnly($codeClass);
Severity: Minor
Found in tests/Codes/AllTranslatableCodesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_protective_armament is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_protective_armament()
    {
        /** @var ArmorCode $sut */
        $sut = $this->getSut();
        self::assertTrue($sut->isProtectiveArmament());
Severity: Minor
Found in tests/Codes/Armaments/ArmorCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_dart is not named in camelCase.
Open

    public function I_can_find_out_if_is_dart()
    {
        self::assertFalse(ArrowCode::getIt(ArrowCode::INCENDIARY_ARROW)->isDart());
    }
Severity: Minor
Found in tests/Codes/Armaments/ArrowCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_is_helm_or_body_armor is not named in camelCase.
Open

    public function I_can_ask_it_if_is_helm_or_body_armor()
    {
        $bodyArmorCode = BodyArmorCode::getIt(BodyArmorCode::FULL_PLATE_ARMOR);
        self::assertFalse($bodyArmorCode->isHelm());
        self::assertTrue($bodyArmorCode->isBodyArmor());
Severity: Minor
Found in tests/Codes/Armaments/BodyArmorCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_code_if_is_specific_weapon_type is not named in camelCase.
Open

    public function I_can_ask_code_if_is_specific_weapon_type()
    {
        $questions = [
            'isBow', 'isCrossbow', 'isThrowingWeapon',
        ];
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language