Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

The method I_can_use_code_object_as_its_string_value is not named in camelCase.
Open

    public function I_can_use_code_object_as_its_string_value()
    {
        if ((new \ReflectionClass(self::getSutClass()))->isAbstract()) {
            self::assertFalse(false, 'Can not create enum from abstract class');
Severity: Minor
Found in tests/Codes/Partials/TranslatableCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_get_sub_race_default_to_an_unknown_race is not named in camelCase.
Open

    public function I_can_not_get_sub_race_default_to_an_unknown_race()
    {
        $this->expectException(\DrdPlus\Codes\Exceptions\UnknownRaceCode::class);
        $this->expectExceptionMessageMatches('~rat-at-toullie~');
        $defaultOrcSubRace = SubRaceCode::getDefaultSubRaceFor($this->createRaceCode('rat-at-toullie'));
Severity: Minor
Found in tests/Codes/SubRaceCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_warning_for_unknown_locale is not named in camelCase.
Open

    public function I_get_warning_for_unknown_locale()
    {
        /** @var AbstractTheurgistCode $sutClass */
        $sutClass = self::getSutClass();
        foreach ($sutClass::getPossibleValues() as $value) {
Severity: Minor
Found in tests/Codes/Theurgist/AbstractTheurgistCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Even_armament_code_itself_is_code is not named in camelCase.
Open

    public function Even_armament_code_itself_is_code()
    {
        self::assertTrue(is_a(ArmamentCode::class, Code::class, true));
    }
Severity: Minor
Found in tests/Codes/Armaments/ArmamentCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_melee_weapon_code is not named in camelCase.
Open

    public function It_is_melee_weapon_code()
    {
        /** @var MeleeWeaponCode $sut */
        $sut = $this->getSut();
        self::assertInstanceOf(MeleeWeaponCode::class, $sut);
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_convert_anything_to_melee_weapon_code is not named in camelCase.
Open

    public function I_can_not_convert_anything_to_melee_weapon_code()
    {
        $this->expectException(\DrdPlus\Codes\Armaments\Exceptions\CanNotBeConvertedToRangeWeaponCode::class);
        $this->expectExceptionMessageMatches('~cudgel~');
        $wantItRange = MeleeWeaponCode::getIt(MeleeWeaponCode::CUDGEL);
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_shield is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_is_shield();
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponlikeCodeTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_sling_stone is not named in camelCase.
Open

    abstract public function I_can_find_out_if_is_sling_stone();
Severity: Minor
Found in tests/Codes/Armaments/ProjectileCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_is_helm_or_body_armor is not named in camelCase.
Open

    public function I_can_ask_it_if_is_helm_or_body_armor()
    {
        $helmCode = HelmCode::getIt(HelmCode::BARREL_HELM);
        self::assertTrue($helmCode->isHelm());
        self::assertFalse($helmCode->isBodyArmor());
Severity: Minor
Found in tests/Codes/Armaments/HelmCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_all_codes_at_once_or_by_same_named_constant is not named in camelCase.
Open

    public function I_can_get_all_codes_at_once_or_by_same_named_constant()
    {
        self::assertSame(
            $expectedValues = [
                // throwing weapons
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_mace_and_club_codes is not named in camelCase.
Open

    public function I_can_get_mace_and_club_codes()
    {
        self::assertSame(
            [
                'cudgel',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_composer_method_to_get_weapons_of_same_category is not named in camelCase.
Open

    public function I_can_easily_composer_method_to_get_weapons_of_same_category()
    {
        foreach (WeaponCategoryCode::getRangedWeaponCategoryValues() as $rangedWeaponCategoryValue) {
            $getRangedWeaponOfCategory = StringTools::assembleGetterForName($rangedWeaponCategoryValue . 'Values');
            self::assertTrue(method_exists(self::getSutClass(), $getRangedWeaponOfCategory));
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_melee is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_melee()
    {
        $rangedWeaponCode = RangedWeaponCode::getIt(RangedWeaponCode::getPossibleValues()[0]);
        self::assertFalse($rangedWeaponCode->isMelee());
    }
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_protective_armament is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_protective_armament()
    {
        $shieldCode = ShieldCode::getIt(ShieldCode::MEDIUM_SHIELD);
        self::assertTrue($shieldCode->isProtectiveArmament());
        self::assertInstanceOf(ProtectiveArmamentCode::class, $shieldCode);
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_arrow is not named in camelCase.
Open

    public function I_can_find_out_if_is_arrow()
    {
        self::assertFalse(SlingStoneCode::getIt(SlingStoneCode::SLING_STONE_HEAVIER)->isArrow());
    }
Severity: Minor
Found in tests/Codes/Armaments/SlingStoneCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_non_string_for_translation_of_custom_code is not named in camelCase.
Open

    public function I_can_not_use_non_string_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidTranslationFormat::class);
        $this->expectExceptionMessageMatches('~NULL~');
        /** like @see \DrdPlus\Codes\Armaments\MeleeWeaponCode::addNewMeleeWeaponCode */
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_it_with_default_value is not named in camelCase.
Open

    public function I_can_get_it_with_default_value()
    {
        $sut = $this->findSut();
        self::assertSame(ConditionsAffectingHealingCode::GOOD_CONDITIONS, $sut->getValue(), 'Expected good conditions as a default value');
    }
Severity: Minor
Found in tests/Codes/Body/ConditionsAffectingHealingCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_for_type is not named in camelCase.
Open

    public function I_can_ask_it_for_type(string $value, bool $isCrush, bool $isStab, bool $isCut)
    {
        $woundTypeCode = PhysicalWoundTypeCode::getIt($value);
        self::assertSame($isCrush, $woundTypeCode->isCrush());
        self::assertSame($isStab, $woundTypeCode->isStab());
Severity: Minor
Found in tests/Codes/Body/PhysicalWoundTypeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_every_type_of_serious_wound_origin is not named in camelCase.
Open

    public function I_can_get_every_type_of_serious_wound_origin(string $seriousWoundOriginName)
    {
        $getWoundOrigin = StringTools::assembleGetterForName($seriousWoundOriginName) . 'WoundOrigin';
        /** @var SeriousWoundOriginCode $seriousWoundOrigin */
        $seriousWoundOrigin = SeriousWoundOriginCode::$getWoundOrigin();
Severity: Minor
Found in tests/Codes/Body/SeriousWoundOriginCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_melee_only_codes is not named in camelCase.
Open

    public function I_can_get_melee_only_codes()
    {
        $expectedMeleeOnly = array_diff(
            array_values((new \ReflectionClass(MeleeCombatActionCode::class))->getConstants()),
            CombatActionCode::getPossibleValues()
Severity: Minor
Found in tests/Codes/CombatActions/MeleeCombatActionCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language