Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

The method Method_to_get_default_values_is_not_public is not named in camelCase.
Open

    public function Method_to_get_default_values_is_not_public()
    {
        $sutClass = self::getSutClass();
        $getDefaultValues = $this->sutReflection->getMethod('getDefaultValues');
        self::assertFalse($getDefaultValues->isPublic(), "Method $sutClass::getDefaultValues is not intended to be public");
Severity: Minor
Found in tests/Codes/Partials/TranslatableExtendableCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_invalid_plural_for_translation_of_custom_code is not named in camelCase.
Open

    public function I_can_not_use_invalid_plural_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\UnknownTranslationPlural::class);
        $this->expectExceptionMessageMatches('~all~');
        /** like @see \DrdPlus\Codes\Armaments\ArrowCode::addNewArrowCode */
Severity: Minor
Found in tests/Codes/Partials/TranslatableExtendableCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_all_codes_at_once_or_by_similarly_named_constant is not named in camelCase.
Open

    public function I_can_get_all_codes_at_once_or_by_similarly_named_constant()
    {
        $reflection = new \ReflectionClass(self::getSutClass());
        $constants = $reflection->getConstants();
        asort($constants);
Severity: Minor
Found in tests/Codes/Theurgist/ProfileCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_code_from_invalid_value_format is not named in camelCase.
Open

    public function I_can_not_create_code_from_invalid_value_format()
    {
        $this->expectException(\Granam\ScalarEnum\Exceptions\WrongValueForScalarEnum::class);
        $this->expectExceptionMessageMatches('~\DateTime~');
        $sutClass = self::getSutClass();
Severity: Minor
Found in tests/Codes/AbstractCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_all_codes_at_once_or_by_same_named_constant is not named in camelCase.
Open

    public function I_can_get_all_codes_at_once_or_by_same_named_constant()
    {
        /** @var AbstractCode $codeClass */
        foreach ($this->getCodeClasses() as $codeClass) {
            $reflection = new \ReflectionClass($codeClass);
Severity: Minor
Found in tests/Codes/AllCodesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knife_and_dagger_codes is not named in camelCase.
Open

    public function I_can_get_knife_and_dagger_codes()
    {
        self::assertSame(
            [
                'knife',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_convert_spear_to_range_weapon_code is not named in camelCase.
Open

    public function I_can_convert_spear_to_range_weapon_code()
    {
        $meleeSpear = MeleeWeaponCode::getIt(MeleeWeaponCode::SPEAR);
        self::assertInstanceOf(MeleeWeaponCode::class, $meleeSpear);
        self::assertSame($meleeSpear, $meleeSpear->convertToMeleeWeaponCodeEquivalent());
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_melee_weaponlike_code is not named in camelCase.
Open

    public function It_is_melee_weaponlike_code()
    {
        $sut = $this->getSut();
        self::assertInstanceOf(MeleeWeaponlikeCode::class, $sut);
    }
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponlikeCodeTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_armor_code is not named in camelCase.
Open

    public function It_is_armor_code()
    {
        /** @var ArmorCode $sut */
        $sut = $this->getSut();
        self::assertInstanceOf(ArmorCode::class, $sut);
Severity: Minor
Found in tests/Codes/Armaments/ArmorCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_weapon_is_unarmed_in_fact is not named in camelCase.
Open

    public function I_can_easily_find_out_if_weapon_is_unarmed_in_fact()
    {
        foreach (MeleeWeaponCode::getPossibleValues() as $meleeWeaponCodeValue) {
            $meleeWeaponCode = MeleeWeaponCode::getIt($meleeWeaponCodeValue);
            self::assertSame(
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_warning_for_unknown_locale is not named in camelCase.
Open

    public function I_get_warning_for_unknown_locale()
    {
        foreach ($this->getTranslatableCodeClasses() as $codeClass) {
            foreach ($codeClass::getPossibleValues() as $value) {
                /** @var TranslatableCode $sut */
Severity: Minor
Found in tests/Codes/AllTranslatableCodesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_armament_code is not named in camelCase.
Open

    public function It_is_armament_code()
    {
        self::assertTrue(is_a(self::getSutClass(), ArmamentCode::class, true));
    }
Severity: Minor
Found in tests/Codes/Armaments/ArmamentCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_arrow is not named in camelCase.
Open

    abstract public function I_can_find_out_if_is_arrow();
Severity: Minor
Found in tests/Codes/Armaments/ProjectileCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_shield is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_shield()
    {
        self::assertFalse(MeleeWeaponCode::getIt(MeleeWeaponCode::CLUB)->isShield());
    }
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_ranged is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_ranged()
    {
        self::assertFalse(MeleeWeaponCode::getIt(MeleeWeaponCode::CUDGEL)->isRanged());
    }
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_staff_and_spear_codes is not named in camelCase.
Open

    public function I_can_get_staff_and_spear_codes()
    {
        self::assertSame(
            [
                'light_spear',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_unarmed_codes is not named in camelCase.
Open

    public function I_can_get_unarmed_codes()
    {
        self::assertSame(
            [
                'hand',
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_melee_weapon is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_is_melee_weapon();
Severity: Minor
Found in tests/Codes/Armaments/MeleeWeaponlikeCodeTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_bow_codes is not named in camelCase.
Open

    public function I_can_get_bow_codes()
    {
        self::assertSame(
            [
                'short_bow',
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_crossbow_codes is not named in camelCase.
Open

    public function I_can_get_crossbow_codes()
    {
        self::assertSame(
            [
                'minicrossbow',
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language