Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

The method I_can_get_malus_to_activities is not named in camelCase.
Open

    public function I_can_get_malus_to_activities()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_intelligence_malus is not named in camelCase.
Open

    public function I_can_get_intelligence_malus()
    {
        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
        self::assertSame(-567, $thirst->getStrengthMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_malus_to_activities is not named in camelCase.
Open

    public function I_can_get_malus_to_activities()
    {
        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
        self::assertSame(0, $thirst->getMalusToActivities());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_will_malus is not named in camelCase.
Open

    public function I_can_get_will_malus()
    {
        $afflictionReflection = new \ReflectionClass(self::getSutClass());
        $afflictionConstructor = $afflictionReflection->getConstructor();
        $afflictionConstructor->setAccessible(true);
Severity: Minor
Found in tests/Health/Afflictions/AfflictionByWoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    abstract public function I_can_get_heal_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(15);
        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/CrackedBonesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_linked_with_health_immediately is not named in camelCase.
Open

    public function It_is_linked_with_health_immediately()
    {

        $health = new Health();
        $hunger = Hunger::createIt($health, $this->createAfflictionSize());
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $health = new Health();
        $hunger = Hunger::createIt($health, $this->createAfflictionSize(7));
        self::assertInstanceOf(Hunger::class, $hunger);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $hunger = Hunger::createIt(new Health(), $this->createAfflictionSize(546));
        self::assertSame(0, $hunger->getHealMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
        self::assertInstanceOf(Thirst::class, $thirst);
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_maximum_of_wounds_per_row is not named in camelCase.
Open

    public function I_can_get_maximum_of_wounds_per_row(): void
    {
        $gridOfWounds = new GridOfWounds($this->createHealth([] /* no wounds*/));
        self::assertSame(123, $gridOfWounds->getWoundsPerRowMaximum($this->createWoundBoundary(123)));
    }
Severity: Minor
Found in tests/Health/GridOfWoundsTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_intelligence_malus is not named in camelCase.
Open

    public function I_can_get_intelligence_malus()
    {
        $afflictionReflection = new \ReflectionClass(self::getSutClass());
        $afflictionConstructor = $afflictionReflection->getConstructor();
        $afflictionConstructor->setAccessible(true);
Severity: Minor
Found in tests/Health/Afflictions/AfflictionByWoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_custom_property is not named in camelCase.
Open

    public function I_can_not_use_custom_property()
    {
        $this->expectException(\DrdPlus\Health\Afflictions\Exceptions\UnknownAfflictionPropertyCode::class);
        $this->expectExceptionMessageMatches('~greedy~');
        AfflictionProperty::getIt('greedy');
Severity: Minor
Found in tests/Health/Afflictions/AfflictionPropertyTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_am_stopped_by_specific_exception_on_invalid_value is not named in camelCase.
Open

    public function I_am_stopped_by_specific_exception_on_invalid_value()
    {
        $this->expectException(\Granam\IntegerEnum\Exceptions\WrongValueForIntegerEnum::class);
        $this->expectExceptionMessageMatches('~Broken heart by fixed dart~');
        AfflictionSize::getIt('Broken heart by fixed dart');
Severity: Minor
Found in tests/Health/Afflictions/AfflictionSizeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_partially_severed_arm is not named in camelCase.
Open

    public function I_can_create_partially_severed_arm()
    {
        $severedArm = SeveredArm::createIt($this->createWound(), $sizeValue = 1);

        self::assertInstanceOf(AfflictionDomain::class, $severedArm->getDomain());
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_number_of_filled_rows is not named in camelCase.
Open

    public function I_can_get_number_of_filled_rows(): void
    {
        $gridOfWounds = new GridOfWounds($this->createHealth($this->createWounds([3, 1])));
        self::assertSame(
            0,
Severity: Minor
Found in tests/Health/GridOfWoundsTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_treatment_boundary_moved_to_reaming_wounds_on_ordinary_heal is not named in camelCase.
Open

    public function I_get_treatment_boundary_moved_to_reaming_wounds_on_ordinary_heal(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        self::assertSame(0, $health->getTreatmentBoundary()->getValue());
        $health->addWound($this->createWoundSize(4), SeriousWoundOriginCode::getMechanicalCutWoundOrigin(), $woundBoundary);
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_treatment_boundary_lowered_by_healed_serious_wound is not named in camelCase.
Open

    public function I_get_treatment_boundary_lowered_by_healed_serious_wound(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        self::assertSame(0, $health->getTreatmentBoundary()->getValue());
        $seriousWound = $health->addWound($this->createWoundSize(7), SeriousWoundOriginCode::getMechanicalCutWoundOrigin(), $woundBoundary);
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_heal_old_serious_wound is not named in camelCase.
Open

    public function I_can_not_heal_old_serious_wound(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\ExpectedFreshWoundToHeal::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $seriousWound = $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_heal_already_treated_serious_wound is not named in camelCase.
Open

    public function I_can_not_heal_already_treated_serious_wound(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\ExpectedFreshWoundToHeal::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $seriousWound = $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language