Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

The method I_can_ask_it_if_has_fresh_wounds is not named in camelCase.
Open

    public function I_can_ask_it_if_has_fresh_wounds(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        self::assertFalse($health->hasFreshWounds());
        $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_be_wounded_both_ordinary_and_seriously is not named in camelCase.
Open

    public function I_can_be_wounded_both_ordinary_and_seriously(): void
    {
        $ordinaryWoundsSize = 0;
        $seriousWoundsSize = 0;
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_be_glared is not named in camelCase.
Open

    public function I_can_be_glared(): void
    {
        $health = new Health();
        self::assertEquals(Glared::createWithoutGlare($health), $health->getGlared());
        $health->inflictByGlare($glare = $this->createGlare());
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_may_have_malus_from_wounds is not named in camelCase.
Open

    public function I_can_easily_find_out_if_may_have_malus_from_wounds(): void
    {
        $health = new Health();
        self::assertFalse($health->mayHaveMalusFromWounds($woundBoundary = $this->createWoundBoundary(10)));
        $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_add_affliction is not named in camelCase.
Open

    public function I_can_add_affliction(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $wound = $health->addWound($this->createWoundSize(5),
            SeriousWoundOriginCode::getMechanicalCrushWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_charisma_malus_from_afflictions is not named in camelCase.
Open

    public function I_can_get_charisma_malus_from_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_treatment_boundary_lowered_by_regenerated_amount is not named in camelCase.
Open

    public function I_get_treatment_boundary_lowered_by_regenerated_amount(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->addWound($this->createWoundSize(3), SeriousWoundOriginCode::getMechanicalCrushWoundOrigin(), $woundBoundary);
        $health->addWound($this->createWoundSize(6), SeriousWoundOriginCode::getMechanicalCutWoundOrigin(), $woundBoundary);
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_heal_fresh_ordinary_wounds_if_roll_on_malus_expected is not named in camelCase.
Open

    public function I_can_not_heal_fresh_ordinary_wounds_if_roll_on_malus_expected(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\NeedsToRollAgainstMalusFromWoundsFirst::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        try {
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_be_ordinary_wounded is not named in camelCase.
Open

    public function I_can_be_ordinary_wounded(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $ordinaryWound = $health->addWound(
            $this->createWoundSize(2),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_be_ordinary_healed is not named in camelCase.
Open

    public function I_can_be_ordinary_healed(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(7));

        $health->addWound($this->createWoundSize(1),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_will_malus_from_afflictions is not named in camelCase.
Open

    public function I_can_get_will_malus_from_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_do_not_have_lowered_treatment_boundary_by_healed_ordinary_wound is not named in camelCase.
Open

    public function I_do_not_have_lowered_treatment_boundary_by_healed_ordinary_wound(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->addWound($this->createWoundSize(3), SeriousWoundOriginCode::getMechanicalCrushWoundOrigin(), $woundBoundary);
        $health->addWound($this->createWoundSize(6), SeriousWoundOriginCode::getMechanicalCutWoundOrigin(), $woundBoundary);
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_roll_on_malus_from_wounds_if_not_needed is not named in camelCase.
Open

    public function I_can_not_roll_on_malus_from_wounds_if_not_needed(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UselessRollAgainstMalus::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->rollAgainstMalusFromWounds($this->createWill(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_heal_serious_wound_if_roll_on_malus_expected is not named in camelCase.
Open

    public function I_can_not_heal_serious_wound_if_roll_on_malus_expected(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\NeedsToRollAgainstMalusFromWoundsFirst::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        try {
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Malus_is_not_increased_on_new_heal_by_worse_roll is not named in camelCase.
Open

    public function Malus_is_not_increased_on_new_heal_by_worse_roll(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        self::assertSame(0, $health->getSignificantMalusFromPains($woundBoundary));
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_should_roll_against_malus_from_wounds_because_of_heal_of_ordinary_wound is not named in camelCase.
Open

    public function I_should_roll_against_malus_from_wounds_because_of_heal_of_ordinary_wound($willValue, $rollValue, $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->addWound($this->createWoundSize(4),
            SeriousWoundOriginCode::getElementalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_all_pains_and_afflictions is not named in camelCase.
Open

    public function I_can_get_all_pains_and_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_add_new_wound_if_roll_on_malus_expected is not named in camelCase.
Open

    public function I_can_not_add_new_wound_if_roll_on_malus_expected(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\NeedsToRollAgainstMalusFromWoundsFirst::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        try {
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_get_malus_from_wounds_if_roll_on_it_expected is not named in camelCase.
Open

    public function I_can_not_get_malus_from_wounds_if_roll_on_it_expected(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\NeedsToRollAgainstMalusFromWoundsFirst::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        try {
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_treatment_boundary_increased_by_serious_wound_immediately is not named in camelCase.
Open

    public function I_get_treatment_boundary_increased_by_serious_wound_immediately(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        self::assertSame(0, $health->getTreatmentBoundary()->getValue());
        $health->addWound($this->createWoundSize(7), SeriousWoundOriginCode::getMechanicalCutWoundOrigin(), $woundBoundary);
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language