moleculer-go/moleculer

View on GitHub

Showing 65 of 65 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    mapTransformer{
        "map[string]int64",
        func(source *interface{}) map[string]interface{} {
            result := make(map[string]interface{}, len((*source).(map[string]int64)))
            for key, value := range (*source).(map[string]int64) {
Severity: Major
Found in payload/mapTransformers.go and 5 other locations - About 1 hr to fix
payload/mapTransformers.go on lines 34..46
payload/mapTransformers.go on lines 47..59
payload/mapTransformers.go on lines 73..85
payload/mapTransformers.go on lines 86..98
payload/mapTransformers.go on lines 99..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (broker *ServiceBroker) Emit(event string, params interface{}, groups ...string) {
    broker.logger.Trace("Broker - Emit() event: ", event, " params: ", params, " groups: ", groups)
    if !broker.IsStarted() {
        panic(errors.New("Broker must be started before emiting events :("))
    }
Severity: Major
Found in broker/broker.go and 1 other location - About 1 hr to fix
broker/broker.go on lines 516..523

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (broker *ServiceBroker) Broadcast(event string, params interface{}, groups ...string) {
    broker.logger.Trace("Broker - Broadcast() event: ", event, " params: ", params, " groups: ", groups)
    if !broker.IsStarted() {
        panic(errors.New("Broker must be started before broadcasting events :("))
    }
Severity: Major
Found in broker/broker.go and 1 other location - About 1 hr to fix
broker/broker.go on lines 507..514

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if item.Kind() == reflect.Map {
            mt := MapTransformer(&value)
            result[i] = mt.AsMap(&value)
        } else if item.Kind() == reflect.Array || item.Kind() == reflect.Slice {
            at := ArrayTransformer(&value)
Severity: Major
Found in payload/arrayTransformers.go and 1 other location - About 1 hr to fix
payload/mapTransformers.go on lines 159..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if item.Kind() == reflect.Map {
            mt := MapTransformer(&value)
            result[key] = mt.AsMap(&value)
        } else if item.Kind() == reflect.Array || item.Kind() == reflect.Slice {
            at := ArrayTransformer(&value)
Severity: Major
Found in payload/mapTransformers.go and 1 other location - About 1 hr to fix
payload/arrayTransformers.go on lines 236..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                if selected := stg.Select(nodes); selected != nil {
                    entry := (*selected).(*EventEntry)
                    result = append(result, entry)
                }
Severity: Major
Found in registry/eventCatalog.go - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

        } else if strings.ToUpper(broker.config.LogLevel) == "FATAL" {
            log.SetLevel(log.FatalLevel)
        } else {
            log.SetLevel(log.InfoLevel)
        }
    Severity: Major
    Found in broker/broker.go - About 45 mins to fix

      Method RawPayload.Get has 7 return statements (exceeds 4 allowed).
      Open

      func (p *RawPayload) Get(s string, defaultValue ...interface{}) moleculer.Payload {
          if _, ok := p.mapGet(s); ok {
              if defaultValue != nil {
                  return p.getKey(s, defaultValue...)
              }
      Severity: Major
      Found in payload/payload.go - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        var mathService = moleculer.ServiceSchema{
            Name: "math",
            Actions: []moleculer.Action{
                {
                    Name: "add",
        Severity: Minor
        Found in examples/standalone/math.service.go and 1 other location - About 45 mins to fix
        examples/amqp_transporter/main.go on lines 17..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        var mathService = moleculer.ServiceSchema{
            Name: "math",
            Actions: []moleculer.Action{
                {
                    Name: "add",
        Severity: Minor
        Found in examples/amqp_transporter/main.go and 1 other location - About 45 mins to fix
        examples/standalone/math.service.go on lines 11..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (eventCatalog *EventCatalog) listByName() map[string][]EventEntry {
            result := make(map[string][]EventEntry)
            eventCatalog.events.Range(func(key, value interface{}) bool {
                result[key.(string)] = value.([]EventEntry)
                return true
        Severity: Minor
        Found in registry/eventCatalog.go and 1 other location - About 40 mins to fix
        registry/actionCatalog.go on lines 105..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (actionCatalog *ActionCatalog) listByName() map[string][]ActionEntry {
            result := make(map[string][]ActionEntry)
            actionCatalog.actions.Range(func(key, value interface{}) bool {
                result[key.(string)] = value.([]ActionEntry)
                return true
        Severity: Minor
        Found in registry/actionCatalog.go and 1 other location - About 40 mins to fix
        registry/eventCatalog.go on lines 79..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method EventCatalog.Find has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (eventCatalog *EventCatalog) Find(name string, groups []string, preferLocal bool, localOnly bool, stg strategy.Strategy) []*EventEntry {
        Severity: Minor
        Found in registry/eventCatalog.go - About 35 mins to fix

          Method AmqpTransporter.subscribeInternal has 5 return statements (exceeds 4 allowed).
          Open

          func (t *AmqpTransporter) subscribeInternal(subscriber subscriber) {
              if t.channel == nil {
                  return
              }
          
          
          Severity: Major
          Found in transit/amqp/amqp.go - About 35 mins to fix

            Function cleanUpForSerialization has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func cleanUpForSerialization(values *map[string]interface{}) *map[string]interface{} {
                result := map[string]interface{}{}
                for key, value := range *values {
                    vType := payload.GetValueType(&value)
                    mTransformer := payload.MapTransformer(&value)
            Severity: Minor
            Found in serializer/jsonSerializer.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func extractStarted(obj interface{}) moleculer.LifecycleFunc {
                starter, hasIt := obj.(HasStarted)
                if hasIt {
                    return starter.Started
                }
            Severity: Minor
            Found in service/service.go and 1 other location - About 35 mins to fix
            service/service.go on lines 797..809

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (payload JSONPayload) Float32Array() []float32 {
                if payload.IsArray() {
                    source := payload.result.Array()
                    array := make([]float32, len(source))
                    for index, item := range source {
            Severity: Minor
            Found in serializer/jsonSerializer.go and 1 other location - About 35 mins to fix
            serializer/jsonSerializer.go on lines 380..390

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (payload JSONPayload) IntArray() []int {
                if payload.IsArray() {
                    source := payload.result.Array()
                    array := make([]int, len(source))
                    for index, item := range source {
            Severity: Minor
            Found in serializer/jsonSerializer.go and 1 other location - About 35 mins to fix
            serializer/jsonSerializer.go on lines 416..426

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func extractStopped(obj interface{}) moleculer.LifecycleFunc {
                stopper, hasIt := obj.(HasStopped)
                if hasIt {
                    return stopper.Stopped
                }
            Severity: Minor
            Found in service/service.go and 1 other location - About 35 mins to fix
            service/service.go on lines 783..795

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            func (payload JSONPayload) FloatArray() []float64 {
                if payload.IsArray() {
                    source := payload.result.Array()
                    array := make([]float64, len(source))
                    for index, item := range source {
            Severity: Major
            Found in serializer/jsonSerializer.go and 4 other locations - About 30 mins to fix
            serializer/jsonSerializer.go on lines 313..323
            serializer/jsonSerializer.go on lines 392..402
            serializer/jsonSerializer.go on lines 404..414
            serializer/jsonSerializer.go on lines 474..484

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language