Sign upLogin

publiclab/image-sequencer

View on GitHub
Star

Showing 267 of 267 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        y +
        Math.floor(
          dimension / 2 -
          Math.abs(height * cos / 2) -
          Math.abs(width * sin / 2)
Severity: Major
Found in src/modules/Rotate/Rotate.js and 1 other location - About 1 hr to fix
src/modules/Rotate/Rotate.js on lines 62..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        x +
        Math.floor(
          dimension / 2 -
          Math.abs(width * cos / 2) -
          Math.abs(height * sin / 2)
Severity: Major
Found in src/modules/Rotate/Rotate.js and 1 other location - About 1 hr to fix
src/modules/Rotate/Rotate.js on lines 68..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function draw has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function draw(input, callback, progressObj) {

    options.width = parseInt(options.width || defaults.width);
    options.height = parseInt(options.height || defaults.height);
    options.x = parseInt(options.x || defaults.x);
Severity: Minor
Found in src/modules/CanvasResize/Module.js - About 1 hr to fix

Function Blur has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Blur(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  options.blur = options.blur || defaults.blur;
  options.blur = parseFloat(options.blur);
Severity: Minor
Found in src/modules/Blur/Module.js - About 1 hr to fix

Function Channel has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Channel(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));

  options.channel = options.channel || defaults.channel;
Severity: Minor
Found in src/modules/Channel/Module.js - About 1 hr to fix

Function draw has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function draw(input, callback) {

    var step = this;

    options.nw = options.nw || defaults.nw;
Severity: Minor
Found in src/modules/WebglDistort/Module.js - About 1 hr to fix

Function Sharpen has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Sharpen(options, UI) {

  let defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  options.sharpenStrength = options.sharpenStrength || defaults.sharpenStrength;
  options.sharpenStrength = parseFloat(options.sharpenStrength); //returns a float
Severity: Minor
Found in src/modules/Sharpen/Module.js - About 1 hr to fix

Function extraManipulation has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function extraManipulation(pixels) {
      const rotate_value = (options.rotate) % 360;
      radians = (Math.PI) * rotate_value / 180,
      width = pixels.shape[0],
      height = pixels.shape[1],
Severity: Minor
Found in src/modules/Rotate/Module.js - About 1 hr to fix

Function stringToJSONstep has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function stringToJSONstep(str) {
    var bracesStrings;
    if (str.includes('{'))
      if (str.includes('(') && str.indexOf('(') < str.indexOf('{'))
        bracesStrings = ['(', ')'];
Severity: Minor
Found in src/Strings.js - About 1 hr to fix

Function loadImages has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function loadImages() {
    var args = [];
    var prevSteps = this.getSteps().slice(1).map(step=>step.options.name);
    var sequencer = this;
    sequencer.image = arguments[0];
Severity: Minor
Found in src/ImageSequencer.js - About 1 hr to fix

Function Ndvi has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function Ndvi(options, UI) {

  if (options.step.inBrowser) var ui = require('./Ui.js')(options.step, UI);

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
Severity: Minor
Found in src/modules/Ndvi/Module.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mapHtmlTypes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

function mapHtmlTypes(inputInfo){
  var htmlType;
  switch(inputInfo.type.toLowerCase()){
  case 'integer':
    htmlType = inputInfo.min != undefined ? 'range' : 'number';
Severity: Minor
Found in examples/lib/mapHtmltypes.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convolve has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const convolve = (arrays, kernel, options = {}) => {
  const pipeMode = options.pipeMode || false,
    mode = options.mode || 'gpu';

  const gpu = new GPU(mode != 'gpu' ? {mode} : {});
Severity: Minor
Found in src/modules/_nomodule/gpuUtils.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Dither has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Dither(options, UI) {
  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  var output;

  function draw(input, callback, progressObj) {
Severity: Minor
Found in src/modules/Dither/Module.js - About 1 hr to fix

Function NoiseReduction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function NoiseReduction(options, UI) {
  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  var output;

  function draw(input, callback, progressObj) {
Severity: Minor
Found in src/modules/NoiseReduction/Module.js - About 1 hr to fix

Function setup has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function setup(setImage, onLoad) {

    // generate a unique timestamp based id for the dropzone
    var dropzoneId = 'dropzone-import-image-' + step.ID;
Severity: Minor
Found in src/modules/ImportImage/Ui.js - About 1 hr to fix

Function Resize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Resize(pixels, options) {
  const resize_value = parseFloat(options.resize);

  if (resize_value == 100) return pixels;
Severity: Minor
Found in src/modules/Resize/Resize.js - About 1 hr to fix

Function Colormap has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Colormap(options, UI) {

  var output;

  // This function is called on every draw.
Severity: Minor
Found in src/modules/Colormap/Module.js - About 1 hr to fix

Function Resize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Resize(options, UI) {

  let output;

  function draw(input, callback, progressObj) {
Severity: Minor
Found in src/modules/Resize/Module.js - About 1 hr to fix

Function createMetaModule has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function createMetaModule(mapFunction, moduleOptions) {

  moduleOptions = moduleOptions || {};
  moduleOptions.infoJson = moduleOptions.infoJson || {};
Severity: Minor
Found in src/util/createMetaModule.js - About 1 hr to fix
Severity
Category
Status
Source
Language