Showing 267 of 267 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
y +
Math.floor(
dimension / 2 -
Math.abs(height * cos / 2) -
Math.abs(width * sin / 2)
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
x +
Math.floor(
dimension / 2 -
Math.abs(width * cos / 2) -
Math.abs(height * sin / 2)
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function Channel
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Channel(options, UI) {
var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
options.channel = options.channel || defaults.channel;
- Create a ticketCreate a ticket
Function draw
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function draw(input, callback) {
var step = this;
options.nw = options.nw || defaults.nw;
- Create a ticketCreate a ticket
Function Blur
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Blur(options, UI) {
var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
options.blur = options.blur || defaults.blur;
options.blur = parseFloat(options.blur);
- Create a ticketCreate a ticket
Function Sharpen
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Sharpen(options, UI) {
let defaults = require('./../../util/getDefaults.js')(require('./info.json'));
options.sharpenStrength = options.sharpenStrength || defaults.sharpenStrength;
options.sharpenStrength = parseFloat(options.sharpenStrength); //returns a float
- Create a ticketCreate a ticket
Function draw
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function draw(input, callback, progressObj) {
options.width = parseInt(options.width || defaults.width);
options.height = parseInt(options.height || defaults.height);
options.x = parseInt(options.x || defaults.x);
- Create a ticketCreate a ticket
Function stringToJSONstep
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function stringToJSONstep(str) {
var bracesStrings;
if (str.includes('{'))
if (str.includes('(') && str.indexOf('(') < str.indexOf('{'))
bracesStrings = ['(', ')'];
- Create a ticketCreate a ticket
Function extraManipulation
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function extraManipulation(pixels) {
const rotate_value = (options.rotate) % 360;
radians = (Math.PI) * rotate_value / 180,
width = pixels.shape[0],
height = pixels.shape[1],
- Create a ticketCreate a ticket
Function loadImages
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function loadImages() {
var args = [];
var prevSteps = this.getSteps().slice(1).map(step=>step.options.name);
var sequencer = this;
sequencer.image = arguments[0];
- Create a ticketCreate a ticket
Function Ndvi
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function Ndvi(options, UI) {
if (options.step.inBrowser) var ui = require('./Ui.js')(options.step, UI);
var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function mapHtmlTypes
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function mapHtmlTypes(inputInfo){
var htmlType;
switch(inputInfo.type.toLowerCase()){
case 'integer':
htmlType = inputInfo.min != undefined ? 'range' : 'number';
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function convolve
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
const convolve = (arrays, kernel, options = {}) => {
const pipeMode = options.pipeMode || false,
mode = options.mode || 'gpu';
const gpu = new GPU(mode != 'gpu' ? {mode} : {});
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Dither
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Dither(options, UI) {
var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
var output;
function draw(input, callback, progressObj) {
- Create a ticketCreate a ticket
Function setup
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function setup(setImage, onLoad) {
// generate a unique timestamp based id for the dropzone
var dropzoneId = 'dropzone-import-image-' + step.ID;
- Create a ticketCreate a ticket
Function NoiseReduction
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function NoiseReduction(options, UI) {
var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
var output;
function draw(input, callback, progressObj) {
- Create a ticketCreate a ticket
Function Colormap
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Colormap(options, UI) {
var output;
// This function is called on every draw.
- Create a ticketCreate a ticket
Function Resize
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Resize(options, UI) {
let output;
function draw(input, callback, progressObj) {
- Create a ticketCreate a ticket
Function Resize
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function Resize(pixels, options) {
const resize_value = parseFloat(options.resize);
if (resize_value == 100) return pixels;
- Create a ticketCreate a ticket
Function createMetaModule
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function createMetaModule(mapFunction, moduleOptions) {
moduleOptions = moduleOptions || {};
moduleOptions.infoJson = moduleOptions.infoJson || {};
- Create a ticketCreate a ticket