Sign upLogin

quyse/flaw

View on GitHub
Star

Showing 292 of 292 total issues

Reduce duplication
Open

      p <- VGM.unsafeRead pairHeap i
Severity: Minor
Found in flaw-visual/Flaw/Visual/Geometry/Simplification.hs by hlint

Found

p <- VGM.unsafeRead pairHeap i
let m = (i - 1) `quot` 2
mp <- VGM.unsafeRead pairHeap m

Perhaps

Combine with flaw-visual/Flaw/Visual/Geometry/Simplification.hs:327:9

Use camelCase
Open

hb_y_advance :: Ptr Hb_glyph_position_t -> Ptr Hb_position_t
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

hb_y_advance :: Ptr Hb_glyph_position_t -> Ptr Hb_position_t

Perhaps

hbYAdvance :: Ptr Hb_glyph_position_t -> Ptr Hb_position_t

Use camelCase
Open

hb_glyph_info_t_size = 20
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

hb_glyph_info_t_size = ...

Perhaps

hbGlyphInfoTSize = ...

Use camelCase
Open

data C_AVStream
Severity: Minor
Found in flaw-ffmpeg/Flaw/Media/FFmpeg.hs by hlint

Found

data C_AVStream

Perhaps

data CAVStream

Redundant bracket
Open

    [ patSynSigD v (forallT [PlainTV a] (sequence [(conT ''Vectorized) `appT` (varT a)]) $ foldr (appT . (appT arrowT) . varT) ((conT v) `appT` (varT a)) (replicate dim a))
Severity: Minor
Found in flaw-math/Flaw/Math.hs by hlint

Found

(conT v) `appT` (varT a)

Perhaps

(conT v) `appT` varT a

Redundant bracket
Open

    [ patSynSigD v (forallT [PlainTV a] (sequence [(conT ''Vectorized) `appT` (varT a)]) $ foldr (appT . (appT arrowT) . varT) ((conT v) `appT` (varT a)) (replicate (dimN * dimM) a))
Severity: Minor
Found in flaw-math/Flaw/Math.hs by hlint

Found

(conT v) `appT` (varT a)

Perhaps

conT v `appT` (varT a)

Redundant $
Open

        , funD 'S.get [clause [] (normalB $ doE $ map (\a -> bindS (varP a) [| S.get |]) as ++ [noBindS $ [| return $(foldl appE (conE conName) $ map varE as) |] ]) []]
Severity: Minor
Found in flaw-math/Flaw/Math.hs by hlint

Found

noBindS $ [| return $( foldl appE (conE conName) $ map varE as ) |]

Perhaps

noBindS [| return $( foldl appE (conE conName) $ map varE as ) |]

Use camelCase
Open

type FN_vkInternalAllocationNotification = Ptr () -> CSize -> VkInternalAllocationType -> VkSystemAllocationScope -> IO ()
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkInternalAllocationNotification =
    Ptr ()
    -> CSize
       -> VkInternalAllocationType -> VkSystemAllocationScope -> IO ()

Perhaps

type FNVkInternalAllocationNotification =
    Ptr ()
    -> CSize
       -> VkInternalAllocationType -> VkSystemAllocationScope -> IO ()

Use camelCase
Open

type FN_vkCreateImage
  =  VkDevice
  -> Ptr VkImageCreateInfo
  -> Ptr VkAllocationCallbacks
  -> Ptr VkImage
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkCreateImage =
    VkDevice
    -> Ptr VkImageCreateInfo
       -> Ptr VkAllocationCallbacks -> Ptr VkImage -> IO Word32

Perhaps

type FNVkCreateImage =
    VkDevice
    -> Ptr VkImageCreateInfo
       -> Ptr VkAllocationCallbacks -> Ptr VkImage -> IO Word32

Use camelCase
Open

type FN_vkDestroyRenderPass
  =  VkDevice
  -> VkRenderPass
  -> Ptr VkAllocationCallbacks
  -> IO ()
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkDestroyRenderPass =
    VkDevice -> VkRenderPass -> Ptr VkAllocationCallbacks -> IO ()

Perhaps

type FNVkDestroyRenderPass =
    VkDevice -> VkRenderPass -> Ptr VkAllocationCallbacks -> IO ()

Use camelCase
Open

type FN_vkCreateShaderModule
  =  VkDevice
  -> Ptr VkShaderModuleCreateInfo
  -> Ptr VkAllocationCallbacks
  -> Ptr VkShaderModule
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkCreateShaderModule =
    VkDevice
    -> Ptr VkShaderModuleCreateInfo
       -> Ptr VkAllocationCallbacks -> Ptr VkShaderModule -> IO Word32

Perhaps

type FNVkCreateShaderModule =
    VkDevice
    -> Ptr VkShaderModuleCreateInfo
       -> Ptr VkAllocationCallbacks -> Ptr VkShaderModule -> IO Word32

Use camelCase
Open

data Hb_glyph_info_t
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

data Hb_glyph_info_t

Perhaps

data HbGlyphInfoT

Use camelCase
Open

hb_x_advance :: Ptr Hb_glyph_position_t -> Ptr Hb_position_t
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

hb_x_advance :: Ptr Hb_glyph_position_t -> Ptr Hb_position_t

Perhaps

hbXAdvance :: Ptr Hb_glyph_position_t -> Ptr Hb_position_t

Reduce duplication
Open

          renderUniformStorage usObject
Severity: Minor
Found in flaw-editor/exe/model-editor.hs by hlint

Found

renderUniformStorage usObject
renderVertexBuffer 0 vbObject
renderIndexBuffer ibObject

Perhaps

Combine with flaw-editor/exe/model-editor.hs:886:11

Use camelCase
Open

type Hb_codepoint_t = Word32
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

type Hb_codepoint_t = Word32

Perhaps

type HbCodepointT = Word32

Use camelCase
Open

data FT_GlyphSlotRec
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/FreeType/FFI.hs by hlint

Found

data FT_GlyphSlotRec

Perhaps

data FTGlyphSlotRec

Use camelCase
Open

type FN_vkEnumeratePhysicalDevices
  =  VkInstance
  -> Ptr Word32
  -> Ptr VkPhysicalDevice
  -> IO Word32 -- VkResult
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkEnumeratePhysicalDevices =
    VkInstance -> Ptr Word32 -> Ptr VkPhysicalDevice -> IO Word32

Perhaps

type FNVkEnumeratePhysicalDevices =
    VkInstance -> Ptr Word32 -> Ptr VkPhysicalDevice -> IO Word32

Use camelCase
Open

type FN_vkGetDeviceProcAddr
  =  VkDevice
  -> Ptr CChar
  -> IO (FunPtr (IO ()))
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkGetDeviceProcAddr =
    VkDevice -> Ptr CChar -> IO (FunPtr (IO ()))

Perhaps

type FNVkGetDeviceProcAddr =
    VkDevice -> Ptr CChar -> IO (FunPtr (IO ()))

Use camelCase
Open

type FN_vkCreateGraphicsPipelines
  =  VkDevice
  -> VkPipelineCache
  -> Word32
  -> Ptr VkGraphicsPipelineCreateInfo
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkCreateGraphicsPipelines =
    VkDevice
    -> VkPipelineCache
       -> Word32
          -> Ptr VkGraphicsPipelineCreateInfo
             -> Ptr VkAllocationCallbacks -> Ptr VkPipeline -> IO Word32

Perhaps

type FNVkCreateGraphicsPipelines =
    VkDevice
    -> VkPipelineCache
       -> Word32
          -> Ptr VkGraphicsPipelineCreateInfo
             -> Ptr VkAllocationCallbacks -> Ptr VkPipeline -> IO Word32

Reduce duplication
Open

    let v = undefined :: VertexPNT
Severity: Minor
Found in flaw-editor/exe/model-editor.hs by hlint

Found

let v = undefined :: VertexPNT
aPosition <- vertexAttribute 0 0 $ vertexPositionAttribute v
aNormal <- vertexAttribute 0 0 $ vertexNormalAttribute v

Perhaps

Combine with flaw-editor/exe/model-editor.hs:398:5
Severity
Category
Status
Source
Language