Sign upLogin

quyse/flaw

View on GitHub
Star

Showing 292 of 292 total issues

Redundant $
Open

  classD (sequence [ [t| $(conT $ mkName $ "Vec" ++ [toUpper c]) $(varT tvV) |] | c <- components])
Severity: Minor
Found in flaw-math/Flaw/Math.hs by hlint

Found

conT $ mkName

Perhaps

conT mkName

Redundant bracket
Open

        unit <- (read . T.unpack) <$> getElementAttr "meter" unitElement
Severity: Minor
Found in flaw-collada/Flaw/Asset/Collada.hs by hlint

Found

(read . T.unpack) <$> getElementAttr "meter" unitElement

Perhaps

read . T.unpack <$> getElementAttr "meter" unitElement

Use camelCase
Open

data C_FFmpegScaler
Severity: Minor
Found in flaw-ffmpeg/Flaw/Media/FFmpeg.hs by hlint

Found

data C_FFmpegScaler

Perhaps

data CFFmpegScaler

Use camelCase
Open

data C_AVFrame
Severity: Minor
Found in flaw-ffmpeg/Flaw/Media/FFmpeg.hs by hlint

Found

data C_AVFrame

Perhaps

data CAVFrame

Reduce duplication
Open

    checkPrefixed a "k" ["k1", "k2"]
Severity: Minor
Found in flaw-oil/test/repo-test.hs by hlint

Found

checkPrefixed a "k" ["k1", "k2"]
psp a
checkPrefixed a "k" ["k1", "k2"]

Perhaps

Combine with flaw-oil/test/repo-test.hs:271:5

Redundant bracket
Open

registerBasicOrdEntityType :: EntityManager -> EntityTypeId -> (GetEntity SomeBasicOrdEntity) -> IO ()
Severity: Minor
Found in flaw-editor/Flaw/Editor/Entity.hs by hlint

Found

(GetEntity SomeBasicOrdEntity) -> IO ()

Perhaps

GetEntity SomeBasicOrdEntity -> IO ()

Reduce duplication
Open

  (albedoOcclusion, material, viewNormal, depth) <- deferredPipelineLightPassInput $ zw__ screenPositionTexcoord
Severity: Minor
Found in flaw-visual/Flaw/Visual/Pipeline/Deferred.hs by hlint

Found

(albedoOcclusion, material, viewNormal,
 depth) <- deferredPipelineLightPassInput $
             zw__ screenPositionTexcoord
let albedo = xyz__ albedoOcclusion
    diffuse = x_ material
    specular = y_ material
    metalness = zzz__ material
    glossiness = w_ material
viewPositionH <- temp $
                   invProj `mul` cvec211 (xy__ screenPositionTexcoord) depth 1
viewPosition <- temp $ xyz__ viewPositionH / www__ viewPositionH

Perhaps

Combine with flaw-visual/Flaw/Visual/Pipeline/Deferred.hs:224:3

Use camelCase
Open

hb_codepoint = castPtr
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

hb_codepoint = ...

Perhaps

hbCodepoint = ...

Use camelCase
Open

data C_AVPacket
Severity: Minor
Found in flaw-ffmpeg/Flaw/Media/FFmpeg.hs by hlint

Found

data C_AVPacket

Perhaps

data CAVPacket

Use camelCase
Open

type FN_vkFreeFunction = Ptr () -> Ptr () -> IO ()
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkFreeFunction = Ptr () -> Ptr () -> IO ()

Perhaps

type FNVkFreeFunction = Ptr () -> Ptr () -> IO ()

Use camelCase
Open

type FN_vkCreateFramebuffer
  =  VkDevice
  -> Ptr VkFramebufferCreateInfo
  -> Ptr VkAllocationCallbacks
  -> Ptr VkFramebuffer
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkCreateFramebuffer =
    VkDevice
    -> Ptr VkFramebufferCreateInfo
       -> Ptr VkAllocationCallbacks -> Ptr VkFramebuffer -> IO Word32

Perhaps

type FNVkCreateFramebuffer =
    VkDevice
    -> Ptr VkFramebufferCreateInfo
       -> Ptr VkAllocationCallbacks -> Ptr VkFramebuffer -> IO Word32

Redundant bracket
Open

registerBasicEntityType :: EntityManager -> EntityTypeId -> (GetEntity SomeBasicEntity) -> IO ()
Severity: Minor
Found in flaw-editor/Flaw/Editor/Entity.hs by hlint

Found

(GetEntity SomeBasicEntity) -> IO ()

Perhaps

GetEntity SomeBasicEntity -> IO ()

Use camelCase
Open

data FT_LibraryRec
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/FreeType/FFI.hs by hlint

Found

data FT_LibraryRec

Perhaps

data FTLibraryRec

Redundant bracket
Open

  unit <- (csUnit . ccSettings) <$> get
Severity: Minor
Found in flaw-collada/Flaw/Asset/Collada.hs by hlint

Found

(csUnit . ccSettings) <$> get

Perhaps

csUnit . ccSettings <$> get

Redundant bracket
Open

    [ patSynSigD v (forallT [PlainTV a] (sequence [(conT ''Vectorized) `appT` (varT a)]) $ foldr (appT . (appT arrowT) . varT) ((conT v) `appT` (varT a)) (replicate dim a))
Severity: Minor
Found in flaw-math/Flaw/Math.hs by hlint

Found

(appT arrowT) . varT

Perhaps

appT arrowT . varT

Use uncurry
Open

      forM_ (M.toList dirtyRecords) $ \(key, value) -> clientRepoChange clientRepo key value
Severity: Minor
Found in flaw-editor/Flaw/Editor/Entity.hs by hlint

Found

\ (key, value) -> clientRepoChange clientRepo key value

Perhaps

uncurry (clientRepoChange clientRepo)

Applying this change:

  • increases laziness

Use newtype instead of data
Open

data AssetBuilderError ai
  = AssetBuilderDuplicateAssetIdError ai
  deriving Typeable
Severity: Minor
Found in flaw-asset/Flaw/Asset.hs by hlint

Found

data AssetBuilderError ai
  = AssetBuilderDuplicateAssetIdError ai
  deriving Typeable

Perhaps

newtype AssetBuilderError ai
  = AssetBuilderDuplicateAssetIdError ai
  deriving Typeable

Applying this change:

  • decreases laziness

Use =<<
Open

    join $ mapM_ snd <$> readIORef repeatOperationsRef
Severity: Minor
Found in flaw-al/Flaw/Audio/OpenAL.hs by hlint

Found

join $ mapM_ snd <$> readIORef repeatOperationsRef

Perhaps

mapM_ snd =<< readIORef repeatOperationsRef

Redundant $
Open

      [ funD 'norm [clause [] (normalB $ [| sqrt . norm2 |]) []]
Severity: Minor
Found in flaw-math/Flaw/Math.hs by hlint

Found

normalB $ [| sqrt . norm2 |]

Perhaps

normalB [| sqrt . norm2 |]

Use camelCase
Open

type FN_vkDestroyPipeline
  =  VkDevice
  -> VkPipeline
  -> Ptr VkAllocationCallbacks
  -> IO ()
Severity: Minor
Found in flaw-vulkan/Flaw/Graphics/Vulkan/FFI.hs by hlint

Found

type FN_vkDestroyPipeline =
    VkDevice -> VkPipeline -> Ptr VkAllocationCallbacks -> IO ()

Perhaps

type FNVkDestroyPipeline =
    VkDevice -> VkPipeline -> Ptr VkAllocationCallbacks -> IO ()
Severity
Category
Status
Source
Language