Sign upLogin

quyse/flaw

View on GitHub
Star

Showing 292 of 292 total issues

Use camelCase
Open

glDrawBuffers_n :: Int -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glDrawBuffers_n :: Int -> IO ()

Perhaps

glDrawBuffersN :: Int -> IO ()

Use camelCase
Open

newtype JS_WebGLContext = JS_WebGLContext JSVal
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

newtype JS_WebGLContext = JS_WebGLContext JSVal

Perhaps

newtype JSWebGLContext = JSWebGLContext JSVal

Use camelCase
Open

newtype JS_WebGLTexture = JS_WebGLTexture JSVal
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

newtype JS_WebGLTexture = JS_WebGLTexture JSVal

Perhaps

newtype JSWebGLTexture = JSWebGLTexture JSVal

Use camelCase
Open

data C_BulletGhost
Severity: Minor
Found in flaw-bullet/Flaw/Physics/Bullet.hs by hlint

Found

data C_BulletGhost

Perhaps

data CBulletGhost

Redundant bracket
Open

      normalFlow e = LuaInst [nextInstId] $ \[nextInstCode] codeState -> ((noBindS e) :) <$> nextInstCode codeState
Severity: Minor
Found in flaw-lua/Flaw/Script/Lua/Chunk.hs by hlint

Found

((noBindS e) :)

Perhaps

(noBindS e :)

Use camelCase
Open

type C_lua_Writer = Ptr C_lua_State -> Ptr () -> CSize -> Ptr () -> IO CInt
Severity: Minor
Found in flaw-lua/Flaw/Script/Lua/FFI.hs by hlint

Found

type C_lua_Writer =
    Ptr C_lua_State -> Ptr () -> CSize -> Ptr () -> IO CInt

Perhaps

type CLuaWriter =
    Ptr C_lua_State -> Ptr () -> CSize -> Ptr () -> IO CInt

Redundant bracket
Open

      (LuaBoolean . (`xor` 1) . luaCoerceToBool) <$> tryBinaryMetaMethod "__lt" b a
Severity: Minor
Found in flaw-lua/Flaw/Script/Lua/Operations.hs by hlint

Found

(LuaBoolean . (`xor` 1) . luaCoerceToBool) <$>
  tryBinaryMetaMethod "__lt" b a

Perhaps

LuaBoolean . (`xor` 1) . luaCoerceToBool <$>
  tryBinaryMetaMethod "__lt" b a

Use camelCase
Open

data Hb_font_t
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

data Hb_font_t

Perhaps

data HbFontT

Reduce duplication
Open

    srvInterface <- book bk $ allocateCOMObject $ with srvDesc $ \srvDescPtr ->
      createCOMObjectViaPtr $ m_ID3D11Device_CreateShaderResourceView deviceInterface (pokeCOMObject resourceInterface) srvDescPtr
Severity: Minor
Found in flaw-dx11/Flaw/Graphics/DirectX11.hs by hlint

Found

srvInterface <- book bk $
                  allocateCOMObject $
                    with srvDesc $
                      \ srvDescPtr ->
                        createCOMObjectViaPtr $
                          m_ID3D11Device_CreateShaderResourceView deviceInterface
                            (pokeCOMObject resourceInterface)
                            srvDescPtr
releaseResourceInterface
samplerState <- book bk $
                  createSamplerState device samplerStateInfo

Perhaps

Combine with flaw-dx11/Flaw/Graphics/DirectX11.hs:552:5

Use camelCase
Open

glBindAttribLocation_s :: GLuint -> GLuint -> T.Text -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glBindAttribLocation_s :: GLuint -> GLuint -> T.Text -> IO ()

Perhaps

glBindAttribLocationS :: GLuint -> GLuint -> T.Text -> IO ()

Use camelCase
Open

newtype JS_WebGLVertexArray = JS_WebGLVertexArray JSVal
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

newtype JS_WebGLVertexArray = JS_WebGLVertexArray JSVal

Perhaps

newtype JSWebGLVertexArray = JSWebGLVertexArray JSVal

Use camelCase
Open

glBufferData_bs :: GLenum -> B.ByteString -> GLenum -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

glBufferData_bs :: GLenum -> B.ByteString -> GLenum -> IO ()

Perhaps

glBufferDataBs :: GLenum -> B.ByteString -> GLenum -> IO ()

Redundant case
Open

      initGraphics graphicsSystemId = case graphicsSystemId of
#if defined(ghcjs_HOST_OS)
        AppGraphicsSystemWebGL -> do
          let _ = (maybeWindowPosition, maybeWindowSize, binaryCache, debug)
          (graphicsSystem, graphicsDevice, graphicsContext, presenter) <- book bk $ webglInit window needDepthBuffer
Severity: Minor
Found in flaw-app/Flaw/App.hs by hlint

Found

case graphicsSystemId of
    _ -> throwIO $ DescribeFirstException "unsupported graphics system"

Perhaps

throwIO $ DescribeFirstException "unsupported graphics system"

Reduce duplication
Open

    textureName <- glAllocTextureName
Severity: Minor
Found in flaw-gl/Flaw/Graphics/GlContext.hs by hlint

Found

textureName <- glAllocTextureName
glBindTexture GL_TEXTURE_2D textureName
glCheckErrors0 "bind texture"

Perhaps

Combine with flaw-gl/Flaw/Graphics/GlContext.hs:473:5

Use camelCase
Open

glBufferData_null :: GLenum -> GLsizeiptr -> GLenum -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glBufferData_null :: GLenum -> GLsizeiptr -> GLenum -> IO ()

Perhaps

glBufferDataNull :: GLenum -> GLsizeiptr -> GLenum -> IO ()

Use camelCase
Open

glGetProgramInfoLog_s :: GLuint -> IO T.Text
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glGetProgramInfoLog_s :: GLuint -> IO T.Text

Perhaps

glGetProgramInfoLogS :: GLuint -> IO T.Text

Use camelCase
Open

newtype JS_WebGLUniformLocation = JS_WebGLUniformLocation JSVal
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

newtype JS_WebGLUniformLocation = JS_WebGLUniformLocation JSVal

Perhaps

newtype JSWebGLUniformLocation = JSWebGLUniformLocation JSVal

Use camelCase
Open

glGetShaderInfoLog_s shader = pFromJSVal <$> glGetShaderInfoLog_val shader
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

glGetShaderInfoLog_s shader = ...

Perhaps

glGetShaderInfoLogS shader = ...

Use camelCase
Open

data MDB_env
Severity: Minor
Found in flaw-lmdb/Flaw/Data/Lmdb.hs by hlint

Found

data MDB_env

Perhaps

data MDBEnv

Reduce duplication
Open

  bufferSize <- readIORef sizeRef
Severity: Minor
Found in flaw-graphics/Flaw/Graphics/Program.hs by hlint

Found

bufferSize <- readIORef sizeRef
let align = shaderAlignment u
let alignedBufferSize
      = ((bufferSize + align - 1) `quot` align) * align

Perhaps

Combine with flaw-graphics/Flaw/Graphics/Program.hs:199:5
Severity
Category
Status
Source
Language