Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

Missing class import via use statement (line '705', column '32').
Open

            $displayTime = new XenForo_Phrase('threemagw_one_minute');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '118', column '35').
Open

        $messageDbInstaller = new ThreemaGateway_Installer_MessagesDb;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '185', column '42').
Open

        $providerInstaller['fast'] = new ThreemaGateway_Installer_TfaProvider(
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '65', column '41').
Open

        $this->gatewaySender      = new ThreemaGateway_Handler_Action_Sender;
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '73', column '20').
Open

        return new XenForo_Phrase('tfa_' . $this->_providerId);
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '81', column '20').
Open

        return new XenForo_Phrase('tfa_' . $this->_providerId . '_desc');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '108', column '34').
Open

        $throttleInstaller = new ThreemaGateway_Installer_ActionThrottle;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '29', column '20').
Open

        return new XenForo_Phrase('tfa_' . $this->_providerId . '_desc', $params);
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '707', column '49').
Open

            $displayTime = $minutes . ' ' . new XenForo_Phrase('threemagw_minutes');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '30', column '20').
Open

        return new XenForo_Phrase('tfa_' . $this->_providerId . '_desc', $params);
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Conventional.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '25', column '34').
Open

            $params['e2e'] = new XenForo_Phrase('threemagw_message_is_sent_e2e');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Conventional.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '547', column '58').
Open

                $blockActions = PHP_EOL . PHP_EOL . (new XenForo_Phrase('tfa_threemagw_message_blocked_canreverse'))->render();
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '136', column '37').
Open

        $permissionsInstaller = new ThreemaGateway_Installer_Permissions;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '181', column '46').
Open

        $providerInstaller['reversed'] = new ThreemaGateway_Installer_TfaProvider(
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '339', column '27').
Open

                throw new XenForo_Exception('Request invalid.');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function checkPhpSdk has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected static function checkPhpSdk(array &$status, array &$extraError, ThreemaGateway_Handler_Settings $gwSettings = null)
    {
        // auto-create Gateway settings if not given
        if ($gwSettings === null) {
            $gwSettings = new ThreemaGateway_Handler_Settings;
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function triggerVerification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function triggerVerification($context, array $user, $userIp, array &$providerData)
    {
        parent::triggerVerification($context, $user, $userIp, $providerData);

        if (!$providerData) {
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Conventional.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRandomString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getRandomString($length, $keyspace = 'abcdefghijklmnopqrstuvwxyz01234567')
    {
        /** @var string $output */
        $output = '';
        if (self::canUseLibsodium()) {
Severity: Minor
Found in src/library/ThreemaGateway/Helper/Random.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getExistingData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _getExistingData($data)
    {
        /** @var string $messageId */
        if (!$messageId = $this->_getExistingPrimaryKey($data, 'message_id')) {
            return false;
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function verifyOption has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static function verifyOption(&$option, XenForo_DataWriter $dataWriter, $fieldName)
    {
        if (!$option || !$option['enabled']) {
            // skip check if option is disabled
            return true;
Severity: Minor
Found in src/library/ThreemaGateway/Option/VerifyReceiveTime.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language