Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

The method __construct has a boolean flag argument $alreadyPrepared, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($alreadyPrepared = false, $skipPermissionCheck = false)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Receiver.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '677', column '27').
Open

                throw new XenForo_Exception('Could not get user data data.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '216', column '21').
Open

        return (new ThreemaGateway_Model_ActionThrottle)->isLimited($userId, $action);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Permissions.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '296', column '31').
Open

                    throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_httpshardening_option'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '115', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getMessageStateHistory has a boolean flag argument $getMetaData, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getMessageStateHistory($messageSentId, $getMetaData = true, $limitQuery = null)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Receiver.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '155', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_e2e_helper'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '245', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_keystorepath'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method add has a boolean flag argument $enabled, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function add($enabled = true)
Severity: Minor
Found in src/library/ThreemaGateway/Installer/TfaProvider.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '710', column '32').
Open

            $displayTime = new XenForo_Phrase('threemagw_one_hour');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '523', column '41').
Open

            $blockActions .= ' ' . (new XenForo_Phrase('tfa_threemagw_message_blocked_ip'))->render();
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '44', column '41').
Open

            $permissionsInstaller = new ThreemaGateway_Installer_Permissions;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '113', column '33').
Open

        $pendReqInstaller = new ThreemaGateway_Installer_TfaPendingConfirmMsgs;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '108', column '24').
Open

        $message = new XenForo_Phrase($phrase, [
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Conventional.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '554', column '28').
Open

            $message = new XenForo_Phrase('tfa_threemagw_message_blocked_general', [
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '65', column '38').
Open

            $keystoreInstaller = new ThreemaGateway_Installer_Keystore;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '83', column '39').
Open

            $messageDbInstaller = new ThreemaGateway_Installer_MessagesDb;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '88', column '37').
Open

            $pendReqInstaller = new ThreemaGateway_Installer_TfaPendingConfirmMsgs;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '712', column '47').
Open

            $displayTime = $hours . ' ' . new XenForo_Phrase('threemagw_hours');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '717', column '59').
Open

            $displayTime = floor($hours / 24) . ' ' . new XenForo_Phrase('threemagw_days');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language