Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

Missing class import via use statement (line '67', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threema_this_action_required_e2e'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '496', column '48').
Open

            $userBanDw->set('user_reason', new XenForo_Phrase('threemagw_tfa_user_banned'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '85', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threema_this_action_required_e2e'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '85', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threema_this_action_required_e2e'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '96', column '38').
Open

            $throttleInstaller = new ThreemaGateway_Installer_ActionThrottle;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '64', column '41').
Open

        $this->gatewayServer      = new ThreemaGateway_Handler_Action_GatewayServer;
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '319', column '59').
Open

                    return $controller->responseError(new XenForo_Phrase('two_step_verification_value_could_not_be_confirmed'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '481', column '41').
Open

            $blockActions .= ' ' . (new XenForo_Phrase('tfa_threemagw_message_blocked_login', [
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '509', column '41').
Open

            $blockActions .= ' ' . (new XenForo_Phrase('tfa_threemagw_message_blocked_user', [
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '67', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threema_this_action_required_e2e'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '131', column '34').
Open

        $keystoreInstaller = new ThreemaGateway_Installer_Keystore;
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '63', column '41').
Open

        $this->gatewaySettings    = new ThreemaGateway_Handler_Settings;
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '112', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_this_tfa_mode_is_not_setup'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '715', column '32').
Open

            $displayTime = new XenForo_Phrase('threemagw_one_day');
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '116', column '24').
Open

        $message = new XenForo_Phrase($phrase, [
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method userIsBlocked has a boolean flag argument $messageYetToSent, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function userIsBlocked(array $providerData, $messageYetToSent = false)
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Fast.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method threemagwSetupRaw has a boolean flag argument $ipAddress, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function threemagwSetupRaw($sessionId = '', $ipAddress = false, array $defaultSession = null)
Severity: Minor
Found in src/library/ThreemaGateway/Session.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '28', column '23').
Open

            throw new XenForo_Exception($error);
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '177', column '50').
Open

        $providerInstaller['conventional'] = new ThreemaGateway_Installer_TfaProvider(
Severity: Minor
Found in src/library/ThreemaGateway/Installer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '112', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_this_tfa_mode_is_not_setup'));
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/AbstractProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language