Sign upLogin

vorteil/vorteil

View on GitHub
Star

Showing 546 of 546 total issues

Method SparseWriter.writeGrainData has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (w *SparseWriter) writeGrainData() error {
    var err error

    firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
Severity: Minor
Found in pkg/vmdk/sparse.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function BindPort has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func BindPort(netType, protocol, port string) (string, string, error) {
    var (
        bind     string
        netRoute string
        isBound  bool
Severity: Minor
Found in pkg/virtualizers/util.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fixedStreamWrapper.wrap has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (w *fixedStreamWrapper) wrap() error {
    _, err := io.Copy(w, w.raw)
    if err != nil {
        return err
    }
Severity: Minor
Found in pkg/vhd/fixed.go - About 1 hr to fix

    Method ContainerConverter.createVCFG has 73 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (cc *ContainerConverter) createVCFG(config v1.Config, targetDir string) error {

    if _, err := os.Stat(targetDir); err != nil {
        return fmt.Errorf("directory %s does not exist", targetDir)
    }
    Severity: Minor
    Found in pkg/vconvert/vconvert.go - About 1 hr to fix

      Method Virtualizer.RemoveEntry has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
      Open

      func (v *Virtualizer) RemoveEntry() error {
    env, err := os.UserHomeDir()
    if err != nil {
        return err
    }
      Severity: Minor
      Found in pkg/virtualizers/vmware/virtualizer.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for i := int64(0); i < w.totalDataGrains; i++ {

        grainSector := int64(w.grainOffsets[i])
        if i+1 < int64(len(w.grainOffsets)) && grainSector == int64(w.grainOffsets[i+1]) {
            grainSector = 0
      Severity: Major
      Found in pkg/vmdk/sparse.go and 1 other location - About 1 hr to fix
      pkg/vmdk/sparse.go on lines 180..197

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 185.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for i := int64(0); i < w.totalDataGrains; i++ {

        grainSector := int64(w.grainOffsets[i])
        if i+1 < int64(len(w.grainOffsets)) && grainSector == int64(w.grainOffsets[i+1]) {
            grainSector = 0
      Severity: Major
      Found in pkg/vmdk/sparse.go and 1 other location - About 1 hr to fix
      pkg/vmdk/sparse.go on lines 134..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 185.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method DynamicWriter.writeRedundantFooter has 71 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (w *DynamicWriter) writeRedundantFooter() error {
    conectix := uint64(0x636F6E6563746978)
    timestamp := time.Now().Unix() - 946684800 // 2000 offset

    // CHS crap
      Severity: Minor
      Found in pkg/vhd/dynamic.go - About 1 hr to fix

        Function runFirecracker has 70 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func runFirecracker(pkgReader vpkg.Reader, cfg *vcfg.VCFG, name, diskOutput string) error {
    var err error
    if runtime.GOOS != "linux" {
        return errors.New("firecracker is only available on linux")
    }
        Severity: Minor
        Found in pkg/cli/virtualizers.go - About 1 hr to fix

          Method Virtualizer.RemoveEntry has 69 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (v *Virtualizer) RemoveEntry() error {
    env, err := os.UserHomeDir()
    if err != nil {
        return err
    }
          Severity: Minor
          Found in pkg/virtualizers/vmware/virtualizer.go - About 1 hr to fix

            Function StatImageFile has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
            Open

            func StatImageFile(vorteilImagePath string, imageFilePath string, seekOS bool) (StatFileReport, error) {
    var statOut StatFileReport
    vorteilImage, err := vdecompiler.Open(vorteilImagePath)
    if err != nil {
        return statOut, err
            Severity: Minor
            Found in pkg/imagetools/stat.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method Provisioner.Provision has 65 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
    var err error
    var imageID *string
    p.args = *args
            Severity: Minor
            Found in pkg/provisioners/amazon/amazon.go - About 1 hr to fix

              Function DUImageFile has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
              Open

              func DUImageFile(vorteilImage *vdecompiler.IO, imageFilePath string, calcFreeSpace bool, maxDepth int, all bool) (DUImageReport, error) {
    var duOut DUImageReport
    var depth = 0

    var recurse func(*ext.Inode, string) (int, error)
              Severity: Minor
              Found in pkg/imagetools/du.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method CLIRemoteManager.get has 17 return statements (exceeds 4 allowed).
              Open

              func (mgr *CLIRemoteManager) get(version CalVer) error {

    prog := mgr.log.NewProgress(fmt.Sprintf("Fetching kernel: %s", version.String()), "", 0)
    defer prog.Finish(false)
              Severity: Major
              Found in pkg/vkern/cli.go - About 1 hr to fix

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
                Severity: Major
                Found in pkg/virtualizers/vmware/virtualizer.go and 4 other locations - About 1 hr to fix
                pkg/virtualizers/firecracker/util_linux.go on lines 256..273
                pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
                pkg/virtualizers/qemu/virtualizer.go on lines 128..145
                pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 164.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
                Severity: Major
                Found in pkg/virtualizers/qemu/virtualizer.go and 4 other locations - About 1 hr to fix
                pkg/virtualizers/firecracker/util_linux.go on lines 256..273
                pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
                pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312
                pkg/virtualizers/vmware/virtualizer.go on lines 388..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 164.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
                Severity: Major
                Found in pkg/virtualizers/hyperv/virtualizer.go and 4 other locations - About 1 hr to fix
                pkg/virtualizers/firecracker/util_linux.go on lines 256..273
                pkg/virtualizers/qemu/virtualizer.go on lines 128..145
                pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312
                pkg/virtualizers/vmware/virtualizer.go on lines 388..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 164.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
                Severity: Major
                Found in pkg/virtualizers/virtualbox/virtualizer.go and 4 other locations - About 1 hr to fix
                pkg/virtualizers/firecracker/util_linux.go on lines 256..273
                pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
                pkg/virtualizers/qemu/virtualizer.go on lines 128..145
                pkg/virtualizers/vmware/virtualizer.go on lines 388..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 164.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
                Severity: Major
                Found in pkg/virtualizers/firecracker/util_linux.go and 4 other locations - About 1 hr to fix
                pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
                pkg/virtualizers/qemu/virtualizer.go on lines 128..145
                pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312
                pkg/virtualizers/vmware/virtualizer.go on lines 388..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 164.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function DUImageFile has 64 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func DUImageFile(vorteilImage *vdecompiler.IO, imageFilePath string, calcFreeSpace bool, maxDepth int, all bool) (DUImageReport, error) {
    var duOut DUImageReport
    var depth = 0

    var recurse func(*ext.Inode, string) (int, error)
                Severity: Minor
                Found in pkg/imagetools/du.go - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language