Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star

Showing 912 of 912 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.ui.MWLanguageVariantOneWayInspector.prototype.onClearButtonClick = function ( item ) {
    const idx = this.items.indexOf( item );
    this.items.splice( idx, 1 );
    this.layout.removeItems( [ item.layout ] );
    item.clearButton.disconnect( this );
Severity: Major
Found in modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js and 1 other location - About 3 hrs to fix
modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js on lines 672..677

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if ( attributes.isError ) {
        if ( converter.isForPreview() ) {
            imgWrapper.classList.add( 'new' );
        }
        const filename = mw.libs.ve.normalizeParsoidResourceName( attributes.resource || '' );
Severity: Major
Found in modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js and 1 other location - About 3 hrs to fix
modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js on lines 223..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.ui.MWLanguageVariantTwoWayInspector.prototype.onClearButtonClick = function ( item ) {
    const idx = this.items.indexOf( item );
    this.items.splice( idx, 1 );
    this.layout.removeItems( [ item.layout ] );
    item.clearButton.disconnect( this );
Severity: Major
Found in modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js and 1 other location - About 3 hrs to fix
modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js on lines 827..832

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.ui.MWAnnotationContextItem = function VeUiMWAnnotationContextItem() {
    // Parent constructor
    ve.ui.MWAnnotationContextItem.super.apply( this, arguments );

    // Initialization
Severity: Major
Found in modules/ve-mw/ui/contextitems/ve.ui.MWAnnotationContextItem.js and 1 other location - About 3 hrs to fix
modules/ve-mw/ui/contextitems/ve.ui.MWIncludesContextItem.js on lines 18..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.ui.MWIncludesContextItem = function VeUiMWIncludesContextItem() {
    // Parent constructor
    ve.ui.MWIncludesContextItem.super.apply( this, arguments );

    // Initialization
Severity: Major
Found in modules/ve-mw/ui/contextitems/ve.ui.MWIncludesContextItem.js and 1 other location - About 3 hrs to fix
modules/ve-mw/ui/contextitems/ve.ui.MWAnnotationContextItem.js on lines 18..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if ( attributes.isError ) {
        if ( converter.isForPreview() ) {
            imgWrapper.classList.add( 'new' );
        }
        const filename = mw.libs.ve.normalizeParsoidResourceName( attributes.resource || '' );
Severity: Major
Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 1 other location - About 3 hrs to fix
modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js on lines 225..231

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function swapPanel has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.ui.MWSaveDialog.prototype.swapPanel = function ( panel, noFocus ) {
    if ( ( [ 'save', 'review', 'preview', 'conflict' ].indexOf( panel ) ) === -1 ) {
        throw new Error( 'Unknown saveDialog panel: ' + panel );
    }
Severity: Major
Found in modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js - About 3 hrs to fix

    Function toDomElements has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    ve.dm.MWTransclusionNode.static.toDomElements = function ( dataElement, doc, converter ) {
    const store = converter.getStore(),
        originalMw = dataElement.attributes.originalMw,
        originalDomElements = store.value( dataElement.originalDomElementsHash );
    Severity: Minor
    Found in modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function escapeParameter has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    ve.dm.MWTransclusionNode.static.escapeParameter = function ( param ) {
    let input = param,
        output = '',
        inNowiki = false,
        bracketStack = 0,
    Severity: Minor
    Found in modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getLookupMenuOptionsFromData has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWCategoryInputWidget.prototype.getLookupMenuOptionsFromData = function ( data ) {
    const itemWidgets = [],
        existingCategoryItems = [],
        matchingCategoryItems = [],
        hiddenCategoryItems = [],
    Severity: Major
    Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js - About 3 hrs to fix

      File ve.dm.MWTransclusionNode.js has 307 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*!
 * VisualEditor DataModel MWTransclusionNode class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
      Severity: Minor
      Found in modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( attributeChanges.defaultSize && attributeChanges.defaultSize.to === true ) {
            sizeTo = ve.msg( 'visualeditor-mediasizewidget-sizeoptions-default' );
        } else {
            sizeTo = describeSize(
                'width' in attributeChanges ? attributeChanges.width.to : attributes.width,
        Severity: Major
        Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js and 1 other location - About 3 hrs to fix
        modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js on lines 135..142

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( attributeChanges.defaultSize && attributeChanges.defaultSize.from === true ) {
            sizeFrom = ve.msg( 'visualeditor-mediasizewidget-sizeoptions-default' );
        } else {
            sizeFrom = describeSize(
                'width' in attributeChanges ? attributeChanges.width.from : attributes.width,
        Severity: Major
        Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js and 1 other location - About 3 hrs to fix
        modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js on lines 143..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File ve.ui.MWTemplateDialog.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*!
 * VisualEditor user interface MWTemplateDialog class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
        Severity: Minor
        Found in modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js - About 3 hrs to fix

          Function getSetupProcess has 83 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          ve.ui.MWWikitextLinkAnnotationInspector.prototype.getSetupProcess = function ( data ) {
    // Annotation inspector stages the annotation, so call its parent
    // Call grand-parent
    return ve.ui.AnnotationInspector.super.prototype.getSetupProcess.call( this, data )
        .next( () => {
          Severity: Major
          Found in modules/ve-mw/ui/inspectors/ve.ui.MWWikitextLinkAnnotationInspector.js - About 3 hrs to fix

            Function toDataElement has 83 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            ve.dm.MWGalleryImageNode.static.toDataElement = function ( domElements, converter ) {
    // TODO: Improve handling of missing files. See 'isError' in MWBlockImageNode#toDataElement
    const li = domElements[ 0 ];
    const img = li.querySelector( '.mw-file-element' );
    const imgWrapper = img.parentNode;
            Severity: Major
            Found in modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js - About 3 hrs to fix

              Function activateTarget has 83 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function activateTarget( mode, section, tPromise, modified ) {
        let dataPromise;

        updateTabs( true, mode, section === 'new' );
              Severity: Major
              Found in modules/ve-mw/preinit/ve.init.mw.DesktopArticleTarget.init.js - About 3 hrs to fix

                Function toDataElement has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                Open

                ve.dm.MWBlockImageNode.static.toDataElement = function ( domElements, converter ) {
    const figure = domElements[ 0 ];
    const img = figure.querySelector( '.mw-file-element' ); // <img>, <video>, <audio>, or <span> if mw:Error
    // Images copied from the old parser output can have typeof=mw:Image but no resource information. T337438
    if ( !img || !img.hasAttribute( 'resource' ) ) {
                Severity: Minor
                Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createValueInput has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                Open

                ve.ui.MWParameterPage.prototype.createValueInput = function () {
    const type = this.parameter.getType(),
        value = this.parameter.getValue(),
        valueInputConfig = this.getDefaultInputConfig();
                Severity: Minor
                Found in modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method onSkinEditSectionLinks has 81 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function onSkinEditSectionLinks( $skin, $title, $section,
        $tooltip, &$result, $lang
    ) {
        $services = MediaWikiServices::getInstance();
        $userOptionsLookup = $services->getUserOptionsLookup();
                Severity: Major
                Found in includes/Hooks.php - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language