zkoss/zk

Method getBrowser has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static Browser getBrowser() {
        Double number = Servlets.getBrowser(ServletFns.getCurrentRequest(), "ff");
        if (number != null && number >= 3.6)
            return Browser.Firefox;
        number = Servlets.getBrowser(ServletFns.getCurrentRequest(), "ie");

Function d3_svg_lineHermite has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function d3_svg_lineHermite(points, tangents) {
  if (tangents.length < 1
      || (points.length != tangents.length
      && points.length != tangents.length + 2)) {
    return d3_svg_lineLinear(points);

Function d3_selection_classed has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function d3_selection_classed(name, value) {
  var re = new RegExp("(^|\\s+)" + d3.requote(name) + "(\\s+|$)", "g");

  // If no value is specified, return the first value.
  if (arguments.length < 2) {

Function _scrlIntoView has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function _scrlIntoView(outer: HTMLElement | null, inner: HTMLElement | null, info: ScrollIntoViewInfo | undefined, excludeHorizontal: boolean): ScrollIntoViewInfo {
    if (outer && inner) {
        var ooft = zk(outer).revisedOffset(),
            ioft = info ? info.oft : zk(inner).revisedOffset(),
            top = ioft[1] - ooft[1]

Function _createWrapper has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _createWrapper(element: JQuery): JQuery {
            // ZK-5354: Update animation implementation to avoid iframe reloading
            if (element.find('iframe').length) {
                return element;
            }

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    @AfterCompose
    public void init(@ScopeParam("applicationScopeVar") String applicationScope,
            @ScopeParam("sessionScopeVar") String sessionScope,
            @ScopeParam("desktopScopeVar") String desktopScope,
            @ScopeParam("pageScopeVar") String pageScope,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        {
            this.name0 = name0;
            this.name1 = name1;
            this.name2 = name2;
            this.name3 = name3;

• Read up
  Read up

Method init has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        @ContextParam(ContextType.BIND_CONTEXT) BindContext bindContext,
        @ContextParam(ContextType.BINDER) Binder binder,
        @ContextParam(ContextType.TRIGGER_EVENT) Event event,
        @ContextParam(ContextType.COMMAND_NAME) String commandName,
        @ContextParam(ContextType.EXECUTION) Execution execution,

Method show has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        @ContextParam(ContextType.BIND_CONTEXT) BindContext bindContext,
        @ContextParam(ContextType.BINDER) Binder binder,
        @ContextParam(ContextType.TRIGGER_EVENT) Event event,
        @ContextParam(ContextType.COMMAND_NAME) String commandName,
        @ContextParam(ContextType.EXECUTION) Execution execution,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (recurse) {
            if (_parent != null)
                return _parent.hasAttributeOrFellow(name, true);
            if (_page != null)
                return _page.hasAttributeOrFellow(name, true);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                for (int i = 0; i < 3; i++) {
                    foods.add(new Food("Seafood" + y, "Basa"));
                    foods.add(new Food("Seafood" + y, "Bluefish"));
                    foods.add(new Food("Seafood" + y, "Dorade"));
                    foods.add(new Food("Seafood" + y, "Salmon"));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                for (int i = 0; i < 3; i++) {
                    foods.add(new Food("Fruits" + y, "Apples"));
                    foods.add(new Food("Fruits" + y, "Bananas"));
                    foods.add(new Food("Fruits" + y, "Oranges"));
                    foods.add(new Food("Fruits" + y, "Grapes"));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (recurse) {
            if (_parent != null)
                return _parent.getAttributeOrFellow(name, true);
            if (_page != null)
                return _page.getAttributeOrFellow(name, true);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    for (; p2 && p2._vflex == 'min'; p2 = p2.parent) {
        delete p2._vflexsz;
        r2 = p2;
        ++j2;
        if (p2.ignoreFlexSize_('h')) //p2 will not affect its parent's flex size

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static postGlobalCommand(dom: HTMLElement, command: string, args?: Record<string, unknown>, opt?: zk.EventOptions, timeout?: number): void {
        var w = zk.Widget.$(dom);
        if (w) {
            var binder = w.$binder();
            if (binder) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static postCommand(dom: HTMLElement, command: string, args?: Record<string, unknown>, opt?: zk.EventOptions, timeout?: number): void {
        var w = zk.Widget.$(dom);
        if (w) {
            var binder = w.$binder();
            if (binder) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    for (; p1 && p1._hflex == 'min'; p1 = p1.parent) {
        delete p1._hflexsz;
        r1 = p1;
        ++j1;
        if (p1.ignoreFlexSize_('w')) //p1 will not affect its parent's flex size

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private class Iter implements Iterator<Component> {
        private final ListIterator<Component> _it = getChildren().listIterator();

        public boolean hasNext() {
            while (_it.hasNext()) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private class SetHandlerForCache implements MethodHandler {
        private Set _origin;

        public SetHandlerForCache(Set origin) {
            _origin = origin;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private class SetHandlerForCache implements MethodHandler {
        private Set _origin;
        public SetHandlerForCache(Set origin) {
            _origin = origin;
        }

• Read up
  Read up