Sign upLogin

emmercm/igir

View on GitHub
Star

Showing 444 of 448 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  private constructor(
    crc32: ChecksumsToFiles,
    md5: ChecksumsToFiles,
    sha1: ChecksumsToFiles,
    sha256: ChecksumsToFiles,
Severity: Minor
Found in src/types/indexedFiles.ts and 1 other location - About 40 mins to fix
src/types/patches/patch.ts on lines 16..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    while (!CMProParser.WHITESPACE_CHARS.has(this.contents.charAt(this.pos))) {
      this.pos += 1;
    }
Severity: Minor
Found in src/types/dats/cmpro/cmProParser.ts and 1 other location - About 40 mins to fix
src/types/dats/cmpro/cmProParser.ts on lines 148..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  static fromObject(obj: object): SoftwareListsDAT {
    return plainToInstance(SoftwareListsDAT, obj, {
      enableImplicitConversion: true,
      excludeExtraneousValues: true,
    }).generateGameNamesToParents();
Severity: Minor
Found in src/types/dats/softwarelist/softwareListsDat.ts and 2 other locations - About 40 mins to fix
src/types/dats/mame/mameDat.ts on lines 35..40
src/types/dats/softwarelist/softwareListDat.ts on lines 32..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const existingFilePathsCheck = await Promise.all(
      filePaths.map(async (filePath) =>
        existSemaphore.runExclusive(async () => fsPoly.exists(filePath)),
      ),
    );
Severity: Minor
Found in src/modules/directoryCleaner.ts and 1 other location - About 40 mins to fix
src/modules/movedRomDeleter.ts on lines 48..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    new GameConsole(
      /Amiga CD32/i,
      [
        /* '.bin', '.cue' */
      ],
Severity: Minor
Found in src/types/gameConsole.ts and 1 other location - About 40 mins to fix
src/types/gameConsole.ts on lines 512..527

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    while (!CMProParser.WHITESPACE_CHARS.has(this.contents.charAt(this.pos))) {
      this.pos += 1;
    }
Severity: Minor
Found in src/types/dats/cmpro/cmProParser.ts and 1 other location - About 40 mins to fix
src/types/dats/cmpro/cmProParser.ts on lines 201..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  static fromObject(obj: object): SoftwareListDAT {
    return plainToInstance(SoftwareListDAT, obj, {
      enableImplicitConversion: true,
      excludeExtraneousValues: true,
    }).generateGameNamesToParents();
Severity: Minor
Found in src/types/dats/softwarelist/softwareListDat.ts and 2 other locations - About 40 mins to fix
src/types/dats/mame/mameDat.ts on lines 35..40
src/types/dats/softwarelist/softwareListsDat.ts on lines 21..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  protected constructor(file: File, crcBefore: string, crcAfter?: string, sizeAfter?: number) {
    this.file = file;
    this.crcBefore = crcBefore;
    this.crcAfter = crcAfter;
    this.sizeAfter = sizeAfter;
Severity: Minor
Found in src/types/patches/patch.ts and 1 other location - About 40 mins to fix
src/types/indexedFiles.ts on lines 28..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    new GameConsole(
      /Odyssey 2/i,
      [
        /* '.bin' */
      ],
Severity: Minor
Found in src/types/gameConsole.ts and 1 other location - About 40 mins to fix
src/types/gameConsole.ts on lines 334..349

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const existingFilePathsCheck = await Promise.all(
      filePathsToDelete.map(async (filePath) =>
        existSemaphore.runExclusive(async () => fsPoly.exists(filePath)),
      ),
    );
Severity: Minor
Found in src/modules/movedRomDeleter.ts and 1 other location - About 40 mins to fix
src/modules/directoryCleaner.ts on lines 122..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, DATFilter.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/dats/datFilter.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, StatusGenerator.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/statusGenerator.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, FixdatCreator.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/fixdatCreator.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, Dir2DatCreator.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/dir2DatCreator.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, DirectoryCleaner.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/directoryCleaner.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, CandidatePreferer.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/candidates/candidatePreferer.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, DATMergerSplitter.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/dats/datMergerSplitter.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, DATParentInferrer.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/dats/datParentInferrer.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, ROMIndexer.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/roms/romIndexer.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePostProcessor.ts on lines 17..20
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

  constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, CandidatePostProcessor.name);
    this.options = options;
  }
Severity: Major
Found in src/modules/candidates/candidatePostProcessor.ts and 12 other locations - About 35 mins to fix
src/modules/candidates/candidateCombiner.ts on lines 20..23
src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
src/modules/candidates/candidatePreferer.ts on lines 16..19
src/modules/dats/datFilter.ts on lines 15..18
src/modules/dats/datMergerSplitter.ts on lines 18..21
src/modules/dats/datParentInferrer.ts on lines 15..18
src/modules/dir2DatCreator.ts on lines 20..23
src/modules/directoryCleaner.ts on lines 22..25
src/modules/fixdatCreator.ts on lines 24..27
src/modules/reportGenerator.ts on lines 16..19
src/modules/roms/romIndexer.ts on lines 24..27
src/modules/statusGenerator.ts on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language