Sign upLogin

emmercm/igir

View on GitHub
Star

Showing 444 of 448 total issues

Function parseGdi has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  private static async parseGdi<T extends Archive>(
    archive: T,
    gdiFilePath: string,
    binRawFilePaths: string[],
    checksumBitmask: number,
Severity: Minor
Found in src/types/files/archives/chd/chdGdiParser.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.progressBar.logTrace(`combining ${dats.length} DAT${dats.length !== 1 ? 's' : ''}`);
Severity: Minor
Found in src/modules/dats/datCombiner.ts and 1 other location - About 35 mins to fix
src/modules/dats/datCombiner.ts on lines 32..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.progressBar.logTrace(`done combining ${dats.length} DAT${dats.length !== 1 ? 's' : ''}`);
Severity: Minor
Found in src/modules/dats/datCombiner.ts and 1 other location - About 35 mins to fix
src/modules/dats/datCombiner.ts on lines 23..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return SoftwareListsDAT.fromObject(datObject.softwarelists);
Severity: Major
Found in src/modules/dats/datScanner.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return 99;
    Severity: Major
    Found in src/modules/roms/romIndexer.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return GameType.CRACKED;
      Severity: Major
      Found in src/types/dats/game.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return GameType.HOMEBREW;
        Severity: Major
        Found in src/types/dats/game.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return GameType.TRAINED;
          Severity: Major
          Found in src/types/dats/game.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return GameType.RETAIL;
            Severity: Major
            Found in src/types/dats/game.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return [];
              Severity: Major
              Found in src/types/dats/game.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return 5;
                Severity: Major
                Found in src/modules/roms/romIndexer.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return GameType.DEMO;
                  Severity: Major
                  Found in src/types/dats/game.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return undefined;
                    Severity: Major
                    Found in src/modules/dats/datScanner.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return undefined;
                      Severity: Major
                      Found in src/modules/dats/datScanner.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return GameType.PROGRAM;
                        Severity: Major
                        Found in src/types/dats/game.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return GameType.UNLICENSED;
                          Severity: Major
                          Found in src/types/dats/game.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return undefined;
                            Severity: Major
                            Found in src/modules/dats/datScanner.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return SoftwareListDAT.fromObject(datObject.softwarelist);
                              Severity: Major
                              Found in src/modules/dats/datScanner.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return GameType.DEVICE;
                                Severity: Major
                                Found in src/types/dats/game.ts - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return GameType.PIRATED;
                                  Severity: Major
                                  Found in src/types/dats/game.ts - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language