mysociety/alaveteli

View on GitHub

Showing 1,312 of 1,317 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe(
  "notification_mailer/info_request_batches/messages/_overdue.text.erb") do
  let!(:public_body_1) { FactoryGirl.create(:public_body, name: "One & Two") }
  let!(:public_body_2) { FactoryGirl.create(:public_body) }
  let!(:batch_request) do
spec/views/notification_mailer/info_request_batches/messages/_very_overdue.text.erb_spec.rb on lines 4..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe '#very_overdue_notification' do
    let(:public_body) do
      FactoryGirl.build(:public_body, name: 'Test public body')
    end
    let(:info_request) do
Severity: Major
Found in spec/mailers/notification_mailer_spec.rb and 1 other location - About 6 hrs to fix
spec/mailers/notification_mailer_spec.rb on lines 661..727

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method import_csv_from_file has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

  def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
    errors = []
    notes = []
    begin
      ActiveRecord::Base.transaction do
Severity: Minor
Found in app/models/public_body.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class OutgoingMessage has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

class OutgoingMessage < ActiveRecord::Base
  include AdminColumn
  include MessageProminence
  include Rails.application.routes.url_helpers
  include LinkToHelper
Severity: Minor
Found in app/models/outgoing_message.rb - About 5 hrs to fix

    Class RequestController has 43 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class RequestController < ApplicationController
      before_filter :check_read_only, :only => [ :new, :describe_state, :upload_response ]
      before_filter :check_batch_requests_and_user_allowed, :only => [ :select_authorities, :new_batch ]
      before_filter :set_render_recaptcha, :only => [ :new ]
      before_filter :redirect_numeric_id_to_url_title, :only => [:show]
    Severity: Minor
    Found in app/controllers/request_controller.rb - About 5 hrs to fix

      File info_request_event.rb has 407 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class InfoRequestEvent < ActiveRecord::Base
        include AdminColumn
        extend XapianQueries
      
        EVENT_TYPES = [
      Severity: Minor
      Found in app/models/info_request_event.rb - About 5 hrs to fix

        Function setup has 141 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                setup: function() {
                    var self      = this;
                    var settings  = self.settings;
                    var eventNS   = self.eventNS;
                    var $window   = $(window);
        Severity: Major
        Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 5 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            describe "Authority censor rules" do
          
              it 'clears the cache for existing requests when a new rule is added' do
                url_title = request.url_title
                visit show_request_path :url_title => url_title
          Severity: Major
          Found in spec/integration/admin_censor_rule_spec.rb and 1 other location - About 5 hrs to fix
          spec/integration/admin_censor_rule_spec.rb on lines 113..176

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 181.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            describe "User censor rules" do
          
              it 'clears the cache for existing requests when a new rule is added' do
                url_title = request.url_title
                visit show_request_path :url_title => url_title
          Severity: Major
          Found in spec/integration/admin_censor_rule_spec.rb and 1 other location - About 5 hrs to fix
          spec/integration/admin_censor_rule_spec.rb on lines 45..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 181.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (drawLower) {
                      if (err.lowerCap == '-'){
                          if (err.err=='x') drawPath(ctx, [[lower,y - radius],[lower,y + radius]] );
                          else drawPath(ctx, [[x - radius,lower],[x + radius,lower]] );
                      } else if ($.isFunction(err.lowerCap)){
          Severity: Major
          Found in app/assets/javascripts/jquery.flot.errorbars.js and 1 other location - About 5 hrs to fix
          app/assets/javascripts/jquery.flot.errorbars.js on lines 301..309

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 143.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            DraftBatchSummary.bindXHR = function bindXHR() {
              DraftBatchSummary.currentXHR.done(function(data) {
                $el.trigger(Events.loadingSuccess, {html: data});
              });
              DraftBatchSummary.currentXHR.fail(function(xhr, textStatus) {
          app/assets/javascripts/alaveteli_pro/batch_authority_search/initialise.js on lines 31..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 143.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            BatchAuthoritySearch.bindXHR = function bindXHR() {
              BatchAuthoritySearch.currentXHR.done(function(data) {
                $el.trigger(Events.loadingSuccess, {html: data});
              });
              BatchAuthoritySearch.currentXHR.fail(function(xhr, textStatus) {
          app/assets/javascripts/alaveteli_pro/draft_batch_summary/initialise.js on lines 33..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 143.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (drawUpper) {
                      if (err.upperCap == '-'){
                          if (err.err=='x') drawPath(ctx, [[upper,y - radius],[upper,y + radius]] );
                          else drawPath(ctx, [[x - radius,upper],[x + radius,upper]] );
                      } else if ($.isFunction(err.upperCap)){
          Severity: Major
          Found in app/assets/javascripts/jquery.flot.errorbars.js and 1 other location - About 5 hrs to fix
          app/assets/javascripts/jquery.flot.errorbars.js on lines 311..319

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 143.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Class ApplicationController has 40 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class ApplicationController < ActionController::Base
            class PermissionDenied < StandardError
            end
            class RouteNotFound < StandardError
            end
          Severity: Minor
          Found in app/controllers/application_controller.rb - About 5 hrs to fix

            File request_summary_spec.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'spec_helper'
            
            RSpec.describe AlaveteliPro::RequestSummary, type: :model do
              let(:public_bodies) { FactoryGirl.create_list(:public_body, 3) }
              let(:public_body_names) do
            Severity: Minor
            Found in spec/models/alaveteli_pro/request_summary_spec.rb - About 5 hrs to fix

              File application_controller.rb has 385 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'open-uri'
              
              class ApplicationController < ActionController::Base
                class PermissionDenied < StandardError
                end
              Severity: Minor
              Found in app/controllers/application_controller.rb - About 5 hrs to fix

                File request_mailer.rb has 385 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                class RequestMailer < ApplicationMailer
                  include AlaveteliFeatures::Helpers
                
                  # Used when an FOI officer uploads a response from their web browser - this is
                  # the "fake" email used to store in the same format in the database as if they
                Severity: Minor
                Found in app/mailers/request_mailer.rb - About 5 hrs to fix

                  Method initialize_query has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def initialize_query(options)
                        #raise options.to_yaml
                  
                        self.runtime += Benchmark::realtime {
                          offset = options[:offset] || 0; offset = offset.to_i
                  Severity: Minor
                  Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method up has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def up
                      default_locale = AlaveteliLocalization.default_locale
                  
                      fields = {:title => :text,
                                :description => :text}
                  Severity: Minor
                  Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              for (i = 0; i < yaxes.length; ++i) {
                                  axis = yaxes[i];
                                  if (axis && axis.used) {
                                      key = "y" + axis.n;
                                      if (pos[key] == null && axis.n == 1)
                  Severity: Major
                  Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 5 hrs to fix
                  app/assets/javascripts/jquery.flot.js on lines 896..908

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 136.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language