ory-am/hydra

Method DefaultStrategy.executeBackChannelLogout has 7 return statements (exceeds 4 allowed).

Open

func (s *DefaultStrategy) executeBackChannelLogout(r *http.Request, subject, sid string) error {
    ctx := r.Context()
    clients, err := s.r.ConsentManager().ListUserAuthenticatedClientsWithBackChannelLogout(ctx, subject, sid)
    if err != nil {
        return err

Method Handler.rejectOAuth2ConsentRequest has 7 return statements (exceeds 4 allowed).

Open

func (h *Handler) rejectOAuth2ConsentRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("consent_challenge"),

Function NewRegistryFromDSN has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewRegistryFromDSN(ctx context.Context, c *config.DefaultProvider, l *logrusx.Logger, skipNetworkInit bool, migrate bool, ctxer contextx.Contextualizer) (Registry, error) {

Method Persister.ConfirmLoginSession has 7 return statements (exceeds 4 allowed).

Open

func (p *Persister) ConfirmLoginSession(ctx context.Context, loginSession *flow.LoginSession) (err error) {
    ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.ConfirmLoginSession")
    defer otelx.End(span, &err)

    loginSession.NID = p.NetworkID(ctx)

Avoid deeply nested control flow statements.

Open

    } else if s, ok := body.(*string); ok {
        _, err = bodyBuf.WriteString(*s)
    } else if JsonCheck.MatchString(contentType) {
        err = json.NewEncoder(bodyBuf).Encode(body)
    } else if XmlCheck.MatchString(contentType) {

Method Handler.CreateClient has 7 return statements (exceeds 4 allowed).

Open

func (h *Handler) CreateClient(r *http.Request, validator func(context.Context, *Client) error, isDynamic bool) (*Client, error) {
    var c Client
    if err := json.NewDecoder(r.Body).Decode(&c); err != nil {
        return nil, errorsx.WithStack(herodot.ErrBadRequest.WithReasonf("Unable to decode the request body: %s", err))
    }

Function TestHandler has 7 return statements (exceeds 4 allowed).

Open

func TestHandler(t *testing.T) {
    ctx := context.Background()
    reg := internal.NewMockedRegistry(t, &contextx.Default{})
    h := client.NewHandler(reg)
    reg.WithContextualizer(&contextx.TestContextualizer{})

Function New has 7 return statements (exceeds 4 allowed).

Open

func New(ctx context.Context, sl *servicelocatorx.Options, opts []OptionsModifier) (Registry, error) {
    o := NewOptions(opts)

    l := sl.Logger()
    if l == nil {

Method MetadataAPIService.GetVersionExecute has 7 return statements (exceeds 4 allowed).

Open

func (a *MetadataAPIService) GetVersionExecute(r ApiGetVersionRequest) (*GetVersion200Response, *http.Response, error) {
    var (
        localVarHTTPMethod  = http.MethodGet
        localVarPostBody    interface{}
        formFiles           []formFile

Avoid deeply nested control flow statements.

Open

        if tt == fosite.AccessToken && c.JwtBearerGrantAccessTokenLifespan.Valid {
            cl = &c.JwtBearerGrantAccessTokenLifespan.Duration
        }

Function NewPersister has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewPersister(ctx context.Context, c *pop.Connection, r Dependencies, config *config.DefaultProvider, extraMigrations []fs.FS, goMigrations []popx.Migration) (*Persister, error) {

Avoid deeply nested control flow statements.

Open

    } else if gt == fosite.GrantTypePassword {
        if tt == fosite.AccessToken && c.PasswordGrantAccessTokenLifespan.Valid {
            cl = &c.PasswordGrantAccessTokenLifespan.Duration
        } else if tt == fosite.RefreshToken && c.PasswordGrantRefreshTokenLifespan.Valid {
            cl = &c.PasswordGrantRefreshTokenLifespan.Duration

Avoid deeply nested control flow statements.

Open

        } else if tt == fosite.IDToken && c.ImplicitGrantIDTokenLifespan.Valid {
            cl = &c.ImplicitGrantIDTokenLifespan.Duration
        }

Method JwkAPIService.DeleteJsonWebKeyExecute has 7 return statements (exceeds 4 allowed).

Open

func (a *JwkAPIService) DeleteJsonWebKeyExecute(r ApiDeleteJsonWebKeyRequest) (*http.Response, error) {
    var (
        localVarHTTPMethod = http.MethodDelete
        localVarPostBody   interface{}
        formFiles          []formFile

Method RegistrySQL.Init has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    ctx context.Context,
    skipNetworkInit bool,
    migrate bool,
    ctxer contextx.Contextualizer,
    extraMigrations []fs.FS,

Method Persister.migrateOldMigrationTables has 7 return statements (exceeds 4 allowed).

Open

func (p *Persister) migrateOldMigrationTables() error {
    if err := p.conn.RawQuery(fmt.Sprintf("SELECT * FROM %s", clientMigrationTableName)).Exec(); err != nil {
        // assume there are no old migration tables => done
        return nil
    }

Method JwkAPIService.DeleteJsonWebKeySetExecute has 7 return statements (exceeds 4 allowed).

Open

func (a *JwkAPIService) DeleteJsonWebKeySetExecute(r ApiDeleteJsonWebKeySetRequest) (*http.Response, error) {
    var (
        localVarHTTPMethod = http.MethodDelete
        localVarPostBody   interface{}
        formFiles          []formFile

Avoid deeply nested control flow statements.

Open

                            for {
                                bo := conf.NextBackOff()
                                require.NotEqual(t, backoff.Stop, bo, "%+v", err)

                                _, _, err = hydra.JwkAPI.CreateJsonWebKeySet(context.Background(), "hydra.openid.id-token").CreateJsonWebKeySet(hydrac.CreateJsonWebKeySet{

Similar blocks of code found in 17 locations. Consider refactoring.

Open

func (mr *MockManagerMockRecorder) AddKey(ctx, set, key interface{}) *gomock.Call {
    mr.mock.ctrl.T.Helper()
    return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddKey", reflect.TypeOf((*MockManager)(nil).AddKey), ctx, set, key)
}

• Read up
  Read up

Similar blocks of code found in 17 locations. Consider refactoring.

Open

func (mr *MockManagerMockRecorder) UpdateKeySet(ctx, set, keys interface{}) *gomock.Call {
    mr.mock.ctrl.T.Helper()
    return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "UpdateKeySet", reflect.TypeOf((*MockManager)(nil).UpdateKeySet), ctx, set, keys)
}

• Read up
  Read up