Showing 8 of 16 total issues

Function reduceNode has a Cognitive Complexity of 22 (exceeds 8 allowed). Consider refactoring.
Open

    protected static function reduceNode(array $node) {

        static $reducers = [];

        // If node has "skip" node defined, replace the whole node with the
Severity: Minor
Found in src/parser/ParserHandler.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function string_find_first(StringValue $self, Value $needle): Value {

        // Allow only some value types.
        Common::allowTypes($needle, StringValue::class, NumberValue::class);

Severity: Major
Found in src/extensions/psl/StringExtension.php and 1 other location - About 1 hr to fix
src/extensions/psl/StringExtension.php on lines 169..181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function string_find_last(StringValue $self, Value $needle): Value {

        // Allow only some value types.
        Common::allowTypes($needle, StringValue::class, NumberValue::class);

Severity: Major
Found in src/extensions/psl/StringExtension.php and 1 other location - About 1 hr to fix
src/extensions/psl/StringExtension.php on lines 155..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method doComparison has 43 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    public function doComparison(string $op, Value $right): BoolValue {

        Common::allowTypes(
            $right,
            self::class,
Severity: Minor
Found in src/structures/NumberValue.php - About 1 hr to fix

    Function loop has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
    Open

        private function loop() {
    
            $i = $this->interpreter;
            $c = $i->getContext();
    
    
    Severity: Minor
    Found in src/Repl.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function doComparison has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

        public function doComparison(string $op, Value $rightOperand): BoolValue {
    
            Common::allowTypes(
                $rightOperand,
                self::class,
    Severity: Minor
    Found in src/structures/StringValue.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return (bool) $v;
    Severity: Major
    Found in src/helpers/Common.php - About 30 mins to fix

      Function run_test has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
      Open

      function run_test(string $file) {
      
          $context = new \Smuuf\Primi\Context;
          $interpreter = new \Smuuf\Primi\Interpreter($context);
          $outputFile = dirname($file) . "/" . basename($file, ".primi") . ".expect";
      Severity: Minor
      Found in tests/language/common.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language