Sign upLogin

Mirroar/hivemind

View on GitHub
Star

Showing 1,361 of 1,362 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    getPath(creep: MineBuilderCreep): RoomPosition[] | null {
        if (!creep.operation) return null;

        const paths = creep.operation.getPaths();
        if (!paths[creep.memory.source] || !paths[creep.memory.source].accessible) return null;
Severity: Major
Found in src/role/builder.mines.ts and 1 other location - About 4 hrs to fix
src/role/hauler.relay.ts on lines 143..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File combat-manager.ts has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import hivemind from 'hivemind';
import utilities from 'utilities';
import {getResourcesIn} from 'utils/store';
import {handleMapArea} from 'utils/map';
Severity: Minor
Found in src/creep/combat-manager.ts - About 4 hrs to fix

    Function addObjectResourceOptions has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        addObjectResourceOptions(options: TransporterSourceOrderOption[], findConstant: FIND_RUINS | FIND_TOMBSTONES | FIND_DROPPED_RESOURCES, optionType: 'resource' | 'tombstone') {
        const creep = this.creep;

        // Look for resources on the ground.
        const targets = creep.room.find(findConstant, {
    Severity: Minor
    Found in src/role/transporter.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addResourceRequestOptions has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        private addResourceRequestOptions(options: TransportRouteOption[], room: Room, resourceType: ResourceConstant, roomState: RoomResourceState) {
        // Fullfill allies trade requests.
        for (const roomName2 in Memory?.requests?.trade?.[resourceType] || {}) {
            const info = Memory.requests.trade[resourceType][roomName2];
            if (Game.time - info.lastSeen > 10) {
    Severity: Minor
    Found in src/empire/trade-route-manager.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function calculateRoomPriorities has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        calculateRoomPriorities(roomName: string) {
        const roomIntel = getRoomIntel(roomName);
        const info = Memory.strategy.roomList[roomName];

        info.scoutPriority = 0;
    Severity: Minor
    Found in src/process/strategy/scout.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function findBayPosition has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        findBayPosition(): RoomPosition {
        let maxExtensions = 0;
        let bestPos = null;
        let bestScore = 0;
    Severity: Minor
    Found in src/room/planner/variation-builder.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        getBlinkyCreepBody(room: Room, maxAttackParts?: number): BodyPartConstant[] {
        return (new BodyBuilder())
            .setWeights({[RANGED_ATTACK]: 7, [HEAL]: 3})
            .setPartLimit(RANGED_ATTACK, maxAttackParts)
            .setEnergyLimit(Math.min(room.energyCapacityAvailable, Math.max(room.energyCapacityAvailable * 0.9, room.energyAvailable)))
    Severity: Major
    Found in src/spawn-role/brawler.ts and 1 other location - About 4 hrs to fix
    src/spawn-role/brawler.ts on lines 340..347

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        getBrawlerCreepBody(room: Room, maxAttackParts?: number): BodyPartConstant[] {
        return (new BodyBuilder())
            .setWeights({[ATTACK]: 2, [HEAL]: 1})
            .setPartLimit(ATTACK, maxAttackParts)
            .setEnergyLimit(Math.min(room.energyCapacityAvailable, Math.max(room.energyCapacityAvailable * 0.9, room.energyAvailable)))
    Severity: Major
    Found in src/spawn-role/brawler.ts and 1 other location - About 4 hrs to fix
    src/spawn-role/brawler.ts on lines 349..356

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function performMilitaryMove has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        performMilitaryMove(creep: BrawlerCreep) {
        if (creep.isPartOfTrain() && this.performTrainMove(creep) !== OK) return;

        if (creep.memory.fillWithEnergy) {
            if (creep.room.isMine() && creep.store.getFreeCapacity() > 0) {
    Severity: Minor
    Found in src/role/brawler.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function chooseNewExpansionTarget has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        chooseNewExpansionTarget() {
        // Choose a room to expand to.
        let bestTarget;
        let modifiedBestExpansionScore: number;
        const startTime = Game.cpu.getUsed();
    Severity: Minor
    Found in src/process/strategy/expand.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkAdjacentRooms has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        checkAdjacentRooms() {
        if (!this.memory.adjacentSafe) {
            this.memory.adjacentSafe = {
                N: false,
                E: false,
    Severity: Minor
    Found in src/room/planner/room-planner.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildEndgameStructures has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        buildEndgameStructures() {
        if (this.room.terminal) {
            // Once there is a terminal, build quad-breaker walls.
            this.buildPlannedStructures('wall.quad', STRUCTURE_WALL);
        }
    Severity: Minor
    Found in src/room/room-manager.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const linkId = cache.inHeap('link:' + this.id, 1000, () => {
        // @todo Could use old data and just check if object still exits.
        // Check if there is a link nearby.
        const structures = this.pos.findInRange(FIND_STRUCTURES, 3, {
            filter: structure => structure.structureType === STRUCTURE_LINK,
    Severity: Major
    Found in src/manager.source.ts and 1 other location - About 4 hrs to fix
    src/manager.source.ts on lines 203..215

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const lairId = cache.inHeap('lair:' + this.id, 150_000, () => {
        // @todo Could use old data and just check if object still exits.
        // Check if there is a lair nearby.
        const structures = this.pos.findInRange(FIND_STRUCTURES, 10, {
            filter: structure => structure.structureType === STRUCTURE_KEEPER_LAIR,
    Severity: Major
    Found in src/manager.source.ts and 1 other location - About 4 hrs to fix
    src/manager.source.ts on lines 175..187

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function performPickup has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        performPickup(creep: RelayHaulerCreep) {
        creep.say('p0');
        const sourcePosition = decodePosition(creep.memory.source);
        if (!sourcePosition) {
            creep.say('newtar');
    Severity: Minor
    Found in src/role/hauler.relay.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cleanRoom has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        cleanRoom() {
        // Remove all extensions and labs blocking roads or bays (from redesigning rooms).
        for (const extension of this.structuresByType[STRUCTURE_EXTENSION] || []) {
            if (this.roomPlanner.isPlannedLocation(extension.pos, 'extension')) continue;
            if (!this.roomPlanner.isPlannedLocation(extension.pos, 'road')) continue;
    Severity: Minor
    Found in src/room/room-manager.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    RemoteMiningOperation has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export default class RemoteMiningOperation extends Operation {
    protected memory: RemoteMiningOperationMemory;
    protected pathManager: PathManager;

    /**
    Severity: Minor
    Found in src/operation/remote-mining.ts - About 3 hrs to fix

      Function manageStructures has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          manageStructures() {
        if (_.size(Game.spawns) === 1 && _.sample(Game.spawns).room.name === this.room.name && this.room.controller.level < 4) {
            // In our first room, getting more extensions is pretty important for
            // spawning bigger creeps asap.
            this.manageExtensions();
      Severity: Major
      Found in src/room/room-manager.ts - About 3 hrs to fix

        File builder.mines.ts has 323 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /* global FIND_DROPPED_RESOURCES RESOURCE_ENERGY OK
ERR_NO_PATH ERR_NOT_IN_RANGE FIND_STRUCTURES STRUCTURE_CONTAINER STRUCTURE_ROAD
FIND_MY_CONSTRUCTION_SITES LOOK_STRUCTURES MAX_CONSTRUCTION_SITES
LOOK_CONSTRUCTION_SITES */
        Severity: Minor
        Found in src/role/builder.mines.ts - About 3 hrs to fix

          Function performRemoteBuild has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
          Open

              performRemoteBuild() {
        const creep: Creep = this.creep;

        // Try and prevent controller downgrades.
        if (creep.room.isMine() && !creep.room.controller.upgradeBlocked && (creep.room.controller.level < 2 || creep.room.controller.ticksToDowngrade < 500)) {
          Severity: Minor
          Found in src/role/builder.remote.ts - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language