Sign upLogin

danini-the-panini/mittsu-opengl

View on GitHub
Star

Showing 251 of 251 total issues

Unused block argument - m. You can omit the argument if you don't care about it.
Open

        @num_morph_targets.times do |m|
Severity: Minor
Found in lib/mittsu/opengl/geometry_group.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused method argument - fog. If it's necessary, use _ or _fog as an argument name to indicate that it won't be used.
Open

    def render_buffer(camera, lights, fog, material, geometry_group, update_buffers)
Severity: Minor
Found in lib/mittsu/opengl_implementation/objects/mesh.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused block argument - window_handle. If it's necessary, use _ or _window_handle as an argument name to indicate that it won't be used.
Open

        @char_callback = ::GLFW::create_callback(:GLFWcharfun) do |window_handle, codepoint|
Severity: Minor
Found in lib/mittsu/glfw/window.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

end at 329, 12 is not aligned with case at 323, 19.
Open

            end
Severity: Minor
Found in lib/mittsu/opengl_implementation/core/geometry.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Unused method argument - camera. If it's necessary, use _ or _camera as an argument name to indicate that it won't be used.
Open

    def render_buffer(camera, lights, fog, material, geometry_group, update_buffers)
Severity: Minor
Found in lib/mittsu/opengl_implementation/objects/mesh.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - update_buffers. If it's necessary, use _ or _update_buffers as an argument name to indicate that it won't be used.
Open

    def render_buffer(camera, lights, fog, material, geometry_group, update_buffers)
Severity: Minor
Found in lib/mittsu/opengl_implementation/objects/line.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused block argument - m. You can omit the argument if you don't care about it.
Open

        num_morph_normals.times do |m|
Severity: Minor
Found in lib/mittsu/opengl/geometry_group.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused block argument - window_handle. If it's necessary, use _ or _window_handle as an argument name to indicate that it won't be used.
Open

        @frabuffer_size_callback = ::GLFW::create_callback(:GLFWframebuffersizefun) do |window_handle, new_width, new_height|
Severity: Minor
Found in lib/mittsu/glfw/window.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

TODO found
Open

        # TODO: investigate this (?):
Severity: Minor
Found in lib/mittsu/opengl_implementation/textures/render_target.rb by fixme

TODO found
Open

      if false # material.is_a?(RawShaderMaterial) # TODO: when RawShaderMaterial exists
Severity: Minor
Found in lib/mittsu/opengl/program.rb by fixme

TODO found
Open

                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
Severity: Minor
Found in .rubocop.yml by fixme

TODO found
Open

    # MeshDepthMaterial => :depth, # TODO...
Severity: Minor
Found in lib/mittsu/opengl_implementation/materials/material.rb by fixme

TODO found
Open

      max_vertices_in_group = 65535 # TODO: OES_element_index_uint ???
Severity: Minor
Found in lib/mittsu/opengl_implementation/core/geometry.rb by fixme

FIXME found
Open

          # TODO!!! FIXME!!!
Severity: Minor
Found in lib/mittsu/opengl_implementation/core/object_3d.rb by fixme

TODO found
Open

          # TODO: SkinnedMesh/morph_targets
Severity: Minor
Found in lib/mittsu/opengl/plugins/shadow_map_plugin.rb by fixme

TODO found
Open

      # TODO: load extensions??
Severity: Minor
Found in lib/mittsu/opengl/renderer.rb by fixme

FIXME found
Open

      # TODO!!! FIXME!!!
Severity: Minor
Found in lib/mittsu/opengl_implementation/core/object_3d.rb by fixme

TODO found
Open

    # TODO: populate with extension parameters?
Severity: Minor
Found in lib/mittsu/opengl/gl_mittsu_params.rb by fixme

TODO found
Open

// uniform float scale; // TODO
Severity: Minor
Found in lib/mittsu/opengl/shader/lib/particle_basic/particle_basic_vertex.rbsl by fixme

XXX found
Open

[![Maintainability](https://api.codeclimate.com/v1/badges/XXX/maintainability)](https://codeclimate.com/github/danini-the-panini/mittsu-opengl/maintainability)
Severity: Minor
Found in README.md by fixme
Severity
Category
Status
Source
Language