dotcloud/docker

Function newStreamConfig has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func newStreamConfig(info logger.Info) (*logStreamConfig, error) {
    logGroupName := info.Config[logGroupKey]
    logStreamName, err := loggerutils.ParseLogTag(info, "{{.FullID}}")
    if err != nil {
        return nil, err

Function serviceSpecFromGRPC has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func serviceSpecFromGRPC(spec *swarmapi.ServiceSpec) (*types.ServiceSpec, error) {
    if spec == nil {
        return nil, nil
    }

Method LocalRegistry.Scan has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (l *LocalRegistry) Scan() ([]string, error) {
    var names []string
    dirEntries, err := os.ReadDir(l.socketsPath)
    if err != nil && !os.IsNotExist(err) {
        return nil, errors.Wrap(err, "error reading dir entries")

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (n *Namespace) UnsetGateway() error {
    gw := n.Gateway()
    if len(gw) == 0 {
        return nil
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    case NodeEventTypeJoin:
        moved, err := nDB.changeNodeState(n.Name, nodeActiveState)
        if err != nil {
            log.G(context.TODO()).WithError(err).Error("unable to find the node to move")
            return false

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (n *Namespace) UnsetGatewayIPv6() error {
    gwv6 := n.GatewayIPv6()
    if len(gwv6) == 0 {
        return nil
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    case NodeEventTypeLeave:
        moved, err := nDB.changeNodeState(n.Name, nodeLeftState)
        if err != nil {
            log.G(context.TODO()).WithError(err).Error("unable to find the node to move")
            return false

• Read up
  Read up

Method puller.pullManifestList has 10 return statements (exceeds 4 allowed).

Open

func (p *puller) pullManifestList(ctx context.Context, ref reference.Named, mfstList *manifestlist.DeserializedManifestList, pp *ocispec.Platform) (id digest.Digest, manifestListDigest digest.Digest, err error) {
    manifestListDigest, err = schema2ManifestDigest(ref, mfstList)
    if err != nil {
        return "", "", err
    }

Method puller.pullSchema1 has 10 return statements (exceeds 4 allowed).

Open

func (p *puller) pullSchema1(ctx context.Context, ref reference.Reference, unverifiedManifest *schema1.SignedManifest, platform *ocispec.Platform) (id digest.Digest, manifestDigest digest.Digest, err error) {
    if platform != nil {
        // Early bath if the requested OS doesn't match that of the configuration.
        // This avoids doing the download, only to potentially fail later.
        if err := image.CheckOS(platform.OS); err != nil {

Method Manager.Pull has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (pm *Manager) Pull(ctx context.Context, ref reference.Named, name string, metaHeader http.Header, authConfig *registry.AuthConfig, privileges types.PluginPrivileges, outStream io.Writer, opts ...CreateOpt) (err error) {

Method Manager.Pull has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (pm *Manager) Pull(ctx context.Context, ref reference.Named, name string, metaHeader http.Header, authConfig *registry.AuthConfig, privileges types.PluginPrivileges, out io.Writer, opts ...CreateOpt) error {

Method tarexporter.legacyLoad has 10 return statements (exceeds 4 allowed).

Open

func (l *tarexporter) legacyLoad(tmpDir string, outStream io.Writer, progressOutput progress.Output) error {
    if runtime.GOOS == "windows" {
        return errors.New("Windows does not support legacy loading of images")
    }

Function Join has 10 return statements (exceeds 4 allowed).

Open

func Join(ctx context.Context, path, subpath string) (*SafePath, error) {
    base, subpart, err := evaluatePath(path, subpath)
    if err != nil {
        return nil, err
    }

Method Resolver.setupIPTable has 10 return statements (exceeds 4 allowed).

Open

func (r *Resolver) setupIPTable() error {
    if r.err != nil {
        return r.err
    }
    laddr := r.conn.LocalAddr().String()

Method addrSpace.allocatePredefinedPool has 10 return statements (exceeds 4 allowed).

Open

func (aSpace *addrSpace) allocatePredefinedPool(reserved []netip.Prefix) (netip.Prefix, error) {
    aSpace.mu.Lock()
    defer aSpace.mu.Unlock()

    var pdfID int

Method Endpoint.sbLeave has 10 return statements (exceeds 4 allowed).

Open

func (ep *Endpoint) sbLeave(ctx context.Context, sb *Sandbox, force bool) error {
    n, err := ep.getNetworkFromStore()
    if err != nil {
        return fmt.Errorf("failed to get network from store during leave: %v", err)
    }

Function setupIPChains has 10 return statements (exceeds 4 allowed).

Open

func setupIPChains(config configuration, version iptables.IPVersion) (natChain *iptables.ChainInfo, filterChain *iptables.ChainInfo, isolationChain1 *iptables.ChainInfo, isolationChain2 *iptables.ChainInfo, retErr error) {
    // Sanity check.
    if version == iptables.IPv4 && !config.EnableIPTables {
        return nil, nil, nil, nil, errors.New("cannot create new chains, iptables is disabled")
    }

Method networkRouter.getNetwork has 10 return statements (exceeds 4 allowed).

Open

func (n *networkRouter) getNetwork(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }

Method imageRouter.postImagesCreate has 10 return statements (exceeds 4 allowed).

Open

func (ir *imageRouter) postImagesCreate(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }

Function newImageBuildOptions has 10 return statements (exceeds 4 allowed).

Open

func newImageBuildOptions(ctx context.Context, r *http.Request) (*types.ImageBuildOptions, error) {
    options := &types.ImageBuildOptions{
        Version:        types.BuilderV1, // Builder V1 is the default, but can be overridden
        Dockerfile:     r.FormValue("dockerfile"),
        SuppressOutput: httputils.BoolValue(r, "q"),