Method `weathermap_poller_bottom` has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function weathermap_poller_bottom()
{
    global $config;
    global $weathermapPollerStartTime;

Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php - About 1 hr to fix

Method `translateRuntimeOptionsToSettings` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function translateRuntimeOptionsToSettings()
    {
        global $weathermap_error_suppress;

        $this->configFile = $this->getOpt->getOption('config');

Found in lib/Weathermap/CLI/Runner.php - About 1 hr to fix

Method `testIndexOrphans` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testIndexOrphans()
    {
        # Check that all the little config XML files actually appear somewhere in the index.xml
        $docsIndex = $this->docsRoot . "/index.xml";

Found in lib/Weathermap/Tests/DocsTest.php - About 1 hr to fix

Method `drawRealIcon` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function drawRealIcon(&$map, $iconColour)
    {
        $this->iconfile = $map->processString($this->iconfile, $this);

        MapUtility::debug('Actual image-based icon from ' . $this->iconfile . " for $this->name\n");

Found in lib/Weathermap/Core/MapNode.php - About 1 hr to fix

Function `render` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        if (!this.state.map) {
            return <div className='wm-map-properties-container wm-popup'>No such map? (or loading)</div>
        }

Found in websrc/cacti-mgmt/src/components/MapProperties.js - About 1 hr to fix

Method `updateLink` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateLink($linkName, $params)
    {
        if (!$this->isLoaded()) {
            throw new WeathermapInternalFail("Map must be loaded before editing API called.");
        }

Found in lib/Weathermap/Editor/Editor.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } elseif ($hostname != '') {
            $res3 =
                db_fetch_row("select id,hostname from host where description='" . mysql_real_escape_string($hostname)
                    . "'");

Found in random-bits/cacti-integrate.php and 1 other location - About 1 hr to fix

Read up
Read up

random-bits/cacti-integrate.php on lines 211..238

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings