wikimedia/mediawiki-extensions-DonationInterface

View on GitHub

Showing 275 of 275 total issues

Method getCleanTrackingData has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCleanTrackingData( $unset = false ) {
        // define valid tracking fields
        $tracking_fields = [
            'amount',
            'appeal',
Severity: Major
Found in gateway_common/DonationData.php - About 2 hrs to fix

    File adyen_submit_payment.api.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    use SmashPig\Core\DataStores\QueueWrapper;
    use SmashPig\Core\SequenceGenerators;
    use SmashPig\Core\UtcDate;
    use SmashPig\PaymentData\FinalStatus;
    Severity: Minor
    Found in adyen_gateway/adyen_submit_payment.api.php - About 2 hrs to fix

      Method getSupportedGateways has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getSupportedGateways(
              string $country,
              ?string $currency,
              string $paymentMethod,
              ?string $paymentSubmethod,
      Severity: Minor
      Found in special/GatewayChooser.php - About 2 hrs to fix

        Method getLocalizedValidationErrorResult has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
                $localizedErrors = [];
                foreach ( $validationErrors as $error ) {
                    $field = $error->getField();
                    $debugMessage = $error->getDebugMessage();
        Severity: Minor
        Found in dlocal_gateway/dlocal.adapter.php - About 2 hrs to fix

          Function setup has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function setup() {
                  var component_type,
                      config,
                      containerName = 'component-container',
                      oldShowErrors,
          Severity: Minor
          Found in adyen_gateway/forms/adyen.js - About 1 hr to fix

            Method handleCreatedPayment has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function handleCreatedPayment(
                    CreatePaymentResponse $createPaymentResult, PaymentProvider $provider
                ): PaymentResult {
                    $transactionStatus = $createPaymentResult->getStatus();
            
            
            Severity: Minor
            Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

              Function submitPayment has 48 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function submitPayment() {
                      if ( !mw.donationInterface.validation.validateAmount() ) {
                          return;
                      }
                      if ( !cardSelected ) {
              Severity: Minor
              Found in amazon_gateway/amazon.js - About 1 hr to fix

                Function validateAmount has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                window.validateAmount = function () {
                    var error = true,
                        amount = $( 'input[name="amount"]' ).val(), // get the amount
                        currency = '',
                        rates = mw.config.get( 'wgDonationInterfaceCurrencyRates' ),
                Severity: Minor
                Found in modules/validate_input.js - About 1 hr to fix

                  Method getParamsFromURL has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function getParamsFromURL(): array {
                          // Get country code from request param, or, if it's not sent or is invalid, use
                          // geoip lookup
                          $country = $this->sanitizedValOrNull( 'country' );
                  
                  
                  Severity: Minor
                  Found in special/GatewayChooser.php - About 1 hr to fix

                    Function getParamsFromURL has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function getParamsFromURL(): array {
                            // Get country code from request param, or, if it's not sent or is invalid, use
                            // geoip lookup
                            $country = $this->sanitizedValOrNull( 'country' );
                    
                    
                    Severity: Minor
                    Found in special/GatewayChooser.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getLocalizedValidationErrorResult has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
                            $localizedErrors = [];
                            foreach ( $validationErrors as $error ) {
                                $field = $error->getField();
                                $debugMessage = $error->getDebugMessage();
                    Severity: Minor
                    Found in dlocal_gateway/dlocal.adapter.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function session_resetForNewAttempt has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function session_resetForNewAttempt( $force = false ) {
                            $reset = $force;
                            if ( $this->session_getData( 'numAttempt' ) > 3 ) {
                                $reset = true;
                                WmfFramework::setSessionValue( 'numAttempt', 0 );
                    Severity: Minor
                    Found in gateway_common/gateway.adapter.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method execute has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function execute( $par ) {
                            // Bow out if gateway chooser is not enabled
                            if ( !$this->getConfig()->get( 'DonationInterfaceEnableGatewayChooser' ) ) {
                                throw new BadTitleError();
                            }
                    Severity: Minor
                    Found in special/GatewayChooser.php - About 1 hr to fix

                      Method session_resetOnSwitch has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function session_resetOnSwitch() {
                              $oldData = $this->session_getData( 'Donor' );
                              if ( !is_array( $oldData ) ) {
                                  return;
                              }
                      Severity: Minor
                      Found in gateway_common/gateway.adapter.php - About 1 hr to fix

                        Method session_resetForNewAttempt has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function session_resetForNewAttempt( $force = false ) {
                                $reset = $force;
                                if ( $this->session_getData( 'numAttempt' ) > 3 ) {
                                    $reset = true;
                                    WmfFramework::setSessionValue( 'numAttempt', 0 );
                        Severity: Minor
                        Found in gateway_common/gateway.adapter.php - About 1 hr to fix

                          Function setLocaleAndTranslations has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              function setLocaleAndTranslations( config, localeFromServer ) {
                                  // Adyen supports the locales listed below, according to
                                  // https://docs.adyen.com/online-payments/web-components/localization-components#supported-languages
                                  var adyenSupportedLocale = [
                                      'zh-CN', 'zh-TW', 'hr-HR', 'cs-CZ',
                          Severity: Minor
                          Found in adyen_gateway/forms/adyen.js - About 1 hr to fix

                            Method getMessageFields has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public static function getMessageFields() {
                                    return [
                                        'contribution_tracking_id',
                                        'anonymous',
                                        'utm_source',
                            Severity: Minor
                            Found in gateway_common/DonationData.php - About 1 hr to fix

                              Method defineTransactions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  protected function defineTransactions() {
                                      $this->transactions = [];
                              
                                      // https://developer.paypal.com/docs/classic/api/merchant/SetExpressCheckout_API_Operation_NVP/
                                      $this->transactions['SetExpressCheckout'] = [
                              Severity: Minor
                              Found in paypal_ec_gateway/paypal_express.adapter.php - About 1 hr to fix

                                Method getLocalizedValidationErrorResult has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
                                        $localizedErrors = [];
                                        foreach ( $validationErrors as $error ) {
                                            $field = $error->getField();
                                            $debugMessage = $error->getDebugMessage();
                                Severity: Minor
                                Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

                                  Function createWalletWidget has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      function createWalletWidget() {
                                          var params = {
                                              sellerId: sellerId,
                                              onReady: function ( billingAgreement ) {
                                                  if ( !cardSelected ) {
                                  Severity: Minor
                                  Found in amazon_gateway/amazon.js - About 1 hr to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language