Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 440 of 440 total issues

Avoid using static access to class '\Seat\Eveapi\Models\PlanetaryInteraction\CorporationCustomsOffice' in method 'handle'.
Open

                $model = CorporationCustomsOffice::firstOrNew([
                    'corporation_id' => $this->getCorporationId(),
                    'office_id' => $office->office_id,
                ]);
Severity: Minor
Found in src/Jobs/PlanetaryInteraction/Corporation/CustomsOffices.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationInfo' in method 'created'.
Open

        if (! CorporationInfo::find($affiliation->corporation_id) && RefreshToken::withTrashed()->find($affiliation->character_id))
Severity: Minor
Found in src/Observers/CharacterAffiliationObserver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterMedal' in method 'handle'.
Open

            $model = CharacterMedal::firstOrNew([
                'character_id' => $this->getCharacterId(),
                'medal_id' => $medal->medal_id,
            ]);
Severity: Minor
Found in src/Jobs/Character/Medals.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractDetail' in method 'handle'.
Open

                $model = ContractDetail::firstOrNew([
                    'contract_id' => $contract->contract_id,
                ]);
Severity: Minor
Found in src/Jobs/Contracts/Corporation/Contracts.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Corporation\CorporationRole' in method 'handle'.
Open

                    CorporationRole::firstOrCreate([
                        'corporation_id' => $this->getCorporationId(),
                        'character_id' => $role->character_id,
                        'type' => $type,
                        'role' => $name,
Severity: Minor
Found in src/Jobs/Corporation/Roles.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {

                    // If no services are defined on this structure, remove all of the
                    // ones we might have in the database.
                    CorporationStructureService::where('structure_id', $structure->structure_id)
Severity: Minor
Found in src/Jobs/Corporation/Structures.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Illuminate\Support\Facades\Redis' in method 'getRateLimitKeyTtl'.
Open

        $redis = Redis::connection('cache');
Severity: Minor
Found in src/Jobs/EsiBase.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Industry\CorporationIndustryJob' in method 'handle'.
Open

                $model = CorporationIndustryJob::firstOrNew([
                    'corporation_id' => $this->getCorporationId(),
                    'job_id' => $job->job_id,
                ]);
Severity: Minor
Found in src/Jobs/Industry/Corporation/Jobs.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailDetail' in method 'handle'.
Open

                if (! KillmailDetail::find($killmail->killmail_id))
Severity: Minor
Found in src/Jobs/Killmails/Corporation/Recent.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\RefreshToken' in method 'handlePrivateCharacterJobs'.
Open

        $refresh_token = RefreshToken::findOrFail($this->option('character_id'));
Severity: Minor
Found in src/Commands/Esi/Job/Dispatch.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method handlePublicCorporationJobs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $job::dispatch($this->option('corporation_id'));
        }
Severity: Minor
Found in src/Commands/Esi/Job/Dispatch.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Seat\Eveapi\Models\Alliances\Alliance' in method 'handle'.
Open

        $model = Alliance::firstOrNew([
            'alliance_id' => $this->alliance_id,
        ]);
Severity: Minor
Found in src/Jobs/Alliances/Info.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method handle() has 126 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function handle()
    {
        parent::handle();

        // all items which need to be singleton
Severity: Minor
Found in src/Jobs/Assets/Corporation/Locations.php by phpmd

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterAffiliation' in method 'handle'.
Open

                CharacterAffiliation::updateOrCreate(
                    ['character_id' => $affiliation->character_id],
                    ['corporation_id' => $affiliation->corporation_id, 'alliance_id' => $affiliation->alliance_id ?? null, 'faction_id' => $affiliation->faction_id ?? null]
                );
Severity: Minor
Found in src/Jobs/Character/Affiliation.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterAgentResearch' in method 'handle'.
Open

            $model = CharacterAgentResearch::firstOrNew([
                'character_id' => $this->getCharacterId(),
                'agent_id' => $agent->agent_id,
            ]);
Severity: Minor
Found in src/Jobs/Character/AgentsResearch.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterBlueprint' in method 'handle'.
Open

                    $model = CharacterBlueprint::firstOrNew([
                        'item_id' => $blueprint->item_id,
                    ]);
Severity: Minor
Found in src/Jobs/Character/Blueprints.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterInfo' in method 'handle'.
Open

        $model = CharacterInfo::firstOrNew([
            'character_id' => $this->getCharacterId(),
        ]);
Severity: Minor
Found in src/Jobs/Character/Info.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Character\CharacterInfo' in method 'handle'.
Open

        $character = CharacterInfo::find($this->getCharacterId());
Severity: Minor
Found in src/Jobs/Character/Titles.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\ContractBid' in method 'handle'.
Open

                        ContractBid::firstOrCreate([
                            'bid_id' => $bid->bid_id,
                        ], [
                            'contract_id' => $this->contract_id,
                            'bidder_id' => $bid->bidder_id,
Severity: Minor
Found in src/Jobs/Contracts/Character/Bids.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Contracts\CorporationContract' in method 'handle'.
Open

                CorporationContract::firstOrCreate([
                    'corporation_id' => $this->getCorporationId(),
                    'contract_id' => $contract->contract_id,
                ]);
Severity: Minor
Found in src/Jobs/Contracts/Corporation/Contracts.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language