Function `GetBlkVal` has 5 return statements (exceeds 4 allowed).
Open

func GetBlkVal(key string, cur *param.BlockDeviceQueue) (string, string, error) {
    retVal := ""
    info := ""

    switch {

Found in sap/note/sectBlock.go - About 35 mins to fix

Method `App.RevertSolution` has 5 return statements (exceeds 4 allowed).
Open

func (app *App) RevertSolution(solName string) error {
    sol, err := app.GetSolutionByName(solName)
    if err != nil {
        return err
    }

Found in app/app.go - About 35 mins to fix

Function `SecureBootEnabled` has 5 return statements (exceeds 4 allowed).
Open

func SecureBootEnabled() bool {
    var isSecBootFileName = regexp.MustCompile(`^SecureBoot-\w[\w-]+`)
    if _, err := os.Stat(efiVarsDir); os.IsNotExist(err) {
        InfoLog("no EFI directory '%+s' found, assuming legacy boot", efiVarsDir)
        return false

Found in system/cpu.go - About 35 mins to fix

Function `SetBlkVal` has 5 return statements (exceeds 4 allowed).
Open

func SetBlkVal(key, value string, cur *param.BlockDeviceQueue, revert bool) error {
    var err error

    switch {
    case system.IsSched.MatchString(key):

Found in sap/note/sectBlock.go - About 35 mins to fix

Method `App.RevertNote` has 5 return statements (exceeds 4 allowed).
Open

func (app *App) RevertNote(noteID string, permanent bool) error {

    noteTemplate, err := app.GetNoteByID(noteID)
    if err != nil {
        // to revert an applied note even if the corresponding

Found in app/app.go - About 35 mins to fix

Method `App.TuneSolution` has 5 return statements (exceeds 4 allowed).
Open

func (app *App) TuneSolution(solName string) (removedExplicitNotes []string, err error) {
    removedExplicitNotes = make([]string, 0)
    sol, err := app.GetSolutionByName(solName)
    if err != nil {
        return

Found in app/app.go - About 35 mins to fix

Method `App.VerifyNote` has 5 return statements (exceeds 4 allowed).
Open

func (app *App) VerifyNote(noteID string) (conforming bool, comparisons map[string]note.FieldComparison, valApplyList []string, err error) {
    theNote, err := app.GetNoteByID(noteID)
    if err != nil {
        return
    }

Found in app/app.go - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func GetSysString(parameter string) (string, error) {
    val, err := ioutil.ReadFile(path.Join("/sys", strings.Replace(parameter, ".", "/", -1)))
    if err != nil {
        WarningLog("failed to read sys string key '%s': %v", parameter, err)
        return "PNA", err

Found in system/sys.go and 1 other location - About 35 mins to fix

Read up
Read up

system/sysctl.go on lines 184..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.