Showing 347 of 1,158 total issues
Function play
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
play(game, player_cards, card_player) {
let eligible_cards = _.filter(player_cards.hand, function(card) {
return _.includes(_.words(card.types), 'treasure')
})
if (_.size(eligible_cards) > 0) {
Function play
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
play(game, player_cards, card_player) {
let card_drawer = new CardDrawer(game, player_cards, card_player)
card_drawer.draw(1)
let action_gainer = new ActionGainer(game, player_cards)
Function base2
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
static base2() {
return [
'Cellar',
'Chapel',
'Moat',
Function seaside
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
static seaside() {
return [
'Embargo',
'Haven',
'Lighthouse',
Function hinterlands
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
static hinterlands() {
return [
'Crossroads',
'Duchess',
'FoolsGold',
Function intrigue2
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
static intrigue2() {
return [
'Courtyard',
'Lurker',
'Pawn',
Function player
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
player() {
let player = PlayerRankings.findOne({username: FlowRouter.getParam('id')}, {
transform: function(player) {
let total_games = player.wins + player.losses
player.win_ratio = total_games === 0 ? 0 : ((player.wins / total_games) * 100).toFixed(2)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function valid_selection
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
valid_selection() {
if (this.turn_event.type === 'overpay') {
if (this.selection < this.turn_event.minimum) {
this.error = `You can't overpay less than ${this.turn_event.minimum}`
} else if (this.selection > this.turn_event.maximum) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function set_aside_prince
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
static set_aside_prince(game, player_cards, response, prince) {
if (response === 'yes') {
let card_mover = new CardMover(game, player_cards)
if (card_mover.move(player_cards.in_play, player_cards.aside, prince)) {
game.log.push(` <strong>${player_cards.username}</strong> sets aside ${CardView.render(prince)}`)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function play
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
play(game, player_cards, card_player) {
let card_gainer = new CardGainer(game, player_cards, 'discard', 'Silver')
card_gainer.gain()
GameModel.update(game._id, game)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function play
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
play(game, player_cards) {
if (_.size(player_cards.deck) === 0 && _.size(player_cards.discard) === 0) {
game.log.push(` but there are no cards in their deck`)
} else {
let card_revealer = new CardRevealer(game, player_cards)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function process_response
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
static process_response(game, player_cards, response) {
if (response[0] === 'gain') {
let eligible_cards = _.filter(game.trash, (card) => {
return CardCostComparer.coin_between(game, card, 3, 6)
})
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function play
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
play(game, player_cards, card_player) {
let coin_gainer = new CoinGainer(game, player_cards, card_player)
coin_gainer.gain(3)
GameModel.update(game._id, game)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buy
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
buy(game, player_cards) {
let buy_gainer = new BuyGainer(game, player_cards)
buy_gainer.gain(1)
if (_.size(player_cards.deck) > 0 || _.size(player_cards.discard) > 0) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function play
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
play(game, player_cards) {
let gained_coin = 2
if (game.turn.envious) {
gained_coin = 1
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function receive
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
receive(game, player_cards) {
if (_.size(player_cards.hand) > 4) {
let eligible_cards = _.filter(player_cards.hand, function(card) {
return _.includes(_.words(card.types), 'treasure') || _.includes(_.words(card.types), 'action')
})
Function play
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
play(game, player_cards, card_player) {
let coin_gainer = new CoinGainer(game, player_cards, card_player)
coin_gainer.gain(2)
if (_.size(player_cards.deck) === 0 && _.size(player_cards.discard) === 0) {
Function duration
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
duration(game, player_cards, mastermind) {
game.log.push(`<strong>${player_cards.username}</strong> resolves ${CardView.render(mastermind)}`)
let eligible_cards = _.filter(player_cards.hand, (card) => {
return _.includes(_.words(card.types), 'action')
})
Function play
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
play(game, player_cards, card_player) {
let card_drawer = new CardDrawer(game, player_cards, card_player)
card_drawer.draw(1)
let action_gainer = new ActionGainer(game, player_cards)
Function trash_card
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
static trash_card(game, player_cards, selected_cards) {
let selected_card = selected_cards[0]
let card_trasher = new CardTrasher(game, player_cards, 'hand', selected_card)
card_trasher.trash()