Sign upLogin

ckeditor/ckeditor5-engine

View on GitHub
Star

Showing 564 of 564 total issues

Function _validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _validate() {
        const element = this.splitPosition.parent;
        const offset = this.splitPosition.offset;

        // Validate whether split operation has correct parameters.
Severity: Minor
Found in src/model/operation/splitoperation.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _setAttributesTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _setAttributesTo( attrs ) {
        const changed = new Set();

        for ( const [ oldKey, oldValue ] of this.getAttributes() ) {
            // Do not remove attribute if attribute with same key and value is about to be set.
Severity: Minor
Found in src/model/documentselection.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function normalizeToAttributeConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function normalizeToAttributeConfig( view ) {
    if ( typeof view == 'string' ) {
        return modelAttributeValue => ( { key: view, value: modelAttributeValue } );
    } else if ( typeof view == 'object' ) {
        // { key, value, ... }
Severity: Minor
Found in src/conversion/downcasthelpers.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getTransformedByMergeOperation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _getTransformedByMergeOperation( operation ) {
        const movedRange = operation.movedRange;
        const isContained = movedRange.containsPosition( this ) || movedRange.start.isEqual( this );

        let pos;
Severity: Minor
Found in src/model/position.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _markDescendantTextToSync has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _markDescendantTextToSync( viewNode ) {
        if ( !viewNode ) {
            return;
        }
Severity: Minor
Found in src/view/renderer.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downcastAttributeToElement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function downcastAttributeToElement( config ) {
    config = cloneDeep( config );

    const modelKey = config.model.key ? config.model.key : config.model;
    let eventName = 'attribute:' + modelKey;
Severity: Minor
Found in src/conversion/downcasthelpers.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downcastAttributeToAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function downcastAttributeToAttribute( config ) {
    config = cloneDeep( config );

    const modelKey = config.model.key ? config.model.key : config.model;
    let eventName = 'attribute:' + modelKey;
Severity: Minor
Found in src/conversion/downcasthelpers.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    getAttribute( key ) {
        if ( key == 'class' ) {
            if ( this._classes.size > 0 ) {
                return [ ...this._classes ].join( ' ' );
            }
Severity: Minor
Found in src/view/element.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    constructor( root, path, stickiness = 'toNone' ) {
        if ( !root.is( 'element' ) && !root.is( 'documentFragment' ) ) {
            /**
             * Position root is invalid.
             *
Severity: Minor
Found in src/model/position.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDifference has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    getDifference( otherRange ) {
        const ranges = [];

        if ( this.isIntersecting( otherRange ) ) {
            // Ranges intersect.
Severity: Minor
Found in src/view/range.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getStoredAttributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    * _getStoredAttributes() {
        const selectionParent = this.getFirstPosition().parent;

        if ( this.isCollapsed && selectionParent.isEmpty ) {
            for ( const key of selectionParent.getAttributeKeys() ) {
Severity: Minor
Found in src/model/documentselection.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jumpOverInlineFiller has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function jumpOverInlineFiller( evt, data ) {
    if ( data.keyCode == keyCodes.arrowleft ) {
        const domSelection = data.domTarget.ownerDocument.defaultView.getSelection();

        if ( domSelection.rangeCount == 1 && domSelection.getRangeAt( 0 ).collapsed ) {
Severity: Minor
Found in src/view/filler.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getTransformedBySplitOperation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _getTransformedBySplitOperation( operation ) {
        const movedRange = operation.movedRange;

        const isContained = movedRange.containsPosition( this ) ||
            ( movedRange.start.isEqual( this ) && this.stickiness == 'toNext' );
Severity: Minor
Found in src/model/position.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _removeDomSelection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _removeDomSelection() {
        for ( const doc of this.domDocuments ) {
            const domSelection = doc.getSelection();

            if ( domSelection.rangeCount ) {
Severity: Minor
Found in src/view/renderer.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convertMarkerAdd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    convertMarkerAdd( markerName, markerRange, writer ) {
        // Do not convert if range is in graveyard or not in the document (e.g. in DocumentFragment).
        if ( !markerRange.root.document || markerRange.root.rootName == '$graveyard' ) {
            return;
        }
Severity: Minor
Found in src/conversion/downcastdispatcher.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function unbindElementFromMarkerName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    unbindElementFromMarkerName( element, name ) {
        const nameToElements = this._markerNameToElements.get( name );

        if ( nameToElements ) {
            nameToElements.delete( element );
Severity: Minor
Found in src/conversion/mapper.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addInlineFiller has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function addInlineFiller( domDocument, domParentOrArray, offset ) {
    const childNodes = domParentOrArray instanceof Array ? domParentOrArray : domParentOrArray.childNodes;
    const nodeAfterFiller = childNodes[ offset ];

    if ( isText( nodeAfterFiller ) ) {
Severity: Minor
Found in src/view/renderer.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _setAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function _setAttribute( range, key, value ) {
    // Range might start or end in text nodes, so we have to split them.
    _splitNodeAtPosition( range.start );
    _splitNodeAtPosition( range.end );
Severity: Minor
Found in src/model/operation/utils.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getAttributesDiff has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _getAttributesDiff( range, oldAttributes, newAttributes ) {
        // Results holder.
        const diffs = [];

        // Clone new attributes as we will be performing changes on this object.
Severity: Minor
Found in src/model/differ.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clearAttributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    clearAttributes( itemOrRange ) {
        this._assertWriterUsedCorrectly();

        const removeAttributesFromItem = item => {
            for ( const attribute of item.getAttributeKeys() ) {
Severity: Minor
Found in src/model/writer.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language