Sign upLogin

jcbantuelle/dominion-meteor

View on GitHub
Star

Showing 347 of 1,158 total issues

Function trash_cards has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static trash_cards(game, player_cards, selected_cards) {
    let cost = _.reduce(selected_cards, (total_cost, card) => {
      return total_cost + CostCalculator.calculate(game, card)
    }, 0)
Severity: Minor
Found in app/cards/prosperity/forge.js - About 1 hr to fix

    Function play has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      play(game, player_cards, card_player) {
    let coin_gainer = new CoinGainer(game, player_cards, card_player)
    coin_gainer.gain(2)

    let eligible_cards = _.filter(game.trash, function(card) {
    Severity: Minor
    Found in app/cards/dark_ages/rogue.js - About 1 hr to fix

      Function trash_card has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static trash_card(game, player_cards, selected_cards, card_player) {
    let number_of_options = CostCalculator.calculate(game, selected_cards[0])
    number_of_options = Math.min(6, number_of_options)

    let card_trasher = new CardTrasher(game, player_cards, 'hand', selected_cards[0])
      Severity: Minor
      Found in app/cards/menagerie/scrap.js - About 1 hr to fix

        Function exile_card has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static exile_card(game, player_cards, selected_cards) {
    let eligible_cards = _.filter(game.cards, function(card) {
      return card.name !== selected_cards[0].name && card.count > 0 && card.supply && CardCostComparer.card_less_than(game, selected_cards[0], card.top_card, 3)
    })
        Severity: Minor
        Found in app/cards/menagerie/displace.js - About 1 hr to fix

          Function buy has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            buy(game, player_cards) {
    let eligible_cards = _.filter(player_cards.discard, (card) => {
      return _.includes(_.words(card.types), 'action')
    })
          Severity: Minor
          Found in app/cards/menagerie/events/march.js - About 1 hr to fix

            Function play has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              play(game, player_cards, card_player) {
    let action_gainer = new ActionGainer(game, player_cards)
    action_gainer.gain(1)

    let current_player_card_revealer = new CardRevealer(game, player_cards)
            Severity: Minor
            Found in app/cards/empires/chariot_race.js - About 1 hr to fix

              Function trash_card has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static trash_card(game, player_cards, selected_cards) {
    let selected_card = selected_cards[0]

    let card_trasher = new CardTrasher(game, player_cards, 'hand', selected_cards)
    card_trasher.trash()
              Severity: Minor
              Found in app/cards/guilds/stonemason.js - About 1 hr to fix

                Function base1 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  static base1() {
    return [
      'Cellar',
      'Chapel',
      'Moat',
                Severity: Minor
                Found in app/cards/lib/card_list.js - About 1 hr to fix

                  Function prosperity has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    static prosperity() {
    return [
      'Loan',
      'TradeRoute',
      'Watchtower',
                  Severity: Minor
                  Found in app/cards/lib/card_list.js - About 1 hr to fix

                    Function attack has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      attack(game, player_cards) {
    if (_.size(player_cards.hand) > 4) {
      let eligible_cards = _.filter(player_cards.hand, function (card) {
        return CardCostComparer.coin_greater_than(game, card, 1)
      })
                    Severity: Minor
                    Found in app/cards/renaissance/villain.js - About 1 hr to fix

                      Function intrigue1 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        static intrigue1() {
    return [
      'Courtyard',
      'Pawn',
      'SecretChamber',
                      Severity: Minor
                      Found in app/cards/lib/card_list.js - About 1 hr to fix

                        Function trash_card has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          static trash_card(game, player_cards, selected_cards, improve) {
    if (_.size(selected_cards) > 0) {
      game.log.push(`<strong>${player_cards.username}</strong> resolves ${CardView.render(improve)}`)
      let eligible_cards = _.filter(game.cards, (card) => {
        return card.count > 0 && card.supply  && CardCostComparer.card_equal_to(game, selected_cards[0], card.top_card, 1)
                        Severity: Minor
                        Found in app/cards/renaissance/improve.js - About 1 hr to fix

                          Function renaissance has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            static renaissance() {
    return [
      'BorderGuard',
      'Ducat',
      'Lackeys',
                          Severity: Minor
                          Found in app/cards/lib/card_list.js - About 1 hr to fix

                            Function play has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              play(game, player_cards, card_player) {
    let card_drawer = new CardDrawer(game, player_cards, card_player)
    card_drawer.draw(1)

    let action_gainer = new ActionGainer(game, player_cards)
                            Severity: Minor
                            Found in app/cards/nocturne/secret_cave.js - About 1 hr to fix

                              Function play has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                play(game, player_cards, card_player) {
    let card_drawer = new CardDrawer(game, player_cards, card_player)
    card_drawer.draw(2)

    GameModel.update(game._id, game)
                              Severity: Minor
                              Found in app/cards/cornucopia/young_witch.js - About 1 hr to fix

                                Function play has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                  play(game, player_cards, card_player) {
    let buy_gainer = new BuyGainer(game, player_cards)
    buy_gainer.gain(1)

    let coin_gainer = new CoinGainer(game, player_cards, card_player)
                                Severity: Minor
                                Found in app/cards/cornucopia/horse_traders.js - About 1 hr to fix

                                  Function star_chart has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    star_chart() {
    this.star_chart_card = _.find(this.player_cards.projects, (project) => {
      return project.name === 'Star Chart'
    })
    if (this.star_chart_card) {
                                  Severity: Minor
                                  Found in app/game/server/services/deck_shuffler.js - About 1 hr to fix

                                    Function discard has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                      discard(announce = true) {
    if (!_.isEmpty(this.cards)) {
      let ordered_discard = this.has_events() || this.has_schemes()
      if (_.size(this.cards) > 1 && ordered_discard) {
        let turn_event_id = TurnEventModel.insert({
                                    Severity: Minor
                                    Found in app/game/server/services/card_discarder.js - About 1 hr to fix

                                      Function play has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                        play(game, player_cards, card_player) {
    let card_drawer = new CardDrawer(game, player_cards, card_player)
    card_drawer.draw(2)

    let action_gainer = new ActionGainer(game, player_cards)
                                      Severity: Minor
                                      Found in app/cards/empires/encampment.js - About 1 hr to fix

                                        Function trash_card has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                          static trash_card(game, player_cards, selected_cards) {
    let eligible_cards = _.filter(game.cards, (card) => {
      return card.count > 0 && card.supply && CardCostComparer.card_less_than(game, selected_cards[0], card.top_card, 4)
    })
                                        Severity: Minor
                                        Found in app/cards/dark_ages/graverobber.js - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language