Sign upLogin

jcbantuelle/dominion-meteor

View on GitHub
Star

Showing 347 of 1,158 total issues

Function process_response has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static process_response(game, player_cards, response, card_player) {
    let wild_hunt_index = _.findIndex(game.cards, (card) => {
      return card.name === 'Wild Hunt'
    })
Severity: Minor
Found in app/cards/empires/wild_hunt.js - About 1 hr to fix

    Function attack has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      attack(game, player_cards, attacker_player_cards, card_player, trashed_card) {
    if (trashed_card) {

      if (CardCostComparer.coin_greater_than(game, trashed_card, 2)) {
        let card_gainer = new CardGainer(game, player_cards, 'discard', 'Curse')
    Severity: Minor
    Found in app/cards/empires/catapult.js - About 1 hr to fix

      Function trash_card has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static trash_card(game, player_cards, selected_cards) {
    let selected_card = selected_cards[0]

    let card_trasher = new CardTrasher(game, player_cards, 'hand', selected_cards)
    card_trasher.trash()
      Severity: Minor
      Found in app/cards/promo/dismantle.js - About 1 hr to fix

        Function attack has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          attack(game, player_cards) {
    if (_.size(player_cards.deck) === 0 && _.size(player_cards.discard) === 0) {
      game.log.push(`&nbsp;&nbsp;<strong>${player_cards.username}</strong> has no cards in deck`)
    } else {
      let card_revealer = new CardRevealer(game, player_cards)
        Severity: Minor
        Found in app/cards/base/thief.js - About 1 hr to fix

          Function buy has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            buy(game, player_cards) {
    let buy_gainer = new BuyGainer(game, player_cards)
    buy_gainer.gain(1)

    let eligible_cards = _.filter(player_cards.hand, (card) => {
          Severity: Minor
          Found in app/cards/menagerie/events/toil.js - About 1 hr to fix

            Function buy has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              buy(game, player_cards) {
    let eligible_cards = _.filter(player_cards.hand, function(card) {
      return _.includes(_.words(card.types), 'action')
    })
            Severity: Minor
            Found in app/cards/menagerie/events/delay.js - About 1 hr to fix

              Function buy has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                buy(game, player_cards) {
    let eligible_cards = _.filter(game.cards, (card) => {
      return card.count > 0 && card.supply && !_.includes(_.words(card.top_card.types), 'victory') && CardCostComparer.coin_less_than(game, card.top_card, 6)
    })
              Severity: Minor
              Found in app/cards/menagerie/events/bargain.js - About 1 hr to fix

                Function attack has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  attack(game, player_cards, attacker_player_cards) {
    if (_.size(player_cards.hand) > 4) {
      let copy_card_names = _.uniq(_.map(attacker_player_cards.in_play, 'name'))
      let eligible_cards = _.filter(player_cards.hand, function(card) {
        return _.includes(copy_card_names, card.name)
                Severity: Minor
                Found in app/cards/nocturne/raider.js - About 1 hr to fix

                  Function find_end_buy_events has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    find_end_buy_events() {
    let events = []

    _.each(this.player_cards.tavern, (card) => {
      if (_.includes(EndBuyEventProcessor.reserve_events(), card.name)) {
                  Severity: Minor
                  Found in app/game/server/services/end_buy_event_processor.js - About 1 hr to fix

                    Function take_unique_card has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      take_unique_card(source, unique_card_name) {
    let card_source = this.player_cards[source]
    let unique_card = this.find_unique_card(card_source, unique_card_name)

    if (!unique_card) {
                    Severity: Minor
                    Found in app/game/server/services/card_mover.js - About 1 hr to fix

                      Function discard_treasure has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        static discard_treasure(game, player_cards, selected_cards) {
    if (!_.isEmpty(selected_cards)) {
      let card_discarder = new CardDiscarder(game, player_cards, 'hand', selected_cards)
      card_discarder.discard()
                      Severity: Minor
                      Found in app/cards/nocturne/boons/the_earths_gift.js - About 1 hr to fix

                        Function find_start_cleanup_events has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          find_start_cleanup_events() {
    this.start_cleanup_events = []

    _.each(this.player_cards.aside, (card) => {
      if (_.includes(StartCleanupEventProcessor.aside_events(), card.name)) {
                        Severity: Minor
                        Found in app/game/server/services/start_cleanup_event_processor.js - About 1 hr to fix

                          Function trash has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            trash(announce = true) {
    if (!_.isEmpty(this.cards)) {
      let events = this.has_events()
      if (_.size(this.cards) > 1 && events) {
        let turn_event_id = TurnEventModel.insert({
                          Severity: Minor
                          Found in app/game/server/services/card_trasher.js - About 1 hr to fix

                            Function play has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              play(game, player_cards) {
    let coin_gainer = new CoinGainer(game, player_cards)
    coin_gainer.gain(3, false)

    let buy_gainer = new BuyGainer(game, player_cards)
                            Severity: Minor
                            Found in app/cards/prosperity/contraband.js - About 1 hr to fix

                              Function trash_card has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                static trash_card(game, player_cards, selected_cards) {
    if (!_.isEmpty(selected_cards)) {
      let card_trasher = new CardTrasher(game, player_cards, 'hand', selected_cards)
      let trashed_cards =card_trasher.trash()
                              Severity: Minor
                              Found in app/cards/empires/events/advance.js - About 1 hr to fix

                                Function play has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                  play(game, player_cards) {
    let action_gainer = new ActionGainer(game, player_cards)
    action_gainer.gain(1)

    if (_.size(player_cards.deck) === 0 && _.size(player_cards.discard) === 0) {
                                Severity: Minor
                                Found in app/cards/seaside/lookout.js - About 1 hr to fix

                                  Function play has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    play(game, player_cards, card_player) {
    let buy_gainer = new BuyGainer(game, player_cards)
    buy_gainer.gain(1)

    let estate = _.find(player_cards.hand, function(card) {
                                  Severity: Minor
                                  Found in app/cards/intrigue/baron.js - About 1 hr to fix

                                    Function buy has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                      buy(game, player_cards) {
    _.times(2, function() {
      let card_gainer = new CardGainer(game, player_cards, 'discard', 'Copper')
      card_gainer.gain()
    })
                                    Severity: Minor
                                    Found in app/cards/empires/events/banquet.js - About 1 hr to fix

                                      Function process_choice has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                        static process_choice(game, player_cards, choice) {
    choice = choice[0]
    if (choice === 'coin') {
      let coin_gainer = new CoinGainer(game, player_cards)
      coin_gainer.gain(1)
                                      Severity: Minor
                                      Found in app/cards/adventures/amulet.js - About 1 hr to fix

                                        Function reveal_cards has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                          static reveal_cards(game, player_cards, selected_cards) {
    let named_card
    if (!_.isEmpty(selected_cards)) {
      named_card = selected_cards[0].name
      game.log.push(`&nbsp;&nbsp;<strong>${player_cards.username}</strong> names ${CardView.render(selected_cards)}`)
                                        Severity: Minor
                                        Found in app/cards/guilds/journeyman.js - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language